@@ -212,11 +212,44 @@ describe("revealServerTabs", () => {
212212 return source ?. kind === "browser" ? source . tabId : null ;
213213 } ;
214214
215- it ( "floats revealed tabs, and only forced ones when floating previews are off" , ( ) => {
215+ const panelBrowserTabs = ( ) =>
216+ useRightPanelStore
217+ . getState ( )
218+ . byThreadKey [ threadKey ] ?. surfaces . filter ( ( surface ) => surface . kind === "preview" )
219+ . map ( ( surface ) => surface . resourceId ) ?? [ ] ;
220+
221+ it ( "floats revealed tabs when floating previews are on" , ( ) => {
222+ setup ( ) ;
223+ revealServerTabs ( ref , [ tab ( "tab_plain" ) ] , {
224+ autoShowFloatingPreview : true ,
225+ sheetLayout : false ,
226+ } ) ;
227+ expect ( floatingTabId ( ) ) . toBe ( "tab_plain" ) ;
228+ expect ( panelBrowserTabs ( ) ) . toEqual ( [ ] ) ;
229+ } ) ;
230+
231+ it ( "opens revealed tabs as panel tabs when floating previews are off" , ( ) => {
216232 setup ( ) ;
217- revealServerTabs ( ref , [ tab ( "tab_plain" ) ] , { autoShowFloatingPreview : false } ) ;
233+ revealServerTabs ( ref , [ tab ( "tab_plain" ) ] , {
234+ autoShowFloatingPreview : false ,
235+ sheetLayout : false ,
236+ } ) ;
218237 expect ( floatingTabId ( ) ) . toBeNull ( ) ;
219- revealServerTabs ( ref , [ tab ( "tab_forced" , true ) ] , { autoShowFloatingPreview : false } ) ;
238+ expect ( panelBrowserTabs ( ) ) . toEqual ( [ "tab_plain" ] ) ;
239+ } ) ;
240+
241+ it ( "in a sheet, floats only forced reveals when floating previews are off" , ( ) => {
242+ setup ( ) ;
243+ revealServerTabs ( ref , [ tab ( "tab_plain" ) ] , {
244+ autoShowFloatingPreview : false ,
245+ sheetLayout : true ,
246+ } ) ;
247+ expect ( floatingTabId ( ) ) . toBeNull ( ) ;
248+ expect ( panelBrowserTabs ( ) ) . toEqual ( [ ] ) ;
249+ revealServerTabs ( ref , [ tab ( "tab_forced" , true ) ] , {
250+ autoShowFloatingPreview : false ,
251+ sheetLayout : true ,
252+ } ) ;
220253 expect ( floatingTabId ( ) ) . toBe ( "tab_forced" ) ;
221254 } ) ;
222255
@@ -226,11 +259,17 @@ describe("revealServerTabs", () => {
226259 const browserSurfaceId = useRightPanelStore . getState ( ) . byThreadKey [ threadKey ] ?. activeSurfaceId ;
227260 useRightPanelStore . getState ( ) . open ( ref , "diff" ) ;
228261
229- revealServerTabs ( ref , [ tab ( "tab_a" , false ) ] , { autoShowFloatingPreview : true } ) ;
262+ revealServerTabs ( ref , [ tab ( "tab_a" , false ) ] , {
263+ autoShowFloatingPreview : true ,
264+ sheetLayout : false ,
265+ } ) ;
230266 expect ( useRightPanelStore . getState ( ) . byThreadKey [ threadKey ] ?. activeSurfaceId ) . not . toBe (
231267 browserSurfaceId ,
232268 ) ;
233- revealServerTabs ( ref , [ tab ( "tab_a" , true ) ] , { autoShowFloatingPreview : true } ) ;
269+ revealServerTabs ( ref , [ tab ( "tab_a" , true ) ] , {
270+ autoShowFloatingPreview : true ,
271+ sheetLayout : false ,
272+ } ) ;
234273 expect ( useRightPanelStore . getState ( ) . byThreadKey [ threadKey ] ?. activeSurfaceId ) . toBe (
235274 browserSurfaceId ,
236275 ) ;
@@ -296,7 +335,14 @@ describe("startAgentOpenedPreviews", () => {
296335 } ) ;
297336 const following = ( ) => {
298337 setup ( ) ;
299- return { [ Symbol . dispose ] : startAgentOpenedPreviews ( ) } ;
338+ vi . stubGlobal ( "window" , { matchMedia : ( ) => ( { matches : false } ) } ) ;
339+ const stop = startAgentOpenedPreviews ( ) ;
340+ return {
341+ [ Symbol . dispose ] : ( ) => {
342+ stop ( ) ;
343+ vi . unstubAllGlobals ( ) ;
344+ } ,
345+ } ;
300346 } ;
301347 const navigated = ( revision : number , snapshot : PreviewSessionSnapshot ) =>
302348 applyPreviewServerEvent ( ref , {
0 commit comments