@@ -6,7 +6,12 @@ import { expect, it, vi } from "vite-plus/test";
66
77const state = vi . hoisted ( ( ) => ( {
88 settings : { } as typeof DEFAULT_SERVER_SETTINGS ,
9+ targets : [ ] as {
10+ environmentId : string ;
11+ settings : typeof DEFAULT_SERVER_SETTINGS ;
12+ } [ ] ,
913 run : vi . fn ( ) ,
14+ update : vi . fn ( ) ,
1015 report : null as StorageCleanupReport | null ,
1116} ) ) ;
1217
@@ -34,11 +39,11 @@ vi.mock(import("../../state/use-atom-command"), async (original) => ({
3439vi . mock ( import ( "./SettingsScopeContext" ) , async ( original ) => ( {
3540 ...( await original ( ) ) ,
3641 useSettingsScope : ( ( ) => {
37- const environment = {
38- environmentId : "env" ,
39- label : "Build workstation" ,
42+ const environments = state . targets . map ( ( { environmentId , settings } ) => ( {
43+ environmentId,
44+ label : environmentId ,
4045 serverConfig : {
41- settings : state . settings ,
46+ settings,
4247 environment : {
4348 capabilities : {
4449 storageCleanup : true ,
@@ -47,30 +52,34 @@ vi.mock(import("./SettingsScopeContext"), async (original) => ({
4752 } ,
4853 } ,
4954 } ,
50- } ;
55+ } ) ) ;
5156 return {
52- scope : { kind : "environment" } ,
53- environments : [ environment ] ,
54- connectedEnvironments : [ environment ] ,
55- targets : [ ] ,
56- target : null ,
57+ scope : { kind : "all" } ,
58+ environments,
59+ connectedEnvironments : environments ,
60+ targets : state . targets . map ( ( { environmentId, settings } ) => ( {
61+ environmentId,
62+ settings,
63+ } ) ) ,
64+ target : state . targets [ 0 ] ? { settings : state . targets [ 0 ] . settings } : null ,
5765 } ;
5866 } ) as never ,
5967} ) ) ;
6068vi . mock ( import ( "./useScopedSettings" ) , async ( original ) => ( {
6169 ...( await original ( ) ) ,
6270 useScopedSettings : ( ( ) => state . settings ) as never ,
6371 useScopedSettingsMixed : ( ) => false ,
64- useUpdateScopedSettings : ( ) => vi . fn ( ) ,
72+ useUpdateScopedSettings : ( ) => state . update ,
6573 useClearScopedSettings : ( ) => vi . fn ( ) ,
6674} ) ) ;
6775vi . mock ( import ( "./settingsLayout" ) , async ( original ) => ( {
6876 ...( await original ( ) ) ,
6977 SettingsPageContainer : ( ( { children } : { children : ReactNode } ) => children ) as never ,
70- SettingsRow : ( { title, description, control, children } ) => (
78+ SettingsRow : ( { title, description, status , control, children } ) => (
7179 < div >
7280 < h3 > { title } </ h3 >
7381 { description }
82+ { status }
7483 { control }
7584 { children }
7685 </ div >
@@ -101,6 +110,17 @@ function setup() {
101110 } ;
102111 state . report = null ;
103112 state . run . mockReset ( ) ;
113+ state . targets = [
114+ { environmentId : "machine-a" , settings : state . settings } ,
115+ {
116+ environmentId : "machine-b" ,
117+ settings : {
118+ ...state . settings ,
119+ storageCleanup : { ...state . settings . storageCleanup } ,
120+ } ,
121+ } ,
122+ ] ;
123+ state . update . mockReset ( ) ;
104124}
105125
106126const panel = ( ) => (
@@ -122,3 +142,151 @@ it("keeps cleanup disabled when settled retention and all other rules are off",
122142 await act ( async ( ) => button . click ( ) ) ;
123143 expect ( state . run ) . not . toHaveBeenCalled ( ) ;
124144} ) ;
145+
146+ function setArtifactRetention ( machineIndex : number , value : number | null ) {
147+ const target = state . targets [ machineIndex ] ! ;
148+ target . settings = {
149+ ...target . settings ,
150+ storageCleanup : { ...target . settings . storageCleanup , browserArtifactsAfterDays : value } ,
151+ } ;
152+ if ( machineIndex === 0 ) state . settings = target . settings ;
153+ }
154+
155+ function retentionSwitch ( container : HTMLElement ) {
156+ return Array . from ( container . querySelectorAll < HTMLButtonElement > ( '[role="switch"]' ) ) . find (
157+ ( control ) => control . getAttribute ( "aria-label" ) === "Delete old browser artifacts" ,
158+ ) ! ;
159+ }
160+
161+ function artifactStatus ( container : HTMLElement ) {
162+ const title = Array . from ( container . querySelectorAll ( "h3" ) ) . find (
163+ ( heading ) => heading . textContent === "Delete old browser artifacts" ,
164+ ) ;
165+ return title ?. parentElement ?. querySelector ( "span[aria-hidden]" ) as HTMLSpanElement ;
166+ }
167+
168+ function logsStatus ( container : HTMLElement ) {
169+ const title = Array . from ( container . querySelectorAll ( "h3" ) ) . find (
170+ ( heading ) => heading . textContent === "Delete old rotated logs" ,
171+ ) ;
172+ return title ?. parentElement ?. querySelector ( "span[aria-hidden]" ) as HTMLSpanElement ;
173+ }
174+
175+ it ( "keeps a uniform retention rule free of a transient mixed warning while machines save" , async ( ) => {
176+ setup ( ) ;
177+ setArtifactRetention ( 0 , 9 ) ;
178+ setArtifactRetention ( 1 , 9 ) ;
179+ let onSettled : ( ( ) => void ) | undefined ;
180+ state . update . mockImplementation ( ( _patch , options ) => {
181+ onSettled = options ?. onSettled ;
182+ } ) ;
183+
184+ await using screen = await render ( panel ( ) ) ;
185+ expect ( artifactStatus ( screen . container ) . getAttribute ( "aria-hidden" ) ) . toBe ( "true" ) ;
186+
187+ await act ( async ( ) =>
188+ screen . container
189+ . querySelector < HTMLButtonElement > ( '[aria-label="Increase Delete old browser artifacts"]' ) !
190+ . click ( ) ,
191+ ) ;
192+ setArtifactRetention ( 0 , 10 ) ;
193+ const machineB = state . targets [ 1 ] ! ;
194+ machineB . settings = {
195+ ...machineB . settings ,
196+ storageCleanup : { ...machineB . settings . storageCleanup , logsAfterDays : 30 } ,
197+ } ;
198+ await screen . rerender ( panel ( ) ) ;
199+
200+ expect ( artifactStatus ( screen . container ) . getAttribute ( "aria-hidden" ) ) . toBe ( "true" ) ;
201+ expect ( logsStatus ( screen . container ) . getAttribute ( "aria-hidden" ) ) . toBe ( "false" ) ;
202+
203+ setArtifactRetention ( 1 , 10 ) ;
204+ await act ( async ( ) => onSettled ?.( ) ) ;
205+ await screen . rerender ( panel ( ) ) ;
206+
207+ expect ( artifactStatus ( screen . container ) . getAttribute ( "aria-hidden" ) ) . toBe ( "true" ) ;
208+ expect ( logsStatus ( screen . container ) . getAttribute ( "aria-hidden" ) ) . toBe ( "false" ) ;
209+ } ) ;
210+
211+ it . each ( [ 14 , 30 ] ) (
212+ "shows genuine differences after a partial save with a second value of %i" ,
213+ async ( secondValue ) => {
214+ setup ( ) ;
215+ setArtifactRetention ( 0 , 14 ) ;
216+ setArtifactRetention ( 1 , secondValue ) ;
217+ let onSettled : ( ( ) => void ) | undefined ;
218+ state . update . mockImplementation ( ( _patch , options ) => {
219+ onSettled = options ?. onSettled ;
220+ } ) ;
221+
222+ await using screen = await render ( panel ( ) ) ;
223+ expect ( artifactStatus ( screen . container ) . getAttribute ( "aria-hidden" ) ) . toBe (
224+ String ( secondValue === 14 ) ,
225+ ) ;
226+
227+ await act ( async ( ) => retentionSwitch ( screen . container ) . click ( ) ) ;
228+ setArtifactRetention ( 0 , null ) ;
229+ await screen . rerender ( panel ( ) ) ;
230+ expect ( artifactStatus ( screen . container ) . getAttribute ( "aria-hidden" ) ) . toBe (
231+ String ( secondValue === 14 ) ,
232+ ) ;
233+
234+ await act ( async ( ) => onSettled ?.( ) ) ;
235+ await screen . rerender ( panel ( ) ) ;
236+ expect ( artifactStatus ( screen . container ) . getAttribute ( "aria-hidden" ) ) . toBe ( "false" ) ;
237+ } ,
238+ ) ;
239+
240+ it ( "keeps the starting status until overlapping saves for the selected machines settle" , async ( ) => {
241+ setup ( ) ;
242+ const onSettled : ( ( ) => void ) [ ] = [ ] ;
243+ state . update . mockImplementation ( ( _patch , options ) => {
244+ if ( options ?. onSettled ) onSettled . push ( options . onSettled ) ;
245+ } ) ;
246+
247+ await using screen = await render ( panel ( ) ) ;
248+ await act ( async ( ) => retentionSwitch ( screen . container ) . click ( ) ) ;
249+ setArtifactRetention ( 0 , 8 ) ;
250+ await screen . rerender ( panel ( ) ) ;
251+ await act ( async ( ) => retentionSwitch ( screen . container ) . click ( ) ) ;
252+ setArtifactRetention ( 0 , null ) ;
253+ setArtifactRetention ( 1 , 8 ) ;
254+ await screen . rerender ( panel ( ) ) ;
255+
256+ expect ( onSettled ) . toHaveLength ( 2 ) ;
257+ expect ( artifactStatus ( screen . container ) . getAttribute ( "aria-hidden" ) ) . toBe ( "true" ) ;
258+ await act ( async ( ) => onSettled [ 0 ] ! ( ) ) ;
259+ expect ( artifactStatus ( screen . container ) . getAttribute ( "aria-hidden" ) ) . toBe ( "true" ) ;
260+
261+ setArtifactRetention ( 1 , null ) ;
262+ await act ( async ( ) => onSettled [ 1 ] ! ( ) ) ;
263+ await screen . rerender ( panel ( ) ) ;
264+ expect ( artifactStatus ( screen . container ) . getAttribute ( "aria-hidden" ) ) . toBe ( "true" ) ;
265+ } ) ;
266+
267+ it ( "derives mixed status from a newly selected machine set during an older save" , async ( ) => {
268+ setup ( ) ;
269+ let onSettled : ( ( ) => void ) | undefined ;
270+ state . update . mockImplementation ( ( _patch , options ) => {
271+ onSettled = options ?. onSettled ;
272+ } ) ;
273+
274+ await using screen = await render ( panel ( ) ) ;
275+ await act ( async ( ) => retentionSwitch ( screen . container ) . click ( ) ) ;
276+ setArtifactRetention ( 0 , 8 ) ;
277+ state . targets [ 1 ] = {
278+ ...state . targets [ 1 ] ! ,
279+ environmentId : "machine-c" ,
280+ settings : {
281+ ...state . targets [ 1 ] ! . settings ,
282+ storageCleanup : { ...state . targets [ 1 ] ! . settings . storageCleanup } ,
283+ } ,
284+ } ;
285+ setArtifactRetention ( 1 , 30 ) ;
286+ await screen . rerender ( panel ( ) ) ;
287+
288+ expect ( artifactStatus ( screen . container ) . getAttribute ( "aria-hidden" ) ) . toBe ( "false" ) ;
289+ await act ( async ( ) => onSettled ?.( ) ) ;
290+ await screen . rerender ( panel ( ) ) ;
291+ expect ( artifactStatus ( screen . container ) . getAttribute ( "aria-hidden" ) ) . toBe ( "false" ) ;
292+ } ) ;
0 commit comments