Skip to content

Commit 766602e

Browse files
t3dotggclaude
andcommitted
fix(server): skip tool images larger than a provider turn accepts
Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
1 parent ba9bf6c commit 766602e

2 files changed

Lines changed: 34 additions & 3 deletions

File tree

‎apps/server/src/assets/AssetAccess.test.ts‎

Lines changed: 25 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -90,11 +90,30 @@ const screenshotItem = {
9090
updatedAt: DateTime.makeUnsafe("2026-10-05T00:00:01.000Z"),
9191
};
9292

93+
const oversizedScreenshotItem = {
94+
...screenshotItem,
95+
id: TurnItemId.make("tool-screenshot-oversized"),
96+
output: {
97+
content: [
98+
{
99+
type: "image",
100+
source: { type: "base64", media_type: "image/png", data: "A".repeat(14 * 1024 * 1024) },
101+
},
102+
],
103+
},
104+
};
105+
93106
const testLayer = Layer.mergeAll(
94107
NodeHttpPlatform.layer,
95108
Layer.mock(Orchestrator.OrchestratorV2)({
96109
getTurnItem: ({ itemId }) =>
97-
Effect.succeed(itemId === screenshotItem.id ? screenshotItem : null),
110+
Effect.succeed(
111+
itemId === screenshotItem.id
112+
? screenshotItem
113+
: itemId === oversizedScreenshotItem.id
114+
? oversizedScreenshotItem
115+
: null,
116+
),
98117
}),
99118
configLayer,
100119
WorkspacePaths.layer,
@@ -174,6 +193,11 @@ describe("AssetAccess", () => {
174193
Effect.flip,
175194
);
176195
expect(missing._tag).toBe("AssetWorkspaceAssetNotFoundError");
196+
// Larger than a provider turn accepts, so it is never decoded.
197+
const oversized = yield* issueAssetUrl({
198+
resource: { ...resource, itemId: oversizedScreenshotItem.id },
199+
}).pipe(Effect.flip);
200+
expect(oversized._tag).toBe("AssetWorkspaceAssetNotFoundError");
177201
}).pipe(Effect.provide(testLayer)),
178202
);
179203

‎apps/server/src/assets/AssetAccess.ts‎

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import type { AssetResource } from "@t3tools/contracts";
22
import {
33
AssetAttachmentNotFoundError,
4+
PROVIDER_SEND_TURN_MAX_IMAGE_BYTES,
45
AssetGitHubMediaUrlValidationError,
56
AssetPreviewTypeValidationError,
67
AssetProjectFaviconInspectionError,
@@ -215,7 +216,13 @@ const optionOnNotFound = <A, R>(
215216
}),
216217
);
217218

218-
/** Decodes one image a tool returned inline; null when the stored item has no such image. */
219+
// The largest image a provider turn accepts, as base64 (4 characters per 3 bytes).
220+
const MAX_TOOL_OUTPUT_IMAGE_BASE64_LENGTH = Math.ceil(PROVIDER_SEND_TURN_MAX_IMAGE_BYTES / 3) * 4;
221+
222+
/**
223+
* Decodes one image a tool returned inline; null when the stored item has no
224+
* such image, or it is larger than a provider turn accepts.
225+
*/
219226
const readToolOutputImage = Effect.fn("AssetAccess.readToolOutputImage")(function* (input: {
220227
readonly threadId: ThreadId;
221228
readonly itemId: TurnItemId;
@@ -225,7 +232,7 @@ const readToolOutputImage = Effect.fn("AssetAccess.readToolOutputImage")(functio
225232
const item = yield* orchestrator.getTurnItem(input);
226233
const image =
227234
item?.type === "dynamic_tool" ? toolOutputImages(item.output)[input.index] : undefined;
228-
return image?.data === undefined
235+
return image?.data === undefined || image.data.length > MAX_TOOL_OUTPUT_IMAGE_BASE64_LENGTH
229236
? null
230237
: { mimeType: image.mimeType, bytes: Buffer.from(image.data, "base64") };
231238
});

0 commit comments

Comments
 (0)