Skip to content

Commit 759e649

Browse files
fix(server): agent recordings keep up with the page instead of the encoder (#36215)
1 parent c398b46 commit 759e649

3 files changed

Lines changed: 63 additions & 23 deletions

File tree

‎apps/server/src/preview/ServerBrowser.test.ts‎

Lines changed: 32 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -360,12 +360,10 @@ function makeEncoderPage() {
360360
document: { createElement: (tag: string) => (tag === "video" ? video : canvas) },
361361
Path2D: function Path2D() {},
362362
MediaRecorder: FakeMediaRecorder,
363-
createImageBitmap: async (blob: Blob) => ({
364-
width: 1280,
365-
height: 800,
366-
pixels: await blob.text(),
367-
close() {},
368-
}),
363+
createImageBitmap: async (blob: Blob) => {
364+
await decodeGate?.promise;
365+
return { width: 1280, height: 800, pixels: await blob.text(), close() {} };
366+
},
369367
atob,
370368
btoa,
371369
Blob,
@@ -386,6 +384,7 @@ function makeEncoderPage() {
386384
const contexts: ReturnType<typeof makeContext>[] = [];
387385
let encoderPageOverride: Page | undefined;
388386
const encoderStreams: Array<{ frameRate: number | undefined; bitsPerSecond: number }> = [];
387+
let decodeGate: PromiseWithResolvers<void> | null = null;
389388
const contextRequests: Array<{ profileId: string; isolated: boolean }> = [];
390389
let contextGate: PromiseWithResolvers<void> | null = null;
391390
let heldStill: (() => Promise<void>) | null = null;
@@ -571,6 +570,7 @@ beforeEach(() => {
571570
contexts.length = 0;
572571
encoderPageOverride = undefined;
573572
encoderStreams.length = 0;
573+
decodeGate = null;
574574
contextRequests.length = 0;
575575
contextGate = null;
576576
heldStill = null;
@@ -1077,6 +1077,32 @@ it.effect.each([
10771077
).pipe(Effect.provide(layer)),
10781078
);
10791079

1080+
// Chrome stops sending screencast frames while too many are unacked.
1081+
it.effect("recordings ack screencast frames without waiting for the encoder to decode them", () =>
1082+
Effect.scoped(
1083+
Effect.gen(function* () {
1084+
const { broker, tabId } = yield* ready;
1085+
yield* broker.invoke({ scope, tabId, operation: "recordingStart", input: {} });
1086+
const session = contexts[0]!.sessions.find((candidate) =>
1087+
candidate.send.mock.calls.some(([method]) => method === "Page.startScreencast"),
1088+
)!;
1089+
const gate = Promise.withResolvers<void>();
1090+
decodeGate = gate;
1091+
yield* Effect.addFinalizer(() => Effect.sync(() => gate.resolve()));
1092+
for (const sessionId of [1, 2, 3]) {
1093+
session.emit("Page.screencastFrame", {
1094+
data: Buffer.from(`frame ${sessionId}`).toString("base64"),
1095+
sessionId,
1096+
metadata: { deviceWidth: 1280 },
1097+
});
1098+
}
1099+
expect(
1100+
session.send.mock.calls.filter(([method]) => method === "Page.screencastFrameAck"),
1101+
).toHaveLength(3);
1102+
}),
1103+
).pipe(Effect.provide(layer)),
1104+
);
1105+
10801106
it.effect.each([{ truncated: false }, { truncated: true }])(
10811107
"saves a large recording as a binary download and removes its staged file (truncated: $truncated)",
10821108
({ truncated }) =>

‎apps/server/src/preview/ServerBrowser.ts‎

Lines changed: 29 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -1986,24 +1986,37 @@ const make = Effect.gen(function* () {
19861986
const opened = await tab.page.context().newCDPSession(tab.page);
19871987
session = opened;
19881988
const framesInFlight = new Set<Promise<void>>();
1989+
// Chrome withholds frames while acks are outstanding, so ack on arrival and let a
1990+
// slow encoder skip to the newest frame instead of throttling the capture.
1991+
let pendingFrame: readonly [string, number] | null = null;
1992+
const deliverPending = async () => {
1993+
while (pendingFrame) {
1994+
const next = pendingFrame;
1995+
pendingFrame = null;
1996+
const accepted = await encoder
1997+
.evaluate(
1998+
([data, width]) =>
1999+
(globalThis as unknown as EncoderWindow).__t3Recorder.frame(data, width),
2000+
next,
2001+
)
2002+
.catch(() => true);
2003+
if (!accepted) {
2004+
pendingFrame = null;
2005+
await opened.send("Page.stopScreencast").catch(constVoid);
2006+
}
2007+
}
2008+
};
19892009
opened.on("Page.screencastFrame", (frame) => {
2010+
void opened
2011+
.send("Page.screencastFrameAck", { sessionId: frame.sessionId })
2012+
.catch(constVoid);
19902013
const cssWidth = tab.page.viewportSize()?.width ?? frame.metadata.deviceWidth;
1991-
const delivered: Promise<void> = encoder
1992-
.evaluate(
1993-
([data, width]) =>
1994-
(globalThis as unknown as EncoderWindow).__t3Recorder.frame(data, width),
1995-
[frame.data, cssWidth] as const,
1996-
)
1997-
.then(async (accepted) => {
1998-
if (!accepted) await opened.send("Page.stopScreencast");
1999-
})
2000-
.catch(constVoid)
2001-
.finally(() => {
2002-
framesInFlight.delete(delivered);
2003-
void opened
2004-
.send("Page.screencastFrameAck", { sessionId: frame.sessionId })
2005-
.catch(constVoid);
2006-
});
2014+
const delivering = framesInFlight.size > 0;
2015+
pendingFrame = [frame.data, cssWidth];
2016+
if (delivering) return;
2017+
const delivered: Promise<void> = deliverPending().finally(() =>
2018+
framesInFlight.delete(delivered),
2019+
);
20072020
framesInFlight.add(delivered);
20082021
});
20092022
await opened.send("Page.startScreencast", RECORDING_SCREENCAST);

‎apps/server/src/preview/ServerBrowserPage.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1103,7 +1103,8 @@ export const recordingEncoderScript = (frameRate: BrowserRecordingFrameRate) =>
11031103
window.__t3Recorder = {
11041104
async frame(base64, cssWidth) {
11051105
if (tooLarge) return false;
1106-
const bytes = Uint8Array.from(atob(base64), (char) => char.charCodeAt(0));
1106+
// A per-character atob copy costs ~30 ms on a 3200x1800 frame and throttles recordings.
1107+
const bytes = Uint8Array.fromBase64(base64);
11071108
const bitmap = await createImageBitmap(new Blob([bytes], { type: "image/jpeg" }));
11081109
if (tooLarge) { bitmap.close(); return false; }
11091110
if (!recorder) {

0 commit comments

Comments
 (0)