Skip to content

Commit 746c80f

Browse files
committed
fix(server): skip current only after a fresh enriched probe
The skip test now starts from a stale behind_latest snapshot and requires refreshInstance to rewrite the live version. Skip also requires this-run enrichment so a cached current advisory cannot hide a failed latest lookup.
1 parent 1aa6c92 commit 746c80f

2 files changed

Lines changed: 69 additions & 3 deletions

File tree

‎apps/server/src/provider/providerMaintenanceRunner.test.ts‎

Lines changed: 59 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -296,13 +296,31 @@ describe("providerMaintenanceRunner", () => {
296296

297297
it.effect("skips the installer when a fresh probe already matches latest", () => {
298298
const calls: Array<{ command: string; args: ReadonlyArray<string> }> = [];
299+
const refreshedInstanceIds: Array<ProviderInstanceId> = [];
299300
return Effect.gen(function* () {
300-
const { registry, updateStatesRef } = yield* makeRegistry({
301+
const { registry, updateStatesRef, providersRef } = yield* makeRegistry({
301302
...baseProvider,
302-
version: "2.1.310",
303+
version: "2.1.309",
304+
versionAdvisory: {
305+
status: "behind_latest",
306+
currentVersion: "2.1.309",
307+
latestVersion: "2.1.310",
308+
updateCommand: "claude update",
309+
canUpdate: true,
310+
checkedAt: "2026-04-10T00:00:00.000Z",
311+
message: "Update available.",
312+
},
303313
});
304314
const updater = yield* makeTestRunner({
305315
...registry,
316+
refreshInstance: (instanceId) => {
317+
refreshedInstanceIds.push(instanceId);
318+
return Ref.updateAndGet(providersRef, (providers) =>
319+
providers.map((provider) =>
320+
provider.instanceId === instanceId ? { ...provider, version: "2.1.310" } : provider,
321+
),
322+
);
323+
},
306324
getProviderMaintenanceCapabilitiesForInstance: () =>
307325
Effect.succeed(
308326
makeProviderMaintenanceCapabilities({
@@ -316,6 +334,7 @@ describe("providerMaintenanceRunner", () => {
316334
});
317335

318336
const result = yield* updater.updateProvider(CODEX_DRIVER);
337+
assert.deepStrictEqual(refreshedInstanceIds, [CODEX_INSTANCE_ID]);
319338
assert.deepStrictEqual(calls, []);
320339
assert.strictEqual(result.providers[0]?.updateState?.status, "succeeded");
321340
assert.strictEqual(result.providers[0]?.updateState?.message, "Already up to date.");
@@ -341,6 +360,44 @@ describe("providerMaintenanceRunner", () => {
341360
);
342361
});
343362

363+
it.effect("still runs the installer when the installed version is unknown", () => {
364+
const calls: Array<{ command: string; args: ReadonlyArray<string> }> = [];
365+
return Effect.gen(function* () {
366+
const { registry } = yield* makeRegistry({
367+
...baseProvider,
368+
version: null,
369+
});
370+
const updater = yield* makeTestRunner({
371+
...registry,
372+
getProviderMaintenanceCapabilitiesForInstance: () =>
373+
Effect.succeed(
374+
makeProviderMaintenanceCapabilities({
375+
provider: CODEX_DRIVER,
376+
packageName: "@anthropic-ai/claude-code",
377+
updateExecutable: "claude",
378+
updateArgs: ["update"],
379+
updateLockKey: "claudeAgent-native",
380+
}),
381+
),
382+
});
383+
384+
const result = yield* updater.updateProvider(CODEX_DRIVER);
385+
assert.deepStrictEqual(calls, [{ command: "claude", args: ["update"] }]);
386+
assert.strictEqual(result.providers[0]?.updateState?.status, "succeeded");
387+
}).pipe(
388+
Effect.provide(
389+
Layer.mergeAll(
390+
layerNonWindowsPlatform,
391+
layerLatestVersionHttpClient("2.1.310"),
392+
layerMockSpawner((command, args) => {
393+
calls.push({ command, args });
394+
return { stdout: "updated" };
395+
}),
396+
),
397+
),
398+
);
399+
});
400+
344401
it.effect("still runs the installer when the fresh probe is behind latest", () => {
345402
const calls: Array<{ command: string; args: ReadonlyArray<string> }> = [];
346403
return Effect.gen(function* () {

‎apps/server/src/provider/providerMaintenanceRunner.ts‎

Lines changed: 10 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -83,6 +83,7 @@ class ProviderMaintenanceCommandError extends Data.TaggedError("ProviderMaintena
8383
interface VerifiedProviderRefresh {
8484
readonly providers: ReadonlyArray<ServerProvider>;
8585
readonly verifiedProviders: ReadonlyArray<ServerProvider>;
86+
readonly advisoryEnriched: boolean;
8687
}
8788

8889
const nowIso = Effect.map(DateTime.now, DateTime.formatIso);
@@ -328,6 +329,7 @@ export const make = Effect.fn("ProviderMaintenanceRunner.make")(function* () {
328329
provider: ProviderDriverKind,
329330
maintenanceCapabilities: ProviderMaintenanceCapabilities,
330331
instanceId: ProviderInstanceId,
332+
phase: "pre-update" | "post-update",
331333
): Effect.Effect<VerifiedProviderRefresh> =>
332334
refresh.pipe(
333335
Effect.flatMap((providers) => {
@@ -338,6 +340,7 @@ export const make = Effect.fn("ProviderMaintenanceRunner.make")(function* () {
338340
return Effect.succeed<VerifiedProviderRefresh>({
339341
providers,
340342
verifiedProviders: [],
343+
advisoryEnriched: true,
341344
});
342345
}
343346
return Effect.forEach(
@@ -357,15 +360,18 @@ export const make = Effect.fn("ProviderMaintenanceRunner.make")(function* () {
357360
Effect.map((verifiedProviders): VerifiedProviderRefresh => ({
358361
providers,
359362
verifiedProviders,
363+
advisoryEnriched: true,
360364
})),
361365
Effect.catchCause((cause) =>
362-
Effect.logWarning("Provider post-update version verification failed", {
366+
Effect.logWarning("Provider version verification failed", {
363367
provider,
368+
phase,
364369
cause: Cause.pretty(cause),
365370
}).pipe(
366371
Effect.as<VerifiedProviderRefresh>({
367372
providers,
368373
verifiedProviders: refreshedProviders,
374+
advisoryEnriched: false,
369375
}),
370376
),
371377
),
@@ -383,6 +389,7 @@ export const make = Effect.fn("ProviderMaintenanceRunner.make")(function* () {
383389
provider,
384390
maintenanceCapabilities,
385391
instanceId,
392+
"post-update",
386393
);
387394

388395
const updateProvider: ProviderMaintenanceRunnerShape["updateProvider"] = Effect.fn(
@@ -512,8 +519,10 @@ export const make = Effect.fn("ProviderMaintenanceRunner.make")(function* () {
512519
provider,
513520
fresh,
514521
instanceId,
522+
"pre-update",
515523
);
516524
const alreadyCurrent =
525+
precheck.advisoryEnriched &&
517526
precheck.verifiedProviders.length > 0 &&
518527
precheck.verifiedProviders.every(isAlreadyOnLatest);
519528
if (alreadyCurrent) {

0 commit comments

Comments
 (0)