Repository navigation
Commit 742c1ef
fix(web): honor autoOpenPreview when running a project action
The "Open preview automatically when this action runs" toggle has had no
effect since #2978: that rewrite moved runProjectScript onto the atom
command API and dropped the block that opened the preview panel after the
command was written to the terminal. #3842 later restored persistence of
previewUrl/autoOpenPreview, so the setting saves and reloads correctly —
it simply is not read at run time by anything.
Restore the auto-open through the existing openUrlInPreview helper, which
already does what the deleted code did by hand (open the session, apply
the snapshot, remember the URL, reveal the tab in the right panel).
A failed terminal write now returns instead of falling through, so a
script that never started cannot open a preview. Preview failures stay
silent for the caller: they are surfaced by the panel itself, and the
script is already running, so they are not the script's failure.
Fixes #5221
Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>1 parent 64bf016 commit 742c1ef
1 file changed
Lines changed: 26 additions & 6 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
134 | 134 | | |
135 | 135 | | |
136 | 136 | | |
| 137 | + | |
137 | 138 | | |
138 | 139 | | |
139 | 140 | | |
| |||
2880 | 2881 | | |
2881 | 2882 | | |
2882 | 2883 | | |
2883 | | - | |
2884 | | - | |
2885 | | - | |
2886 | | - | |
2887 | | - | |
2888 | | - | |
| 2884 | + | |
| 2885 | + | |
| 2886 | + | |
| 2887 | + | |
| 2888 | + | |
| 2889 | + | |
| 2890 | + | |
| 2891 | + | |
| 2892 | + | |
| 2893 | + | |
| 2894 | + | |
| 2895 | + | |
| 2896 | + | |
| 2897 | + | |
| 2898 | + | |
| 2899 | + | |
| 2900 | + | |
| 2901 | + | |
| 2902 | + | |
| 2903 | + | |
| 2904 | + | |
| 2905 | + | |
| 2906 | + | |
| 2907 | + | |
2889 | 2908 | | |
2890 | 2909 | | |
2891 | 2910 | | |
| |||
2894 | 2913 | | |
2895 | 2914 | | |
2896 | 2915 | | |
| 2916 | + | |
2897 | 2917 | | |
2898 | 2918 | | |
2899 | 2919 | | |
| |||
0 commit comments