Skip to content

Commit 721d4a2

Browse files
committed
test(web): prove the project settings grant recheck runs on revocation
1 parent da2bb89 commit 721d4a2

1 file changed

Lines changed: 33 additions & 5 deletions

File tree

‎apps/web/src/components/settings/ProjectSettingsPanel.browser.test.tsx‎

Lines changed: 33 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -51,6 +51,7 @@ const state = vi.hoisted(() => ({
5151
confirm: vi.fn<() => Promise<boolean>>(),
5252
releaseUploads: vi.fn(),
5353
clearDraft: vi.fn(),
54+
toast: vi.fn(),
5455
}));
5556

5657
// Session grants come from the server; each test drives them through these atoms.
@@ -105,6 +106,11 @@ vi.mock(import("~/lib/composerDraftUploads"), async (original) => ({
105106
...(await original()),
106107
releaseProjectDraftUploads: state.releaseUploads,
107108
}));
109+
// No toaster is mounted in these tests; the guard's error toast is read at this seam.
110+
vi.mock(import("../ui/toast"), async (original) => {
111+
const actual = await original();
112+
return { ...actual, toastManager: { ...actual.toastManager, add: state.toast } };
113+
});
108114
// These sections have separate data sources and their own tests.
109115
vi.mock(import("./ProjectDefaultsSettings"), async (original) => ({
110116
...(await original()),
@@ -241,9 +247,9 @@ async function mountPanel(search: Omit<SettingsScopeSearch, "project"> = {}) {
241247
history: createMemoryHistory({ initialEntries: [`/settings/projects?${query}`] }),
242248
});
243249
await router.load();
244-
// The panel's own route tree validates settings search params, which the default router lacks.
245250
await using stack = new AsyncDisposableStack();
246251
const screen = stack.use(
252+
// The panel's own route tree validates settings search params, which the default router lacks.
247253
await render(
248254
<RegistryContext.Provider value={appAtomRegistry}>
249255
<RouterProvider router={router} />
@@ -306,6 +312,20 @@ async function rename(screen: Screen, title: string) {
306312
await userEvent.keyboard("{Enter}");
307313
}
308314

315+
// The recheck reports the denial by toast; seeing it proves the recheck ran.
316+
async function expectProjectAccessDeniedToast(title: string) {
317+
await vi.waitFor(() =>
318+
expect(state.toast).toHaveBeenCalledWith(
319+
expect.objectContaining({
320+
type: "error",
321+
title,
322+
description: "This connection cannot change projects in remote.",
323+
}),
324+
),
325+
);
326+
expect(state.toast).toHaveBeenCalledOnce();
327+
}
328+
309329
describe("project settings permissions", () => {
310330
it("disables shared edits when any member lacks project access", async () => {
311331
setup();
@@ -328,7 +348,7 @@ describe("project settings permissions", () => {
328348
primaryId,
329349
remoteId,
330350
]);
331-
expect(state.projects.map((project) => project.title)).toEqual(["Renamed", "Renamed"]);
351+
expect(nameInput(screen).value).toBe("Renamed");
332352
});
333353

334354
it("stops before the next member if its grant is revoked during an earlier update", async () => {
@@ -344,6 +364,7 @@ describe("project settings permissions", () => {
344364
firstUpdate.resolve(AsyncResult.success(undefined));
345365
await firstUpdate.promise;
346366
});
367+
await expectProjectAccessDeniedToast("Failed to rename project");
347368
expect(state.update).toHaveBeenCalledOnce();
348369
expect(state.update.mock.calls[0]![0].environmentId).toBe(primaryId);
349370
});
@@ -387,6 +408,7 @@ describe("project settings permissions", () => {
387408
confirmed.resolve(true);
388409
await confirmed.promise;
389410
});
411+
await expectProjectAccessDeniedToast("Failed to remove project");
390412
expect(state.delete).not.toHaveBeenCalled();
391413
expect(state.releaseUploads).not.toHaveBeenCalled();
392414
expect(state.clearDraft).not.toHaveBeenCalled();
@@ -397,14 +419,20 @@ describe("project settings permissions", () => {
397419
await using screen = await mountPanel();
398420
await userEvent.fill(nameInput(screen), "Renamed");
399421
await grant(remoteId, AsyncResult.success(session([])));
400-
await act(async () => nameInput(screen).blur());
422+
// Chromium takes focus off a newly disabled input without firing blur. Send the
423+
// focusout so the save attempt runs and hits the same recheck as a real blur.
424+
await act(async () => {
425+
nameInput(screen).dispatchEvent(new FocusEvent("focusout", { bubbles: true }));
426+
});
427+
await expectProjectAccessDeniedToast("Failed to rename project");
401428
expect(state.update).not.toHaveBeenCalled();
402429
expect(nameInput(screen).disabled).toBe(true);
403430

404431
await grant(remoteId, writable());
405432
expect(nameInput(screen).disabled).toBe(false);
406-
await rename(screen, "Renamed");
407-
expect(state.projects.map((project) => project.title)).toEqual(["Renamed", "Renamed"]);
433+
await rename(screen, "Recovered");
434+
await vi.waitFor(() => expect(state.update).toHaveBeenCalledTimes(2));
435+
expect(nameInput(screen).value).toBe("Recovered");
408436
});
409437

410438
it.each([

0 commit comments

Comments
 (0)