Skip to content

Commit 721787d

Browse files
t3dotggclaude
andcommitted
fix(server): hide Muse's per-step reminder child from the timeline
Muse runs a skill-reminder child session on every model step. It showed as a spinning "Reminder" tool row that covered each step's think time. Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 50c59d3 commit 721787d

4 files changed

Lines changed: 17 additions & 12 deletions

File tree

‎apps/server/src/orchestration-v2/Adapters/MuseAdapterV2.test.ts‎

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1550,7 +1550,8 @@ describe("MuseAdapterV2", () => {
15501550
const fake = yield* makeFakeMuse();
15511551
const harness = yield* makeHarness(fake);
15521552
const { nativeId } = yield* startConversation(harness, fake);
1553-
// The tool call that wrote the list must not also show as a generic tool row.
1553+
// Neither the tool call that wrote the list nor Muse's per-step reminder
1554+
// child may show as a generic tool row.
15541555
yield* fake.emit("item/completed", {
15551556
turnId: nativeId,
15561557
item: {
@@ -1562,6 +1563,17 @@ describe("MuseAdapterV2", () => {
15621563
status: "completed",
15631564
},
15641565
});
1566+
yield* fake.emit("item/started", {
1567+
turnId: nativeId,
1568+
item: {
1569+
itemId: "reminder",
1570+
turnId: nativeId,
1571+
kind: "reminderChild",
1572+
revision: 1,
1573+
status: "inProgress",
1574+
fallbackText: "Reminder child session",
1575+
},
1576+
});
15651577
yield* fake.emit("session/todoListChanged", {
15661578
items: [
15671579
{ text: " Investigate ", status: "completed" },

‎apps/server/src/orchestration-v2/Adapters/MuseAdapterV2.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -424,7 +424,8 @@ export function makeMuseAdapterV2(options: MuseAdapterV2Options): ProviderAdapte
424424
item: MuseItem,
425425
terminal?: OrchestrationV2TurnItem["status"],
426426
) {
427-
if (item.kind === "userMessage") return;
427+
// Muse's skill-reminder child runs on every model step; it is housekeeping, not work.
428+
if (item.kind === "userMessage" || item.kind === "reminderChild") return;
428429
if (item.kind === "toolCall" && item.tool && TOOLS_WITH_NATIVE_ROWS.has(item.tool)) return;
429430
const time = yield* DateTime.now;
430431
const status = terminal ?? museItemStatus(item);

‎apps/server/src/orchestration-v2/Adapters/MuseItemPresentation.test.ts‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -111,10 +111,7 @@ describe("Muse item presentation", () => {
111111
},
112112
);
113113

114-
it("keeps reminder and native child summaries as neutral activity", () => {
115-
expect(
116-
museToolPresentation(item({ kind: "reminderChild", fallbackText: "Reminder child session" })),
117-
).toMatchObject({ type: "dynamic_tool", title: "Reminder", output: "Reminder child session" });
114+
it("keeps native child summaries as neutral activity", () => {
118115
expect(
119116
museToolPresentation(
120117
item({ kind: "subagent", objective: "Review patch", result: { summary: "No issues" } }),

‎apps/server/src/orchestration-v2/Adapters/MuseItemPresentation.ts‎

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -54,12 +54,7 @@ export function museToolPresentation(
5454
return undefined;
5555
};
5656
const toolName = item.tool ?? item.kind;
57-
const title =
58-
item.kind === "reminderChild"
59-
? "Reminder"
60-
: item.kind === "subagent"
61-
? item.objective || item.role || "Muse agent"
62-
: toolName;
57+
const title = item.kind === "subagent" ? item.objective || item.role || "Muse agent" : toolName;
6358
const detail =
6459
status === "failed" ? item.failureReason || `Muse reported ${item.status}.` : undefined;
6560
const shared = { status, title: detail ? `${title}: ${detail}` : title };

0 commit comments

Comments
 (0)