Skip to content

Commit 71e4bbc

Browse files
fix(server): repair stored boolean settledOverride so startup recovery can read threads
Thread projection rows with "settledOverride": true or false failed the thread schema during provider runtime recovery, aborting startup. Raw-JSON readers also disagreed on what the boolean meant. Migration 077 rewrites true to "settled" and false to null, leaving every other row untouched. Fixes #28279 Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 938b709 commit 71e4bbc

3 files changed

Lines changed: 18 additions & 0 deletions

File tree

‎apps/server/src/persistence/Migrations.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -79,6 +79,7 @@ import Migration0073 from "./Migrations/073_ActiveTurnItemIndexes.ts";
7979
import Migration0074 from "./Migrations/074_ExcludeAttachmentPlaceholdersFromSearch.ts";
8080
import Migration0075 from "./Migrations/075_SubagentDeliveryState.ts";
8181
import Migration0076 from "./Migrations/076_ProjectionProjectsPinArchive.ts";
82+
import Migration0077 from "./Migrations/077_RepairBooleanSettledOverride.ts";
8283

8384
const migrationEntries = [
8485
[1, "OrchestrationEvents", Migration0001],
@@ -158,6 +159,7 @@ const migrationEntries = [
158159
[74, "ExcludeAttachmentPlaceholdersFromSearch", Migration0074],
159160
[75, "SubagentDeliveryState", Migration0075],
160161
[76, "ProjectionProjectsPinArchive", Migration0076],
162+
[77, "RepairBooleanSettledOverride", Migration0077],
161163
] as const;
162164

163165
export const migrationManifest = migrationEntries.map(([id, name]) => [id, name] as const);
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
import * as Effect from "effect/Effect";
2+
import * as SqlClient from "effect/sql/SqlClient";
3+
4+
// Thread projections may hold a boolean settledOverride, which the thread schema rejects.
5+
export default Effect.gen(function* () {
6+
const sql = yield* SqlClient.SqlClient;
7+
yield* sql`
8+
UPDATE orchestration_v2_projection_threads
9+
SET payload_json = json_set(payload_json, '$.settledOverride',
10+
IIF(json_type(payload_json, '$.settledOverride') = 'true', 'settled', NULL))
11+
WHERE json_valid(payload_json)
12+
AND json_type(payload_json, '$.settledOverride') IN ('true', 'false')
13+
`;
14+
});

‎apps/server/src/persistence/reconcileV2PreviewMigration.test.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ describe("V2 preview upgrade", () => {
5656
[74, "ExcludeAttachmentPlaceholdersFromSearch"],
5757
[75, "SubagentDeliveryState"],
5858
[76, "ProjectionProjectsPinArchive"],
59+
[77, "RepairBooleanSettledOverride"],
5960
]);
6061
assert.deepStrictEqual(yield* runMigrations(), []);
6162
assert.deepStrictEqual(yield* sql`SELECT * FROM orchestration_v2_legacy_imports`, imports);
@@ -155,6 +156,7 @@ describe("V2 preview upgrade", () => {
155156
[74, "ExcludeAttachmentPlaceholdersFromSearch"],
156157
[75, "SubagentDeliveryState"],
157158
[76, "ProjectionProjectsPinArchive"],
159+
[77, "RepairBooleanSettledOverride"],
158160
]);
159161
}).pipe(Effect.provide(NodeSqliteClient.layer({ filename: ":memory:" }))),
160162
);

0 commit comments

Comments
 (0)