Skip to content

Commit 7122c5a

Browse files
committed
fix(desktop): include long numbers in preview payload budget
1 parent d8993f0 commit 7122c5a

2 files changed

Lines changed: 22 additions & 21 deletions

File tree

‎apps/desktop/src/preview/CdpRelay.test.ts‎

Lines changed: 21 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -237,26 +237,27 @@ describe("CDP relay payload budget", () => {
237237
]);
238238
});
239239

240-
it.each([oversized, "\u0001".repeat(12 * 1024 * 1024)])(
241-
"closes instead of dropping an oversized event (%#)",
242-
async (args) => {
243-
const written: Array<Record<string, unknown>> = [];
244-
const close = vi.fn();
245-
const relay = createCdpRelayConnection(
246-
makeTarget(vi.fn()),
247-
(raw) => written.push(JSON.parse(raw)),
248-
close,
249-
);
250-
relay.receive(JSON.stringify({ id: 1, method: "Target.setAutoAttach", params: {} }));
251-
await settle();
252-
written.length = 0;
240+
it.each([
241+
{ args: oversized },
242+
{ args: "\u0001".repeat(12 * 1024 * 1024) },
243+
{ args: Array(2_700_000).fill(-0.0000010000000000000002) },
244+
])("closes instead of dropping an oversized event (%#)", async ({ args }) => {
245+
const written: Array<Record<string, unknown>> = [];
246+
const close = vi.fn();
247+
const relay = createCdpRelayConnection(
248+
makeTarget(vi.fn()),
249+
(raw) => written.push(JSON.parse(raw)),
250+
close,
251+
);
252+
relay.receive(JSON.stringify({ id: 1, method: "Target.setAutoAttach", params: {} }));
253+
await settle();
254+
written.length = 0;
253255

254-
relay.event("Runtime.consoleAPICalled", { args }, "");
255-
relay.event("Page.loadEventFired", { timestamp: 1 }, "");
256+
relay.event("Runtime.consoleAPICalled", { args }, "");
257+
relay.event("Page.loadEventFired", { timestamp: 1 }, "");
256258

257-
relay.receive(JSON.stringify({ id: 2, method: "Target.setAutoAttach" }));
258-
expect(close).toHaveBeenCalledOnce();
259-
expect(written.map((message) => message["method"])).toEqual([]);
260-
},
261-
);
259+
relay.receive(JSON.stringify({ id: 2, method: "Target.setAutoAttach" }));
260+
expect(close).toHaveBeenCalledOnce();
261+
expect(written.map((message) => message["method"])).toEqual([]);
262+
});
262263
});

‎apps/desktop/src/preview/CdpRelay.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ const serializedSize = (text: string) =>
4747
const fitsPayloadBudget = (message: unknown) => {
4848
let remaining = MAX_CDP_PAYLOAD_SIZE;
4949
const visit = (value: unknown): boolean => {
50-
remaining -= typeof value === "string" ? serializedSize(value) : 24;
50+
remaining -= typeof value === "string" ? serializedSize(value) : 26;
5151
if (remaining < 0) return false;
5252
if (typeof value !== "object" || value === null) return true;
5353
if (Array.isArray(value)) return value.every(visit);

0 commit comments

Comments
 (0)