@@ -112,7 +112,7 @@ it.effect.each(["merge", "disable-auto-merge"] as const)(
112112 yield * provider . searchRepositoryAuthors ( reference ) ;
113113 yield * provider . runAction ( { ...reference , action } ) ;
114114
115- expect ( readHosts ) . toEqual ( Array ( action === "merge" ? 11 : 10 ) . fill ( selectedHost ) ) ;
115+ expect ( readHosts ) . toEqual ( Array ( action === "merge" ? 12 : 11 ) . fill ( selectedHost ) ) ;
116116 expect ( { url : detail . url , mutatedHosts : mergedHosts } ) . toEqual ( {
117117 url : `https://${ selectedHost } /acme/web/-/merge_requests/7` ,
118118 mutatedHosts : [ selectedHost ] ,
@@ -187,6 +187,8 @@ describe("getChangeRequest base freshness", () => {
187187 Effect . provide (
188188 Layer . mock ( GitLabPullRequestCli . GitLabPullRequestCli ) ( {
189189 getMergeRequestDetail : ( ) => Effect . succeed ( detail ) ,
190+ getReviewDecisions : ( ) => Effect . succeed ( new Map ( ) ) ,
191+
190192 listMergeRequestStats : ( ) => Effect . succeed ( [ ] ) ,
191193 } ) ,
192194 ) ,
@@ -286,6 +288,7 @@ describe("getChangeRequest base freshness", () => {
286288 Layer . mock ( GitLabPullRequestCli . GitLabPullRequestCli ) ( {
287289 getMergeRequestDetail : ( ) => Effect . succeed ( detail ) ,
288290 getProjectMergeCapabilities : ( ) => Effect . die ( "linked threads skip merge settings" ) ,
291+ getReviewDecisions : ( ) => Effect . succeed ( new Map ( ) ) ,
289292 listMergeRequestStats : ( ) =>
290293 Effect . succeed ( [ { repository : "acme/web" , number : 7 , additions : 40 , deletions : 2 } ] ) ,
291294 } ) ,
@@ -333,6 +336,7 @@ describe("merge request reads", () => {
333336 Effect . provide (
334337 Layer . mock ( GitLabPullRequestCli . GitLabPullRequestCli ) ( {
335338 listMergeRequestStats : ( ) => Effect . succeed ( [ ] ) ,
339+ getReviewDecisions : ( ) => Effect . succeed ( new Map ( ) ) ,
336340 getMergeRequestDetail : ( input ) =>
337341 Effect . sync ( ( ) => {
338342 calls . detail += 1 ;
@@ -558,3 +562,119 @@ describe("optional activity reads", () => {
558562 } ) ,
559563 ) ;
560564} ) ;
565+
566+ describe ( "review decisions" , ( ) => {
567+ const reference = { cwd : "/w" , repository : "acme/web" , host : "gitlab.com" , number : 7 } ;
568+ const item = {
569+ number : 7 ,
570+ title : "Merge request 7" ,
571+ url : "https://gitlab.com/acme/web/-/merge_requests/7" ,
572+ author : null ,
573+ headBranch : "feat/page" ,
574+ baseBranch : "main" ,
575+ state : "open" as const ,
576+ isDraft : false ,
577+ mergeability : "mergeable" as const ,
578+ additions : 0 ,
579+ deletions : 0 ,
580+ createdAt : "2026-07-01T00:00:00Z" ,
581+ updatedAt : "2026-07-02T00:00:00Z" ,
582+ reviewRequestLogins : [ ] ,
583+ labels : [ ] ,
584+ } ;
585+ const detail = {
586+ ...item ,
587+ body : "" ,
588+ changedFiles : 1 ,
589+ mergedAt : null ,
590+ closedAt : null ,
591+ reviewers : [ ] ,
592+ checks : [ ] ,
593+ viewerCanMerge : true ,
594+ reviewerIds : [ ] ,
595+ } ;
596+ const providerWith = (
597+ getReviewDecisions : GitLabPullRequestCli . GitLabPullRequestCli [ "Service" ] [ "getReviewDecisions" ] ,
598+ ) =>
599+ make . pipe (
600+ Effect . provide (
601+ Layer . mock ( GitLabPullRequestCli . GitLabPullRequestCli ) ( {
602+ listMergeRequests : ( ) =>
603+ Effect . succeed ( {
604+ items : [ item , { ...item , number : 8 } ] ,
605+ truncated : false ,
606+ cursorAdvance : 2 ,
607+ } ) ,
608+ getMergeRequestDetail : ( ) => Effect . succeed ( detail ) ,
609+ getReviewDecisions,
610+ listMergeRequestStats : ( ) =>
611+ Effect . succeed ( [ { repository : "acme/web" , number : 7 , additions : 40 , deletions : 2 } ] ) ,
612+ } ) ,
613+ ) ,
614+ ) ;
615+ const listing = {
616+ cwd : "/w" ,
617+ repository : "acme/web" ,
618+ host : "gitlab.com" ,
619+ state : "open" as const ,
620+ involvement : "all" as const ,
621+ viewer : "julius" ,
622+ limit : 2 ,
623+ } ;
624+
625+ it . effect ( "puts GitLab's approval state on listed and summarized merge requests" , ( ) =>
626+ Effect . gen ( function * ( ) {
627+ const provider = yield * providerWith ( ( input ) => {
628+ expect ( input . host ) . toBe ( reference . host ) ;
629+ return Effect . succeed (
630+ new Map ( [
631+ [ 7 , "approved" as const ] ,
632+ [ 8 , null ] ,
633+ ] ) ,
634+ ) ;
635+ } ) ;
636+ const listed = yield * provider . listChangeRequests ( listing ) ;
637+ assert . isDefined ( provider . getChangeRequestSummary ) ;
638+ const summary = yield * provider . getChangeRequestSummary ( reference ) ;
639+
640+ expect ( listed . items . map ( ( { reviewDecision } ) => reviewDecision ) ) . toEqual ( [ "approved" , null ] ) ;
641+ expect ( summary . reviewDecision ) . toBe ( "approved" ) ;
642+ expect ( summary . additions ) . toBe ( 40 ) ;
643+ expect ( summary . deletions ) . toBe ( 2 ) ;
644+ } ) ,
645+ ) ;
646+
647+ it . effect . each ( [
648+ {
649+ failure : "a failed read" ,
650+ error : new GitLabPullRequestCli . GitLabMergeRequestReadError ( {
651+ command : "glab" ,
652+ cwd : "/w" ,
653+ operation : "getReviewDecisions" ,
654+ cause : null ,
655+ } ) ,
656+ } ,
657+ {
658+ failure : "a rate limit" ,
659+ error : new GitLabCli . GitLabCliRateLimitError ( {
660+ operation : "execute" ,
661+ command : "glab" ,
662+ cwd : "/w" ,
663+ cause : null ,
664+ } ) ,
665+ } ,
666+ ] ) ( "keeps rows and summaries with an unknown decision after $failure" , ( { error } ) =>
667+ Effect . gen ( function * ( ) {
668+ const provider = yield * providerWith ( ( ) => Effect . fail ( error ) ) ;
669+ const listed = yield * provider . listChangeRequests ( listing ) ;
670+ assert . isDefined ( provider . getChangeRequestSummary ) ;
671+ const summary = yield * provider . getChangeRequestSummary ( reference ) ;
672+
673+ expect ( listed . items . map ( ( { reviewDecision } ) => reviewDecision ) ) . toEqual ( [
674+ undefined ,
675+ undefined ,
676+ ] ) ;
677+ expect ( summary . reviewDecision ) . toBeUndefined ( ) ;
678+ } ) ,
679+ ) ;
680+ } ) ;
0 commit comments