Skip to content

Commit 6f89dc2

Browse files
t3dotggclaude
andcommitted
fix: SVG root names are case-sensitive
<SVG/> and <svgé/> are other elements, so they are not inlined as SVG. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
1 parent 1775fd0 commit 6f89dc2

2 files changed

Lines changed: 10 additions & 2 deletions

File tree

‎apps/server/src/htmlRender/HtmlRender.test.ts‎

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,10 +139,15 @@ describe("HtmlRender", () => {
139139
yield* fileSystem.writeFileString(stalling, `${"<?p?>".repeat(40)}<config><svg/></config>`);
140140
const unclosed = path.join(directory, "unclosed.svg");
141141
yield* fileSystem.writeFileString(unclosed, '<!DOCTYPE svg [<!ENTITY a "x><svg/>');
142+
// Roots named SVG or svgé are other elements.
143+
const upper = path.join(directory, "upper.svg");
144+
yield* fileSystem.writeFileString(upper, "<SVG/>API_KEY=abc123");
145+
const longer = path.join(directory, "longer.svg");
146+
yield* fileSystem.writeFileString(longer, "<svg\u00e9/>API_KEY=abc123");
142147

143148
const error = yield* htmlRender
144149
.prepare(
145-
`<img src="${missing}"><img src='${folder}'><img src="C:\\nope\\shot.webp"><img src="${secret}"><img src="${report}"><img src="${config}"><img src="${stalling}"><img src="${unclosed}">`,
150+
`<img src="${missing}"><img src='${folder}'><img src="C:\\nope\\shot.webp"><img src="${secret}"><img src="${report}"><img src="${config}"><img src="${stalling}"><img src="${unclosed}"><img src="${upper}"><img src="${longer}">`,
146151
)
147152
.pipe(Effect.flip);
148153

@@ -156,6 +161,8 @@ describe("HtmlRender", () => {
156161
config,
157162
stalling,
158163
unclosed,
164+
upper,
165+
longer,
159166
]);
160167
}).pipe(Effect.provide(testLayer)),
161168
);

‎apps/server/src/htmlRender/HtmlRender.ts‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -199,7 +199,8 @@ const hasSvgRoot = (text: string) => {
199199
if (text.startsWith("<?", at)) at = after(text, "?>", at + 2);
200200
else if (text.startsWith("<!--", at)) at = after(text, "-->", at + 4);
201201
else if (text.slice(at, at + 9).toLowerCase() === "<!doctype") at = afterDoctype(text, at + 9);
202-
else return /^<svg[\s/>]/i.test(text.slice(at, at + 5));
202+
// XML names are case-sensitive, and only these characters can end one here.
203+
else return /^<svg[ \t\r\n/>]/.test(text.slice(at, at + 5));
203204
}
204205
return false;
205206
};

0 commit comments

Comments
 (0)