Skip to content

Commit 6ecbf4b

Browse files
fix(mobile): remove Android input underline backgrounds
1 parent 9946541 commit 6ecbf4b

3 files changed

Lines changed: 82 additions & 0 deletions

File tree

‎apps/mobile/app.config.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -422,6 +422,7 @@ const config: ExpoConfig = {
422422
"./plugins/withIosSceneLifecycle.cjs",
423423
"./plugins/withAndroidCleartextTraffic.cjs",
424424
"./plugins/withAndroidGradleHeap.cjs",
425+
"./plugins/withAndroidInputBackground.cjs",
425426
"./plugins/withAndroidModernPopupMenu.cjs",
426427
"./plugins/withAndroidModernAlertDialog.cjs",
427428
"./plugins/withAndroidPredictiveBackCompat.cjs",
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
const { withAndroidStyles } = require("expo/config-plugins");
2+
3+
module.exports = function withAndroidInputBackground(config) {
4+
return withAndroidStyles(config, (config) => {
5+
const appTheme = config.modResults.resources.style?.find(
6+
(style) => style.$?.name === "AppTheme",
7+
);
8+
if (!appTheme) {
9+
throw new Error("withAndroidInputBackground: AppTheme is missing from styles.xml.");
10+
}
11+
12+
// Inputs draw their own backgrounds and borders. Remove the native underline
13+
// drawable so it cannot peek out beneath rounded corners or return on focus.
14+
// Set both attributes for AppCompat and framework EditText implementations.
15+
appTheme.item ??= [];
16+
for (const name of ["editTextBackground", "android:editTextBackground"]) {
17+
const existing = appTheme.item.find((item) => item.$?.name === name);
18+
if (existing) {
19+
existing._ = "@null";
20+
} else {
21+
appTheme.item.push({ $: { name }, _: "@null" });
22+
}
23+
}
24+
25+
return config;
26+
});
27+
};
Lines changed: 54 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,54 @@
1+
import { describe, expect, it } from "vitest";
2+
import withAndroidInputBackground from "./withAndroidInputBackground.cjs";
3+
4+
async function transform(resources) {
5+
const config = withAndroidInputBackground({ name: "Test", slug: "test" });
6+
const result = await config.mods.android.styles({
7+
...config,
8+
modRequest: { platform: "android", modName: "styles", introspect: false },
9+
modResults: { resources: structuredClone(resources) },
10+
});
11+
return result.modResults.resources;
12+
}
13+
14+
describe("Android input background generation", () => {
15+
it("removes framework and AppCompat underlines while preserving other theme settings", async () => {
16+
const color = { $: { name: "colorPrimary" }, _: "@color/colorPrimary" };
17+
const dialog = { $: { name: "AppAlertDialog" }, item: [color] };
18+
const result = await transform({
19+
style: [
20+
{
21+
$: { name: "AppTheme", parent: "Theme.AppCompat.DayNight.NoActionBar" },
22+
item: [
23+
color,
24+
{ $: { name: "android:editTextBackground" }, _: "@drawable/rn_edit_text_material" },
25+
],
26+
},
27+
dialog,
28+
],
29+
});
30+
31+
expect(result.style[0]).toEqual({
32+
$: { name: "AppTheme", parent: "Theme.AppCompat.DayNight.NoActionBar" },
33+
item: [
34+
color,
35+
{ $: { name: "android:editTextBackground" }, _: "@null" },
36+
{ $: { name: "editTextBackground" }, _: "@null" },
37+
],
38+
});
39+
expect(result.style[1]).toEqual(dialog);
40+
expect(await transform(result)).toEqual(result);
41+
});
42+
43+
it("handles a theme with no existing items", async () => {
44+
const result = await transform({ style: [{ $: { name: "AppTheme" } }] });
45+
expect(result.style[0].item).toEqual([
46+
{ $: { name: "editTextBackground" }, _: "@null" },
47+
{ $: { name: "android:editTextBackground" }, _: "@null" },
48+
]);
49+
});
50+
51+
it("fails visibly if the Android theme template changes", async () => {
52+
await expect(transform({})).rejects.toThrow("AppTheme is missing");
53+
});
54+
});

0 commit comments

Comments
 (0)