Skip to content

Commit 6d1770a

Browse files
perf(web): the open panel pull request URL hook compiles without manual memoization
Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent a702563 commit 6d1770a

1 file changed

Lines changed: 42 additions & 29 deletions

File tree

‎apps/web/src/hooks/useOpenPanelPullRequestUrl.ts‎

Lines changed: 42 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,5 @@
11
import { scopeProjectRef } from "@t3tools/client-runtime/environment";
22
import { EnvironmentId, ProjectId, type ScopedThreadRef } from "@t3tools/contracts";
3-
import { useMemo } from "react";
43

54
import {
65
readPullRequestDetailSnapshot,
@@ -14,6 +13,35 @@ import { pullRequestEnvironment } from "../state/pullRequests";
1413
import { useEnvironmentQuery } from "../state/query";
1514
import { useSupportsMultiplePullRequests } from "./useSupportsMultiplePullRequests";
1615

16+
type PanelPullRequestSurface = Extract<
17+
NonNullable<ReturnType<typeof selectActiveRightPanelSurface>>,
18+
{ kind: "pull-request" }
19+
>;
20+
21+
// The reference keys the detail query atom, so it must keep its identity across renders.
22+
function usePanelPullRequestReference(
23+
requestedReference: PanelPullRequestSurface | null,
24+
supportsMultiplePullRequests: boolean,
25+
repositoryIdentity: Parameters<typeof resolvePullRequestReferenceHost>[1],
26+
) {
27+
"use memo";
28+
if (requestedReference === null) return null;
29+
const input = {
30+
projectId: ProjectId.make(requestedReference.projectId),
31+
repository: requestedReference.repository,
32+
number: requestedReference.number,
33+
};
34+
return supportsMultiplePullRequests
35+
? resolvePullRequestReferenceHost(
36+
{
37+
...input,
38+
...(requestedReference.host === undefined ? {} : { host: requestedReference.host }),
39+
},
40+
repositoryIdentity,
41+
)
42+
: input;
43+
}
44+
1745
export function useOpenPanelPullRequestUrl(threadRef: ScopedThreadRef | null) {
1846
const surface = useRightPanelStore((state) =>
1947
selectActiveRightPanelSurface(state.byThreadKey, threadRef),
@@ -28,23 +56,11 @@ export function useOpenPanelPullRequestUrl(threadRef: ScopedThreadRef | null) {
2856
? scopeProjectRef(environmentId, ProjectId.make(requestedReference.projectId))
2957
: null,
3058
);
31-
const reference = useMemo(() => {
32-
if (requestedReference === null) return null;
33-
const input = {
34-
projectId: ProjectId.make(requestedReference.projectId),
35-
repository: requestedReference.repository,
36-
number: requestedReference.number,
37-
};
38-
return supportsMultiplePullRequests
39-
? resolvePullRequestReferenceHost(
40-
{
41-
...input,
42-
...(requestedReference.host === undefined ? {} : { host: requestedReference.host }),
43-
},
44-
project?.repositoryIdentity,
45-
)
46-
: input;
47-
}, [requestedReference, supportsMultiplePullRequests, project?.repositoryIdentity]);
59+
const reference = usePanelPullRequestReference(
60+
requestedReference,
61+
supportsMultiplePullRequests,
62+
project?.repositoryIdentity,
63+
);
4864
const detail = useEnvironmentQuery(
4965
reference && environmentId
5066
? pullRequestEnvironment.detail({
@@ -53,17 +69,14 @@ export function useOpenPanelPullRequestUrl(threadRef: ScopedThreadRef | null) {
5369
})
5470
: null,
5571
).data;
56-
const cachedDetail = useMemo(
57-
() =>
58-
reference && environmentId
59-
? readPullRequestDetailSnapshot(
60-
typeof window === "undefined" ? undefined : window.localStorage,
61-
environmentId,
62-
reference,
63-
)
64-
: null,
65-
[environmentId, reference],
66-
);
72+
const cachedDetail =
73+
reference && environmentId
74+
? readPullRequestDetailSnapshot(
75+
typeof window === "undefined" ? undefined : window.localStorage,
76+
environmentId,
77+
reference,
78+
)
79+
: null;
6780
return reference
6881
? (resolveDisplayedPullRequestDetail({ live: detail, cached: cachedDetail, reference })?.url ??
6982
requestedReference?.url ??

0 commit comments

Comments
 (0)