@@ -178,7 +178,7 @@ describe("CDP relay extra sessions", () => {
178178} ) ;
179179
180180describe ( "CDP relay downloads" , ( ) => {
181- it ( "applies the server's download directory and reports downloads on the root session " , async ( ) => {
181+ it ( "captures preview downloads without changing the default browser context " , async ( ) => {
182182 const send = vi . fn ( async ( ) => ( { } ) ) ;
183183 const directories : Array < string | null > = [ ] ;
184184 const written : Array < Record < string , unknown > > = [ ] ;
@@ -201,15 +201,59 @@ describe("CDP relay downloads", () => {
201201 ) ;
202202 await settle ( ) ;
203203 expect ( directories ) . toEqual ( [ "/srv/artifacts" ] ) ;
204- expect ( send ) . toHaveBeenCalledWith (
205- "Browser.setDownloadBehavior" ,
206- { behavior : "allowAndName" , downloadPath : "/srv/artifacts" , eventsEnabled : true } ,
207- undefined ,
208- ) ;
204+ expect ( send . mock . calls ) . toEqual ( [
205+ [ "Page.setDownloadBehavior" , { behavior : "default" } , undefined ] ,
206+ ] ) ;
209207 written . length = 0 ;
210- relay . event ( "Browser.downloadWillBegin" , { guid : "g1" , suggestedFilename : "r.csv" } , "" ) ;
208+ relay . event ( "Page.downloadWillBegin" , { guid : "g1" , suggestedFilename : "r.csv" } , "" ) ;
209+ relay . event ( "Page.downloadProgress" , { guid : "g1" , state : "completed" } , "" ) ;
211210 expect ( written ) . toEqual ( [
212211 { method : "Browser.downloadWillBegin" , params : { guid : "g1" , suggestedFilename : "r.csv" } } ,
212+ { method : "Browser.downloadProgress" , params : { guid : "g1" , state : "completed" } } ,
213+ ] ) ;
214+ } ) ;
215+
216+ it ( "keeps denial scoped to the preview and restores Electron's save handling when allowed" , async ( ) => {
217+ const send = vi . fn ( async ( ) => ( { } ) ) ;
218+ const directories : Array < string | null > = [ ] ;
219+ const relay = createCdpRelayConnection (
220+ makeTarget ( send , ( directory ) => directories . push ( directory ) ) ,
221+ ( ) => { } ,
222+ ) ;
223+ for ( const [ id , behavior ] of [ "deny" , "allowAndName" ] . entries ( ) ) {
224+ relay . receive (
225+ JSON . stringify ( {
226+ id,
227+ method : "Browser.setDownloadBehavior" ,
228+ params : { behavior, downloadPath : "/srv/artifacts" } ,
229+ } ) ,
230+ ) ;
231+ await settle ( ) ;
232+ }
233+ expect ( directories ) . toEqual ( [ null , "/srv/artifacts" ] ) ;
234+ expect ( send . mock . calls ) . toEqual ( [
235+ [ "Page.setDownloadBehavior" , { behavior : "deny" } , undefined ] ,
236+ [ "Page.setDownloadBehavior" , { behavior : "default" } , undefined ] ,
213237 ] ) ;
214238 } ) ;
239+
240+ it ( "does not publish download events when the connection has disabled them" , async ( ) => {
241+ const written : Array < Record < string , unknown > > = [ ] ;
242+ const relay = createCdpRelayConnection ( makeTarget ( vi . fn ( async ( ) => ( { } ) ) ) , ( raw ) =>
243+ written . push ( JSON . parse ( raw ) ) ,
244+ ) ;
245+ relay . receive ( JSON . stringify ( { id : 1 , method : "Target.setAutoAttach" , params : { } } ) ) ;
246+ relay . receive (
247+ JSON . stringify ( {
248+ id : 2 ,
249+ method : "Browser.setDownloadBehavior" ,
250+ params : { behavior : "allowAndName" , downloadPath : "/srv/artifacts" , eventsEnabled : false } ,
251+ } ) ,
252+ ) ;
253+ await settle ( ) ;
254+ written . length = 0 ;
255+ relay . event ( "Page.downloadWillBegin" , { guid : "g1" } , "" ) ;
256+ relay . event ( "Page.downloadProgress" , { guid : "g1" , state : "completed" } , "" ) ;
257+ expect ( written ) . toEqual ( [ ] ) ;
258+ } ) ;
215259} ) ;
0 commit comments