Repository navigation
Commit 6bd9201
committed
fix(shared): terminal labels after non-BMP letters stay plain text
A one-character character class directly before `$` fails to match a code
point outside the BMP on the V8 in our pinned Electron, so the boundary check
in `composerContextLegacy.ts` returned false when the text before a terminal
label ended in an astral letter. The label was then upgraded into a chip and
the `𐐀@build:7` case failed on `main`.
Rewrite the check as an alternation, which reads correctly on the affected
engines, and record why it is not a class.1 parent b67ac65 commit 6bd9201
1 file changed
Lines changed: 4 additions & 1 deletion
File tree
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
418 | 418 | | |
419 | 419 | | |
420 | 420 | | |
| 421 | + | |
| 422 | + | |
| 423 | + | |
421 | 424 | | |
422 | 425 | | |
423 | | - | |
| 426 | + | |
424 | 427 | | |
425 | 428 | | |
426 | 429 | | |
| |||
0 commit comments