Repository navigation
Commit 6a1b459
tsouth89
fix(build): isolate the self-check from Node's global module folders
Clearing NODE_PATH does not isolate CommonJS resolution. Node still falls back
to $HOME/.node_modules, $HOME/.node_libraries and the install prefix, so a
globally installed copy of a dependency missing from the package would satisfy
the probe and the check would report success on a broken artifact.
Reproduced by putting a package in %USERPROFILE%\.node_modules: with NODE_PATH
cleared it still resolved; with --no-global-search-paths it does not.
Reported by @SunkenInTime.1 parent 22731fd commit 6a1b459
1 file changed
Lines changed: 17 additions & 9 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1408 | 1408 | | |
1409 | 1409 | | |
1410 | 1410 | | |
1411 | | - | |
1412 | | - | |
1413 | | - | |
1414 | | - | |
1415 | | - | |
1416 | | - | |
1417 | | - | |
1418 | | - | |
1419 | | - | |
| 1411 | + | |
| 1412 | + | |
| 1413 | + | |
| 1414 | + | |
| 1415 | + | |
| 1416 | + | |
| 1417 | + | |
| 1418 | + | |
| 1419 | + | |
| 1420 | + | |
| 1421 | + | |
| 1422 | + | |
| 1423 | + | |
| 1424 | + | |
| 1425 | + | |
| 1426 | + | |
| 1427 | + | |
1420 | 1428 | | |
1421 | 1429 | | |
1422 | 1430 | | |
| |||
0 commit comments