Skip to content

Commit 695f5c9

Browse files
chore(lint): enforce t3code/no-polling-loop-in-tests (#25120)
1 parent d53b446 commit 695f5c9

15 files changed

Lines changed: 194 additions & 168 deletions

File tree

‎apps/mobile/src/features/agent-awareness/remoteRegistration.test.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -219,6 +219,7 @@ const layerRelayTest = ManagedRelayLayer.layer("https://relay.example.test").pip
219219
const runBackgroundOperations = Effect.fn("TestRemoteRegistration.runBackgroundOperations")(
220220
function* () {
221221
let idlePasses = 0;
222+
// oxlint-disable-next-line t3code/no-polling-loop-in-tests -- This harness drains mocked runtime jobs and their promise continuations, not external I/O or elapsed time.
222223
for (;;) {
223224
yield* Effect.promise(() => Promise.resolve());
224225
const pending = backgroundRuntime.pending.shift();

‎apps/server/src/background/HostPowerMonitor.test.ts‎

Lines changed: 7 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
import type { DesktopHostTelemetrySnapshot } from "@t3tools/contracts";
22
import { describe, expect, it } from "@effect/vitest";
33
import * as DateTime from "effect/DateTime";
4+
import * as Deferred from "effect/Deferred";
45
import * as Effect from "effect/Effect";
56
import * as Fiber from "effect/Fiber";
67
import * as Layer from "effect/Layer";
@@ -114,6 +115,7 @@ describe("HostPowerMonitor", () => {
114115
},
115116
};
116117
const desktopChanges = yield* PubSub.sliding<DesktopHostTelemetrySnapshot>(1);
118+
const changeApplied = yield* Deferred.make<void>();
117119
const layerReceiver = DesktopTelemetryReceiver.layerTest({
118120
latest: Effect.succeedSome(initial),
119121
changes: Stream.empty,
@@ -122,21 +124,18 @@ describe("HostPowerMonitor", () => {
122124
yield* PubSub.publish(desktopChanges, updated);
123125
return {
124126
latest: Option.some(initial),
125-
changes: Stream.fromSubscription(subscription),
127+
changes: Stream.fromSubscription(subscription).pipe(
128+
Stream.take(1),
129+
Stream.ensuring(Deferred.succeed(changeApplied, undefined)),
130+
),
126131
};
127132
}),
128133
});
129134
const layer = HostPowerMonitor.layer.pipe(Layer.provide(layerReceiver));
130135

131136
yield* Effect.gen(function* () {
132137
const monitor = yield* HostPowerMonitor.HostPowerMonitor;
133-
for (
134-
let attempt = 0;
135-
attempt < 100 && (yield* monitor.snapshot).onBattery !== "true";
136-
attempt += 1
137-
) {
138-
yield* Effect.yieldNow;
139-
}
138+
yield* Deferred.await(changeApplied);
140139
expect((yield* monitor.snapshot).onBattery).toBe("true");
141140
}).pipe(Effect.provide(layer));
142141
}),

‎apps/server/src/orchestration-v2/Adapters/AcpAdapterV2.test.ts‎

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4169,6 +4169,7 @@ describe("AcpAdapterV2", () => {
41694169
const responseWritten = yield* Deferred.make<void>();
41704170
const releaseResponseAcknowledgement = yield* Deferred.make<void>();
41714171
const responseLifecycle: Array<string> = [];
4172+
const responseFailed = yield* Deferred.make<void>();
41724173
const instanceId = ProviderInstanceId.make("acp-test-normal-close-held-response");
41734174
const adapter = yield* makeAcpAdapterV2({
41744175
instanceId,
@@ -4191,6 +4192,7 @@ describe("AcpAdapterV2", () => {
41914192
onNativeResponseLifecycle: (event) =>
41924193
Effect.sync(() => {
41934194
responseLifecycle.push(event.type);
4195+
if (event.type === "failed") Deferred.doneUnsafe(responseFailed, Effect.void);
41944196
}),
41954197
},
41964198
});
@@ -4244,9 +4246,7 @@ describe("AcpAdapterV2", () => {
42444246
yield* Deferred.await(responseWritten);
42454247

42464248
const closeFiber = yield* Scope.close(sessionScope, Exit.void).pipe(Effect.forkScoped);
4247-
while (!responseLifecycle.includes("failed")) {
4248-
yield* Effect.yieldNow;
4249-
}
4249+
yield* Deferred.await(responseFailed);
42504250
const responseExit = yield* Fiber.join(responseFiber);
42514251
if (Exit.isSuccess(responseExit)) {
42524252
assert.fail("normal close must fail a response whose transport acknowledgement is held");
@@ -6234,6 +6234,7 @@ describe("AcpAdapterV2", () => {
62346234
type RuntimeService = AcpSessionRuntime.AcpSessionRuntime["Service"];
62356235
let sessionUpdateHandler: Parameters<RuntimeService["handleSessionUpdate"]>[0] | undefined;
62366236
const promptGates: Array<Deferred.Deferred<EffectAcpSchema.PromptResponse, never>> = [];
6237+
const promptStarted = yield* Queue.unbounded<void>();
62376238
const capturedMutation: {
62386239
current:
62396240
| ((mutation: {
@@ -6304,6 +6305,7 @@ describe("AcpAdapterV2", () => {
63046305
Effect.gen(function* () {
63056306
const gate = yield* Deferred.make<EffectAcpSchema.PromptResponse>();
63066307
promptGates.push(gate);
6308+
yield* Queue.offer(promptStarted, undefined);
63076309
return yield* Deferred.await(gate);
63086310
}),
63096311
}),
@@ -6354,9 +6356,7 @@ describe("AcpAdapterV2", () => {
63546356
makeTurnInput({ threadId, providerThread, instanceId, runtimePolicy, now, ordinal: 1 }),
63556357
)
63566358
.pipe(Effect.forkScoped);
6357-
while (promptGates.length < 1) {
6358-
yield* Effect.yieldNow;
6359-
}
6359+
yield* Queue.take(promptStarted);
63606360
assert.isDefined(sessionUpdateHandler, "session update handler must be wired");
63616361
const applyMutation = capturedMutation.current;
63626362
if (applyMutation === null) {
@@ -6489,9 +6489,7 @@ describe("AcpAdapterV2", () => {
64896489
}),
64906490
)
64916491
.pipe(Effect.forkScoped);
6492-
while (promptGates.length < 2) {
6493-
yield* Effect.yieldNow;
6494-
}
6492+
yield* Queue.take(promptStarted);
64956493
if (sessionUpdateHandler === undefined || capturedMutation.current === null) {
64966494
return yield* Effect.die("extensions and session handler must be wired for turn 2");
64976495
}

‎apps/server/src/orchestration-v2/FoundationPersistence.test.ts‎

Lines changed: 26 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -737,6 +737,7 @@ it.layer(layerTest)("orchestration V2 foundation persistence", (it) => {
737737
});
738738

739739
let afterSequence = created[0]!.sequence;
740+
// oxlint-disable-next-line t3code/no-polling-loop-in-tests -- Fixed-count writes exercise the catch-up/live handoff; each iteration awaits its event rather than polling.
740741
for (let index = 1; index <= 32; index += 1) {
741742
const nextEvent = {
742743
id: EventId.make(`event:foundation-stream-race:${index}`),
@@ -2426,6 +2427,8 @@ it.layer(layerTest)("orchestration V2 foundation persistence", (it) => {
24262427
const releaseA1 = yield* Deferred.make<void>();
24272428
const releaseA2 = yield* Deferred.make<void>();
24282429
const releaseB1 = yield* Deferred.make<void>();
2430+
const settled = yield* Deferred.make<void>();
2431+
const completed = yield* Ref.make(0);
24292432
const gates = new Map([
24302433
[effectA1, { started: startedA1, release: releaseA1 }],
24312434
[effectA2, { started: startedA2, release: releaseA2 }],
@@ -2447,7 +2450,24 @@ it.layer(layerTest)("orchestration V2 foundation persistence", (it) => {
24472450
workerId: "concurrency-worker",
24482451
}).pipe(
24492452
Layer.provide(
2450-
Layer.merge(Layer.succeed(EffectOutbox.EffectOutboxV2, outbox), layerExecutor),
2453+
Layer.merge(
2454+
Layer.succeed(EffectOutbox.EffectOutboxV2, {
2455+
...outbox,
2456+
succeed: (input) =>
2457+
outbox
2458+
.succeed(input)
2459+
.pipe(
2460+
Effect.tap(() =>
2461+
Ref.updateAndGet(completed, (count) => count + 1).pipe(
2462+
Effect.flatMap((count) =>
2463+
count === 3 ? Deferred.succeed(settled, undefined) : Effect.void,
2464+
),
2465+
),
2466+
),
2467+
),
2468+
}),
2469+
layerExecutor,
2470+
),
24512471
),
24522472
);
24532473

@@ -2493,13 +2513,12 @@ it.layer(layerTest)("orchestration V2 foundation persistence", (it) => {
24932513
yield* Deferred.succeed(releaseB1, undefined);
24942514
yield* Deferred.await(startedA2);
24952515
yield* Deferred.succeed(releaseA2, undefined);
2496-
let settled = false;
2497-
while (!settled) {
2498-
settled = (yield* outbox.listByCommandId(commandId)).every(
2516+
yield* Deferred.await(settled);
2517+
assert.isTrue(
2518+
(yield* outbox.listByCommandId(commandId)).every(
24992519
(effect) => effect.status === "succeeded",
2500-
);
2501-
if (!settled) yield* Effect.yieldNow;
2502-
}
2520+
),
2521+
);
25032522
}).pipe(Effect.provide(layerWorker), Effect.scoped);
25042523
}),
25052524
);

‎apps/server/src/project/ProjectEnrichmentService.test.ts‎

Lines changed: 10 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,16 @@ const waitForAvailable = Effect.fn("ProjectEnrichmentServiceTest.waitForAvailabl
2525
workspaceRoot: string,
2626
predicate: (value: ProjectEnrichment.ProjectEnrichment) => boolean,
2727
) {
28-
for (let attempt = 0; attempt < 100; attempt += 1) {
29-
const available = yield* service.peek(workspaceRoot);
30-
if (predicate(available)) return available;
31-
yield* Effect.yieldNow;
32-
}
33-
return yield* Effect.die(`Project metadata for ${workspaceRoot} was not resolved in time.`);
28+
return yield* Effect.scoped(
29+
Effect.gen(function* () {
30+
const changes = yield* service.subscribeChanges;
31+
for (;;) {
32+
const available = yield* service.peek(workspaceRoot);
33+
if (predicate(available)) return available;
34+
yield* PubSub.take(changes);
35+
}
36+
}),
37+
);
3438
});
3539

3640
const layer = (

‎apps/server/src/project/ProjectService.test.ts‎

Lines changed: 43 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,6 @@
1+
import * as Context from "effect/Context";
2+
import * as Queue from "effect/Queue";
3+
import * as Tracer from "effect/Tracer";
14
import { assert, it } from "@effect/vitest";
25
import * as NodeServices from "@effect/platform-node/NodeServices";
36
import { CommandId, type Project, ProjectId, ProviderInstanceId } from "@t3tools/contracts";
@@ -56,6 +59,35 @@ const layerMetadata = Layer.merge(
5659
}),
5760
);
5861

62+
class EnrichmentCompletions extends Context.Service<EnrichmentCompletions, Queue.Queue<void>>()(
63+
"t3/project/ProjectService.test/EnrichmentCompletions",
64+
) {}
65+
66+
const layerEnrichmentCompletions = Layer.effectContext(
67+
Effect.gen(function* () {
68+
const completions = yield* Queue.unbounded<void>();
69+
const tracer = Tracer.make({
70+
span: (options) => {
71+
const span = new Tracer.NativeSpan(options);
72+
const end = span.end.bind(span);
73+
span.end = (...args) => {
74+
end(...args);
75+
if (
76+
span.name === "ProjectEnrichmentService.resolveRepositoryIdentity" ||
77+
span.name === "ProjectEnrichmentService.resolveFavicon"
78+
) {
79+
Queue.offerUnsafe(completions, undefined);
80+
}
81+
};
82+
return span;
83+
},
84+
});
85+
return Context.make(EnrichmentCompletions, completions).pipe(
86+
Context.add(Tracer.Tracer, tracer),
87+
);
88+
}),
89+
);
90+
5991
const layerTestFor = (
6092
projectMetadataLayer: Layer.Layer<
6193
| ProjectFaviconResolver.ProjectFaviconResolver
@@ -70,6 +102,7 @@ const layerTestFor = (
70102
Layer.provideMerge(ServerSettings.layerTest()),
71103
Layer.provide(ServerConfig.layerTest(process.cwd(), { prefix: "project-service-test-" })),
72104
Layer.provide(NodeServices.layer),
105+
Layer.provideMerge(layerEnrichmentCompletions),
73106
);
74107

75108
const layerTest = layerTestFor(layerMetadata);
@@ -96,12 +129,16 @@ const waitForProject = Effect.fn("ProjectServiceTest.waitForProject")(function*
96129
projectId: ProjectId,
97130
predicate: (project: Project) => boolean,
98131
) {
99-
for (let attempt = 0; attempt < 100; attempt += 1) {
100-
const project = Option.getOrThrow(yield* service.getById(projectId));
101-
if (predicate(project)) return project;
102-
yield* Effect.yieldNow;
103-
}
104-
return yield* Effect.die(`Project ${projectId} was not enriched in time.`);
132+
return yield* Effect.scoped(
133+
Effect.gen(function* () {
134+
const completions = yield* EnrichmentCompletions;
135+
for (;;) {
136+
const project = Option.getOrThrow(yield* service.getById(projectId));
137+
if (predicate(project)) return project;
138+
yield* Queue.take(completions);
139+
}
140+
}),
141+
);
105142
});
106143

107144
it.layer(layerTest)("ProjectService", (it) => {

‎apps/server/src/scheduledTasks/ScheduledTaskService.webhook.test.ts‎

Lines changed: 17 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -503,6 +503,20 @@ it.effect.each(queuedDeliveryCases)(
503503
({ reason, apply }) =>
504504
Effect.gen(function* () {
505505
const gate = yield* Deferred.make<void>();
506+
const deliveryReleased = yield* Deferred.make<void>();
507+
const tracer = Tracer.make({
508+
span: (options) => {
509+
const span = new Tracer.NativeSpan(options);
510+
const end = span.end.bind(span);
511+
span.end = (...args) => {
512+
end(...args);
513+
if (span.name === "ScheduledTaskService.releaseFailedDelivery") {
514+
Deferred.doneUnsafe(deliveryReleased, Effect.void);
515+
}
516+
};
517+
return span;
518+
},
519+
});
506520
yield* withService(
507521
({ service, launches }) =>
508522
Effect.gen(function* () {
@@ -513,23 +527,17 @@ it.effect.each(queuedDeliveryCases)(
513527
yield* apply(service, task.id);
514528
yield* Deferred.succeed(gate, undefined);
515529
const deliveryId = queued._tag === "accepted" ? queued.deliveryId : undefined;
516-
let delivery = (yield* service.getWebhookDelivery({
530+
yield* Deferred.await(deliveryReleased);
531+
const delivery = (yield* service.getWebhookDelivery({
517532
id: task.id,
518533
deliveryId: deliveryId!,
519534
})).delivery;
520-
while (delivery.outcome === "accepted") {
521-
yield* Effect.yieldNow;
522-
delivery = (yield* service.getWebhookDelivery({
523-
id: task.id,
524-
deliveryId: deliveryId!,
525-
})).delivery;
526-
}
527535
assert.equal(delivery.outcome, "dispatch_failed");
528536
assert.equal(delivery.error, reason);
529537
assert.equal(yield* Queue.size(launches), 0);
530538
}),
531539
{ gate },
532-
);
540+
).pipe(Effect.withTracer(tracer));
533541
}),
534542
);
535543

‎apps/server/src/usage/UsageService.test.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2610,6 +2610,7 @@ describe("UsageService", () => {
26102610
);
26112611

26122612
let orphanedAt: number | undefined;
2613+
// oxlint-disable-next-line t3code/no-polling-loop-in-tests -- Fixed-count scheduler interruption matrix; each iteration exercises a different interruption point.
26132614
for (let interruptAt = 1; interruptAt <= 31; interruptAt += 1) {
26142615
const tasks: Array<() => void> = [];
26152616
const dispatcher: Scheduler.SchedulerDispatcher = {

‎packages/client-runtime/src/connection/supervisor.test.ts‎

Lines changed: 1 addition & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -127,25 +127,6 @@ function awaitState(
127127
);
128128
}
129129

130-
const eventuallyState = Effect.fn("TestConnectionHarness.eventuallyState")(function* (
131-
state: SubscriptionRef.SubscriptionRef<SupervisorConnectionState>,
132-
predicate: (value: SupervisorConnectionState) => boolean,
133-
) {
134-
let lastState = yield* SubscriptionRef.get(state);
135-
for (let iteration = 0; iteration < 100; iteration += 1) {
136-
lastState = yield* SubscriptionRef.get(state);
137-
if (predicate(lastState)) {
138-
return lastState;
139-
}
140-
yield* Effect.yieldNow;
141-
}
142-
return yield* Effect.die(
143-
new Error(
144-
`Expected supervisor state was not observed. Last state: phase=${lastState.phase}, stage=${lastState.stage ?? "none"}, attempt=${lastState.attempt}, generation=${lastState.generation}`,
145-
),
146-
);
147-
});
148-
149130
const makeHarness = Effect.fn("TestConnectionHarness.make")(function* (options?: {
150131
readonly networkStatus?: NetworkStatus;
151132
readonly prepare?: (
@@ -477,7 +458,7 @@ describe("EnvironmentSupervisor", () => {
477458
expect(yield* Ref.get(harness.prepareCount)).toBe(1);
478459

479460
yield* TestClock.adjust("15 seconds");
480-
const retrying = yield* eventuallyState(
461+
const retrying = yield* awaitState(
481462
supervisor.state,
482463
(state) => state.phase === "backoff" && state.attempt === 1,
483464
);

0 commit comments

Comments
 (0)