Skip to content

Commit 664f485

Browse files
chore(lint): enforce preferSucceedSomeOrNone
1 parent 468fd3a commit 664f485

32 files changed

Lines changed: 133 additions & 147 deletions

‎apps/desktop/src/app/DesktopClerk.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -297,7 +297,7 @@ it.effect(
297297
}),
298298
} as unknown as ElectronApp.ElectronApp["Service"];
299299
const electronWindow = {
300-
currentMainOrFirst: Effect.succeed(Option.some(window)),
300+
currentMainOrFirst: Effect.succeedSome(window),
301301
reveal: () => Effect.sync(() => revealed.resolve()),
302302
} as unknown as ElectronWindow.ElectronWindow["Service"];
303303
return Effect.gen(function* () {

‎apps/desktop/src/app/DesktopWebLinks.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ const makeWindow = () => {
2626
Layer.succeed(
2727
ElectronWindow.ElectronWindow,
2828
ElectronWindow.ElectronWindow.of({
29-
currentMainOrFirst: Effect.succeed(Option.some(window)),
29+
currentMainOrFirst: Effect.succeedSome(window),
3030
reveal: (target: Electron.BrowserWindow) => Effect.sync(() => void revealed.push(target)),
3131
} as unknown as ElectronWindow.ElectronWindow["Service"]),
3232
),

‎apps/server/src/cloud/CloudLink.lifecycle.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@ describe("releaseManagedTunnelOnShutdown", () => {
163163
ConnectReachability.ConnectReachability,
164164
ConnectReachability.ConnectReachability.of({
165165
check: Effect.die("unused"),
166-
latest: Effect.succeed(Option.none()),
166+
latest: Effect.succeedNone,
167167
}),
168168
),
169169
Effect.provideService(HttpServer.HttpServer, {

‎apps/server/src/cloud/CloudLink.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -96,7 +96,7 @@ const withService = <A, E>(
9696
Layer.mock(AgentAwarenessRelay.AgentAwarenessRelay)({ requestCatchUp: () => Effect.void }),
9797
Layer.mock(ManagedEndpointRuntime.CloudManagedEndpointRuntime)({}),
9898
Layer.mock(ConnectReachability.ConnectReachability)({
99-
latest: Effect.succeed(Option.none()),
99+
latest: Effect.succeedNone,
100100
}),
101101
Layer.mock(EnvironmentAuth.EnvironmentAuth)({}),
102102
Layer.mock(CliTokenManager.CloudCliTokenManager)({}),

‎apps/server/src/cloud/http.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ const layerLinkProofRoutes = HttpApiBuilder.layer(LinkProofTestApi).pipe(
7878
Layer.provide(AuthHttp.layerAuthenticatedAuth),
7979
Layer.provide(CloudLink.layer),
8080
Layer.provide(
81-
Layer.mock(ConnectReachability.ConnectReachability)({ latest: Effect.succeed(Option.none()) }),
81+
Layer.mock(ConnectReachability.ConnectReachability)({ latest: Effect.succeedNone }),
8282
),
8383
Layer.provide(EnvironmentAuth.layer),
8484
Layer.provide([

‎apps/server/src/mcp/McpDeviceToolkit.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ const readiness = {
102102
agentDevice: null,
103103
};
104104
const layerProjectsMock = Layer.mock(ProjectService.ProjectService)({
105-
getById: () => Effect.succeed(Option.none()),
105+
getById: () => Effect.succeedNone,
106106
});
107107

108108
const layerDeviceServiceMock = Layer.mock(DeviceService.DeviceService)({

‎apps/server/src/orchestration-v2/CheckpointRestoreSafety.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ it.effect.each([
101101
IdAllocator.layer,
102102
Layer.mock(GitWorkflowService.GitWorkflowService)({}),
103103
Layer.mock(ProjectStore.ProjectStoreV2)({
104-
get: () => Effect.succeed(Option.some({ workspaceRoot: parent } as never)),
104+
get: () => Effect.succeedSome({ workspaceRoot: parent } as never),
105105
}),
106106
Layer.mock(ProjectionStoreV2)({
107107
getThread: () => Effect.succeed(projection.thread),

‎apps/server/src/orchestration-v2/CheckpointRollbackService.test.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ it.effect.each([
229229
Layer.mock(ProjectStore.ProjectStoreV2)({
230230
get: (id) => {
231231
assert.equal(id, projectId);
232-
return Effect.succeed(Option.some({ workspaceRoot } as never));
232+
return Effect.succeedSome({ workspaceRoot } as never);
233233
},
234234
}),
235235
Layer.mock(GitWorkflow.GitWorkflowService)({

‎apps/server/src/orchestration-v2/CommandReceiptStore.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -161,10 +161,10 @@ const layerBase: Layer.Layer<
161161
receipts.getByCommandId({ commandId }).pipe(
162162
Effect.flatMap(
163163
Option.match({
164-
onNone: () => Effect.succeed(Option.none()),
164+
onNone: () => Effect.succeedNone,
165165
onSome: (receipt) =>
166166
receipt.aggregateKind !== "thread"
167-
? Effect.succeed(Option.none())
167+
? Effect.succeedNone
168168
: fromApplicationReceipt(receipt).pipe(Effect.asSome),
169169
}),
170170
),
@@ -180,7 +180,7 @@ const layerBase: Layer.Layer<
180180
receipts.getByCommandId({ commandId }).pipe(
181181
Effect.flatMap((receipt) =>
182182
Option.isNone(receipt) || receipt.value.aggregateKind !== "project"
183-
? Effect.succeed(Option.none())
183+
? Effect.succeedNone
184184
: decodeProjectReceipt({
185185
commandId: receipt.value.commandId,
186186
projectId: receipt.value.aggregateId,

‎apps/server/src/orchestration-v2/EffectOutbox.ts‎

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -419,9 +419,7 @@ export const layer: Layer.Layer<EffectOutboxV2, never, SqlClient.SqlClient> = La
419419
NodeSqliteClient.readOnly,
420420
Effect.flatMap((rows) => {
421421
const row = rows[0];
422-
return row === undefined
423-
? Effect.succeed(Option.none())
424-
: rowToEffect(row).pipe(Effect.asSome);
422+
return row === undefined ? Effect.succeedNone : rowToEffect(row).pipe(Effect.asSome);
425423
}),
426424
Effect.mapError((cause) => new EffectOutboxError({ operation: "get", effectId, cause })),
427425
),

0 commit comments

Comments
 (0)