Repository navigation
Commit 65443bc
committed
fix(mobile): carry row-derived list state on v2 items for recycled cells
A LegendList cell ignores the render closure while itemsAreEqual says the
item is unchanged, so anything the row renders or menus that lives outside
the item goes stale under recycling. Auditing the swap surfaced four:
- the queued-outbox icon (an outbox write never touches the thread shell),
- the card menu's move up/down availability (a reorder in flight, or its
commit, changes availability without a shell update),
- the shelf headers' preference-loading disabled state (a recycled header
would keep the state it mounted with), and
- the swipe-revealed snooze preset menu, which exists on slim settled rows
too (the variant only swaps the primary action), so the menu minute clock
was wrongly gated off them.
Stamp all four onto the list items in buildThreadListV2ListItems (queued
keys and move availability arrive as builder inputs the screens already
compute) so they flow through the same equality that gates cell re-renders,
and gate the snooze minute clock on actual snooze availability rather than
row variant.1 parent 9f45f72 commit 65443bc
4 files changed
Lines changed: 240 additions & 36 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
699 | 699 | | |
700 | 700 | | |
701 | 701 | | |
| 702 | + | |
| 703 | + | |
| 704 | + | |
| 705 | + | |
| 706 | + | |
| 707 | + | |
| 708 | + | |
| 709 | + | |
| 710 | + | |
| 711 | + | |
| 712 | + | |
| 713 | + | |
| 714 | + | |
| 715 | + | |
| 716 | + | |
| 717 | + | |
| 718 | + | |
702 | 719 | | |
703 | 720 | | |
704 | 721 | | |
| |||
792 | 809 | | |
793 | 810 | | |
794 | 811 | | |
| 812 | + | |
| 813 | + | |
| 814 | + | |
795 | 815 | | |
796 | 816 | | |
797 | 817 | | |
| 818 | + | |
| 819 | + | |
798 | 820 | | |
| 821 | + | |
799 | 822 | | |
800 | 823 | | |
801 | 824 | | |
| |||
838 | 861 | | |
839 | 862 | | |
840 | 863 | | |
841 | | - | |
| 864 | + | |
842 | 865 | | |
843 | 866 | | |
844 | 867 | | |
| |||
848 | 871 | | |
849 | 872 | | |
850 | 873 | | |
851 | | - | |
| 874 | + | |
852 | 875 | | |
853 | 876 | | |
854 | 877 | | |
855 | 878 | | |
856 | 879 | | |
857 | 880 | | |
858 | | - | |
859 | | - | |
860 | 881 | | |
861 | 882 | | |
862 | 883 | | |
863 | 884 | | |
864 | 885 | | |
865 | | - | |
| 886 | + | |
866 | 887 | | |
867 | 888 | | |
868 | 889 | | |
| |||
904 | 925 | | |
905 | 926 | | |
906 | 927 | | |
907 | | - | |
908 | | - | |
| 928 | + | |
| 929 | + | |
909 | 930 | | |
910 | 931 | | |
911 | 932 | | |
| |||
920 | 941 | | |
921 | 942 | | |
922 | 943 | | |
923 | | - | |
924 | | - | |
925 | | - | |
926 | 944 | | |
927 | 945 | | |
928 | 946 | | |
| |||
945 | 963 | | |
946 | 964 | | |
947 | 965 | | |
948 | | - | |
949 | 966 | | |
950 | 967 | | |
951 | 968 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
524 | 524 | | |
525 | 525 | | |
526 | 526 | | |
| 527 | + | |
| 528 | + | |
| 529 | + | |
| 530 | + | |
| 531 | + | |
| 532 | + | |
| 533 | + | |
| 534 | + | |
| 535 | + | |
| 536 | + | |
| 537 | + | |
| 538 | + | |
| 539 | + | |
| 540 | + | |
| 541 | + | |
| 542 | + | |
| 543 | + | |
527 | 544 | | |
528 | 545 | | |
529 | 546 | | |
| |||
613 | 630 | | |
614 | 631 | | |
615 | 632 | | |
| 633 | + | |
| 634 | + | |
| 635 | + | |
616 | 636 | | |
617 | 637 | | |
618 | 638 | | |
| |||
628 | 648 | | |
629 | 649 | | |
630 | 650 | | |
| 651 | + | |
| 652 | + | |
631 | 653 | | |
632 | 654 | | |
| 655 | + | |
633 | 656 | | |
634 | 657 | | |
635 | 658 | | |
| |||
886 | 909 | | |
887 | 910 | | |
888 | 911 | | |
889 | | - | |
890 | | - | |
891 | | - | |
892 | | - | |
893 | 912 | | |
894 | 913 | | |
895 | 914 | | |
896 | 915 | | |
897 | 916 | | |
898 | 917 | | |
899 | | - | |
| 918 | + | |
900 | 919 | | |
901 | 920 | | |
902 | 921 | | |
| |||
938 | 957 | | |
939 | 958 | | |
940 | 959 | | |
941 | | - | |
942 | | - | |
| 960 | + | |
| 961 | + | |
943 | 962 | | |
944 | 963 | | |
945 | 964 | | |
| |||
956 | 975 | | |
957 | 976 | | |
958 | 977 | | |
959 | | - | |
| 978 | + | |
960 | 979 | | |
961 | 980 | | |
962 | 981 | | |
| |||
966 | 985 | | |
967 | 986 | | |
968 | 987 | | |
969 | | - | |
| 988 | + | |
970 | 989 | | |
971 | 990 | | |
972 | 991 | | |
| |||
1063 | 1082 | | |
1064 | 1083 | | |
1065 | 1084 | | |
1066 | | - | |
1067 | | - | |
1068 | 1085 | | |
1069 | 1086 | | |
1070 | 1087 | | |
| |||
1087 | 1104 | | |
1088 | 1105 | | |
1089 | 1106 | | |
1090 | | - | |
1091 | 1107 | | |
1092 | 1108 | | |
1093 | 1109 | | |
| |||
0 commit comments