Skip to content

Commit 64b3a02

Browse files
chore(lint): enforce allOfMapToForEach
1 parent 6901fea commit 64b3a02

5 files changed

Lines changed: 18 additions & 19 deletions

File tree

‎apps/server/src/secrets/SecretRequests.test.ts‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -172,10 +172,9 @@ it.effect("two concurrent uses of one ref hand the value out once", () =>
172172
answer: { type: "save", secret: "ghp_secret" },
173173
});
174174
const ref = Option.getOrThrow(yield* service.savedRef({ threadId, turnItemId }));
175-
const results = yield* Effect.all(
176-
[service.consume({ ref, projectId }), service.consume({ ref, projectId })].map(
177-
Effect.result,
178-
),
175+
const results = yield* Effect.forEach(
176+
[service.consume({ ref, projectId }), service.consume({ ref, projectId })],
177+
Effect.result,
179178
{ concurrency: "unbounded" },
180179
);
181180
assert.deepEqual(results.map((result) => result._tag).toSorted(), ["Failure", "Success"]);

‎apps/server/src/serverSettings.test.ts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -410,8 +410,9 @@ it.layer(NodeServices.layer)("server settings", (it) => {
410410
Effect.gen(function* () {
411411
const serverSettings = yield* ServerSettingsModule.ServerSettingsService;
412412
const instanceId = ProviderInstanceId.make("acpRegistry_shared");
413-
const results = yield* Effect.all(
414-
["First", "Second"].map((displayName) =>
413+
const results = yield* Effect.forEach(
414+
["First", "Second"],
415+
(displayName) =>
415416
serverSettings
416417
.updateProviderInstance({
417418
operation: "create",
@@ -423,7 +424,6 @@ it.layer(NodeServices.layer)("server settings", (it) => {
423424
},
424425
})
425426
.pipe(Effect.result),
426-
),
427427
{ concurrency: "unbounded" },
428428
);
429429

‎packages/effect-acp/src/client.test.ts‎

Lines changed: 8 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1068,16 +1068,14 @@ it.layer(NodeServices.layer)("effect-acp client", (it) => {
10681068
yield* Queue.offer(
10691069
input,
10701070
concatBytes(
1071-
yield* Effect.all(
1072-
["permission-a", "permission-b"].map((id) =>
1073-
encodeJsonl(PermissionRequest, {
1074-
jsonrpc: "2.0",
1075-
id,
1076-
method: "session/request_permission",
1077-
params: payload,
1078-
headers: [],
1079-
}),
1080-
),
1071+
yield* Effect.forEach(["permission-a", "permission-b"], (id) =>
1072+
encodeJsonl(PermissionRequest, {
1073+
jsonrpc: "2.0",
1074+
id,
1075+
method: "session/request_permission",
1076+
params: payload,
1077+
headers: [],
1078+
}),
10811079
),
10821080
),
10831081
);

‎packages/provider-acp/src/server/clientTerminals.test.ts‎

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -361,13 +361,14 @@ describe("AcpClientTerminals", () => {
361361
sessionId: "foreign-session",
362362
terminalId: created.terminalId,
363363
};
364-
const results = yield* Effect.all(
364+
const results = yield* Effect.forEach(
365365
[
366366
terminals.output(foreignRequest),
367367
terminals.waitForExit(foreignRequest),
368368
terminals.kill(foreignRequest),
369369
terminals.release(foreignRequest),
370-
].map((effect) => effect.pipe(Effect.result)),
370+
],
371+
(effect) => effect.pipe(Effect.result),
371372
{ concurrency: "unbounded" },
372373
);
373374

‎tsconfig.base.json‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,7 @@
2424
"namespaceImportPackages": ["@effect/platform-node", "effect"],
2525
"effectFn": ["span", "inferred-span", "suggested-span"],
2626
"diagnosticSeverity": {
27+
"allOfMapToForEach": "error",
2728
"catchToOrElseSucceed": "error",
2829
"unnecessaryFailYieldableError": "error",
2930
"preferSucceedSomeOrNone": "error",

0 commit comments

Comments
 (0)