Repository navigation
Commit 6277e7f
committed
fix(web): default-branch confirmation keeps its copy while closing
The dialog's open state was derived from the pending action payload, so
dismissing it nulled the payload in the same render. The popup stayed
mounted for its 200ms exit transition with fallback copy ("Run action on
default branch?", no description, "Continue"), visibly shrinking before
it faded.
Track the open flag separately and clear the payload in
onOpenChangeComplete(false), matching RelayClientInstallDialog and
ConfirmDialogHost. The continue handler now checks the open flag so a
click during the exit transition cannot run the action twice.
Fixes #138311 parent 363f8ae commit 6277e7f
1 file changed
Lines changed: 10 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1056 | 1056 | | |
1057 | 1057 | | |
1058 | 1058 | | |
| 1059 | + | |
| 1060 | + | |
1059 | 1061 | | |
1060 | 1062 | | |
1061 | 1063 | | |
| |||
1305 | 1307 | | |
1306 | 1308 | | |
1307 | 1309 | | |
| 1310 | + | |
1308 | 1311 | | |
1309 | 1312 | | |
1310 | 1313 | | |
| |||
1418 | 1421 | | |
1419 | 1422 | | |
1420 | 1423 | | |
1421 | | - | |
| 1424 | + | |
1422 | 1425 | | |
1423 | 1426 | | |
1424 | | - | |
| 1427 | + | |
1425 | 1428 | | |
1426 | 1429 | | |
1427 | 1430 | | |
| |||
2092 | 2095 | | |
2093 | 2096 | | |
2094 | 2097 | | |
2095 | | - | |
2096 | | - | |
2097 | | - | |
2098 | | - | |
2099 | | - | |
| 2098 | + | |
| 2099 | + | |
| 2100 | + | |
| 2101 | + | |
2100 | 2102 | | |
2101 | 2103 | | |
2102 | 2104 | | |
| |||
2111 | 2113 | | |
2112 | 2114 | | |
2113 | 2115 | | |
2114 | | - | |
| 2116 | + | |
2115 | 2117 | | |
2116 | 2118 | | |
2117 | 2119 | | |
| |||
0 commit comments