Skip to content

Commit 62775db

Browse files
committed
fix(shared): show zero seconds in minute durations
1 parent 524a531 commit 62775db

2 files changed

Lines changed: 16 additions & 2 deletions

File tree

‎packages/shared/src/orchestrationTiming.test.ts‎

Lines changed: 15 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,20 @@
11
import { describe, expect, it } from "vite-plus/test";
22

3-
import { deriveSubagentElapsedMs } from "./orchestrationTiming.ts";
3+
import { deriveSubagentElapsedMs, formatDuration } from "./orchestrationTiming.ts";
4+
5+
describe("formatDuration", () => {
6+
it.each([
7+
[59_000, "59s"],
8+
[59_500, "1m 0s"],
9+
[60_000, "1m 0s"],
10+
[720_000, "12m 0s"],
11+
[736_000, "12m 16s"],
12+
[3_600_000, "1h"],
13+
[3_660_000, "1h 1m 0s"],
14+
])("formats %i milliseconds as %s", (durationMs, expected) => {
15+
expect(formatDuration(durationMs)).toBe(expected);
16+
});
17+
});
418

519
describe("deriveSubagentElapsedMs", () => {
620
const startedAt = "2026-09-21T12:00:00.000Z";

‎packages/shared/src/orchestrationTiming.ts‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -32,6 +32,6 @@ export function formatDuration(durationMs: number): string {
3232
const parts: string[] = [];
3333
if (hours > 0) parts.push(`${hours}h`);
3434
if (minutes > 0) parts.push(`${minutes}m`);
35-
if (seconds > 0) parts.push(`${seconds}s`);
35+
if (seconds > 0 || minutes > 0) parts.push(`${seconds}s`);
3636
return parts.join(" ");
3737
}

0 commit comments

Comments
 (0)