Skip to content

Commit 61e76aa

Browse files
perf(web): the open-source notices panel compiles with the React Compiler
Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 70d60e0 commit 61e76aa

2 files changed

Lines changed: 7 additions & 9 deletions

File tree

‎apps/web/reactCompiledFiles.ts‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -96,4 +96,5 @@ export const REACT_COMPILED_FILES = [
9696
"apps/web/src/components/pullRequest/PullRequestDetailPanel.tsx",
9797
"apps/web/src/components/ThreadTerminalDrawer.tsx",
9898
"apps/web/src/components/settings/SettingsPanels.tsx",
99+
"apps/web/src/components/settings/OpenSourceLicenses.tsx",
99100
] as const;

‎apps/web/src/components/settings/OpenSourceLicenses.tsx‎

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
import { ChevronRightIcon, ExternalLinkIcon, SearchIcon } from "lucide-react";
2-
import { useCallback, useEffect, useMemo, useState } from "react";
2+
import { useEffect, useState } from "react";
33

44
import {
55
decodeThirdPartyLicenseManifest,
@@ -215,11 +215,11 @@ export function OpenSourceLicensesPanel() {
215215
const [query, setQuery] = useState("");
216216
const [searchOpen, setSearchOpen] = useState(false);
217217
const [openEntryKey, setOpenEntryKey] = useState<string | null>(null);
218-
const [requestVersion, setRequestVersion] = useState(0);
218+
const loading = state.status === "loading";
219219

220220
useEffect(() => {
221+
if (!loading) return;
221222
let cancelled = false;
222-
setState({ status: "loading" });
223223
void loadLicenseManifest().then(
224224
(manifest) => {
225225
if (!cancelled) setState({ status: "ready", manifest });
@@ -235,14 +235,11 @@ export function OpenSourceLicensesPanel() {
235235
return () => {
236236
cancelled = true;
237237
};
238-
}, [requestVersion]);
238+
}, [loading]);
239239

240240
const entries = state.status === "ready" ? state.manifest.entries : [];
241-
const filteredEntries = useMemo(
242-
() => filterThirdPartyLicenseEntries(entries, query),
243-
[entries, query],
244-
);
245-
const retry = useCallback(() => setRequestVersion((value) => value + 1), []);
241+
const filteredEntries = filterThirdPartyLicenseEntries(entries, query);
242+
const retry = () => setState({ status: "loading" });
246243

247244
return (
248245
<SettingsPageContainer>

0 commit comments

Comments
 (0)