Skip to content

Commit 618e4fd

Browse files
PR Batch Testerclaude
andcommitted
fix(provider-cursor): skip result text from a resume that made no progress
Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 7964070 commit 618e4fd

2 files changed

Lines changed: 34 additions & 9 deletions

File tree

‎packages/provider-cursor/src/server/adapter.test.ts‎

Lines changed: 32 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -308,7 +308,22 @@ describe("CursorAdapterV2", () => {
308308
}),
309309
failure: null,
310310
},
311-
])("ends the turn with $reason", ({ updates = [], wait, failure }) =>
311+
{
312+
reason: "no answer from a resume after the turn ended that made no progress",
313+
updates: [{ type: "turn-ended" }] satisfies ReadonlyArray<InteractionUpdate>,
314+
wait: Effect.succeed({
315+
id: "native-cursor-run",
316+
requestId: "native-request",
317+
status: "error" as const,
318+
error: { message: "Agent turn stopped after repeated resume attempts made no progress" },
319+
result: "A regenerated closing.",
320+
model: { id: "claude-fable-5" },
321+
durationMs: 1,
322+
}),
323+
failure: null,
324+
answers: [],
325+
},
326+
])("ends the turn with $reason", ({ updates = [], wait, failure, answers }) =>
312327
Effect.gen(function* () {
313328
const fileSystem = yield* FileSystem.FileSystem;
314329
const workspace = yield* fileSystem.makeTempDirectoryScoped({ prefix: "cursor-v2-failure-" });
@@ -401,15 +416,23 @@ describe("CursorAdapterV2", () => {
401416
attachments: [],
402417
},
403418
});
404-
const terminal = yield* runtime.events.pipe(
405-
Stream.filter((event) => event.type === "turn.terminal"),
406-
Stream.runHead,
419+
const events = yield* runtime.events.pipe(
420+
Stream.takeUntil((event) => event.type === "turn.terminal"),
421+
Stream.runCollect,
407422
);
408-
assert.isTrue(Option.isSome(terminal));
409-
if (Option.isSome(terminal)) {
410-
assert.equal(terminal.value.status, failure === null ? "completed" : "failed");
411-
assert.equal(terminal.value.failure?.class, failure?.class);
412-
assert.equal(terminal.value.failure?.message, failure?.message);
423+
const terminal = events.find((event) => event.type === "turn.terminal");
424+
assert.equal(terminal?.status, failure === null ? "completed" : "failed");
425+
assert.equal(terminal?.failure?.class, failure?.class);
426+
assert.equal(terminal?.failure?.message, failure?.message);
427+
if (answers !== undefined) {
428+
assert.deepEqual(
429+
events.flatMap((event) =>
430+
event.type === "message.updated" && event.message.role === "assistant"
431+
? [event.message.text]
432+
: [],
433+
),
434+
answers,
435+
);
413436
}
414437
}).pipe(
415438
Effect.scoped,

‎packages/provider-cursor/src/server/adapter.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2363,6 +2363,8 @@ export const makeCursorAdapterV2 = Effect.fn("makeCursorAdapterV2")(function* (
23632363
if (
23642364
context !== null &&
23652365
context.assistant.nextSegment === 0 &&
2366+
// Text from a resume that made no progress is not the turn's answer.
2367+
!isResumeFailureAfterTurnEnded(context, result) &&
23662368
result.result !== undefined &&
23672369
result.result.length > 0
23682370
) {

0 commit comments

Comments
 (0)