@@ -3181,6 +3181,17 @@ describe("OrchestratorMcpService provider resolution", () => {
31813181 target : { options : { } } ,
31823182 expected : { ...inherited , options : [ ] } ,
31833183 } ,
3184+ {
3185+ name : "same model by alias" ,
3186+ target : { model : "GPT" } ,
3187+ expected : { ...inherited , model : "GPT" } ,
3188+ } ,
3189+ {
3190+ name : "parent named the same model by alias" ,
3191+ parent : { ...inherited , model : "gpt" } ,
3192+ target : { model : inherited . model } ,
3193+ expected : inherited ,
3194+ } ,
31843195 {
31853196 name : "change model" ,
31863197 target : { model : "other-model" } ,
@@ -3225,7 +3236,10 @@ describe("OrchestratorMcpService provider resolution", () => {
32253236 getThreadRecords : ( threadId ) =>
32263237 Effect . succeed (
32273238 threadId === parentThreadId
3228- ? parentProjection ( commands . length > 0 ? [ task ] : [ ] , inherited )
3239+ ? parentProjection (
3240+ commands . length > 0 ? [ task ] : [ ] ,
3241+ "parent" in testCase ? testCase . parent : inherited ,
3242+ )
32293243 : childProjection ,
32303244 ) ,
32313245 dispatch : ( command ) =>
@@ -3251,6 +3265,7 @@ describe("OrchestratorMcpService provider resolution", () => {
32513265 name : model ,
32523266 isCustom : false ,
32533267 capabilities : null ,
3268+ ...( model === inherited . model ? { aliases : [ "gpt" ] } : { } ) ,
32543269 } ) ) ,
32553270 {
32563271 slug : "ultracode-model" ,
@@ -3392,6 +3407,59 @@ describe("OrchestratorMcpService provider resolution", () => {
33923407 } ) ,
33933408 ) ;
33943409
3410+ it . effect ( "validates options against the model a target names by alias" , ( ) =>
3411+ Effect . gen ( function * ( ) {
3412+ const dependencies = Layer . mergeAll (
3413+ NodeServices . layer ,
3414+ NodeCrypto . layer ,
3415+ Layer . mock ( ThreadManagementService . ThreadManagementService ) ( {
3416+ hasReceipt : ( ) => Effect . succeed ( false ) ,
3417+ assertProviderInstanceEnabled : ( ) => Effect . void ,
3418+ getThreadRecords : ( threadId ) =>
3419+ Effect . succeed ( threadId === parentThreadId ? parentProjection ( [ ] ) : childProjection ) ,
3420+ dispatch : ( ) => Effect . die ( "an invalid target must not dispatch" ) ,
3421+ } ) ,
3422+ ServerSettings . layerTest ( ) ,
3423+ providerRegistryLayer ( [
3424+ {
3425+ ...providerSnapshot ( {
3426+ instanceId : codexInstanceId ,
3427+ driver : ProviderDriverKind . make ( "codex" ) ,
3428+ } ) ,
3429+ models : [
3430+ {
3431+ slug : "gpt-5.4" ,
3432+ name : "gpt-5.4" ,
3433+ aliases : [ "gpt" ] ,
3434+ isCustom : false ,
3435+ capabilities : {
3436+ optionDescriptors : [ { id : "fastMode" , label : "Fast" , type : "boolean" } ] ,
3437+ } ,
3438+ } ,
3439+ ] ,
3440+ } ,
3441+ ] ) ,
3442+ adapterRegistryLayer ( [ codexInstanceId ] ) ,
3443+ Layer . mock ( ProjectService . ProjectService ) ( { } ) ,
3444+ Layer . mock ( SecretRequests . SecretRequests ) ( { } ) ,
3445+ Layer . mock ( RemoteDelegation . RemoteDelegation ) ( { } ) ,
3446+ Layer . mock ( ScheduledTaskService . ScheduledTaskService ) ( { } ) ,
3447+ ) ;
3448+ const error = yield * Effect . gen ( function * ( ) {
3449+ const service = yield * OrchestratorMcpService . OrchestratorMcpService ;
3450+ return yield * service
3451+ . delegateTask ( scope , {
3452+ task : "Review the change." ,
3453+ target : yield * decodeTarget ( { model : "GPT" , options : { bogus : "x" } } ) ,
3454+ mode : "async" ,
3455+ } )
3456+ . pipe ( Effect . flip ) ;
3457+ } ) . pipe ( Effect . provide ( layerOrchestratorService . pipe ( Layer . provide ( dependencies ) ) ) ) ;
3458+ assert . equal ( error . code , "invalid_request" ) ;
3459+ assert . include ( error . message , "Unknown option bogus" ) ;
3460+ } ) ,
3461+ ) ;
3462+
33953463 describe ( "resolveRuntimeMode" , ( ) => {
33963464 const muse = {
33973465 modelSelection : { instanceId : ProviderInstanceId . make ( "muse" ) , model : "muse-model" } ,
0 commit comments