Skip to content

Commit 5e23afa

Browse files
authored
Merge branch 'main' into perf/streaming-thread-projection
2 parents e310099 + cd096b9 commit 5e23afa

514 files changed

Lines changed: 21268 additions & 5287 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

‎.github/ISSUE_TEMPLATE/bug_report.yml‎

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,6 +9,7 @@ body:
99
attributes:
1010
value: |
1111
Use this form for broken behavior, regressions, crashes, or reliability problems.
12+
Feature requests belong in [Discussions](https://github.com/pingdotgg/t3code/discussions/categories/ideas).
1213
Search existing issues first and keep the report focused on one problem.
1314
1415
- type: checkboxes

‎.github/ISSUE_TEMPLATE/config.yml‎

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
blank_issues_enabled: false
2+
contact_links:
3+
- name: Feature request
4+
url: https://github.com/pingdotgg/t3code/discussions/categories/ideas
5+
about: Suggest an improvement or new capability in Discussions.

‎.github/ISSUE_TEMPLATE/feature_request.yml‎

Lines changed: 0 additions & 102 deletions
This file was deleted.

‎.github/pr-assets/6424-after.svg‎

Lines changed: 1 addition & 0 deletions
Loading

‎.github/pr-assets/6424-before.svg‎

Lines changed: 1 addition & 0 deletions
Loading

‎.github/pr-assets/6503-after.svg‎

Lines changed: 1 addition & 0 deletions
Loading

‎.github/workflows/mobile-showcase-screenshots.yml‎

Lines changed: 23 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,19 @@ on:
2121
- both
2222
- dark
2323
- light
24+
theme:
25+
description: Palette to capture (all multiplies the run by six)
26+
required: true
27+
default: t3-code
28+
type: choice
29+
options:
30+
- t3-code
31+
- t3-chat
32+
- grove
33+
- ocean
34+
- ember
35+
- iris
36+
- all
2437

2538
permissions:
2639
contents: read
@@ -33,7 +46,9 @@ jobs:
3346
name: iPhone 6.9, iPhone 6.5, and iPad 13
3447
if: inputs.platform == 'all' || inputs.platform == 'ios'
3548
runs-on: blacksmith-12vcpu-macos-26
36-
timeout-minutes: 60
49+
# Capturing every palette multiplies the device matrix by six, and only the
50+
# one native build is shared between them.
51+
timeout-minutes: ${{ inputs.theme == 'all' && 300 || 60 }}
3752
steps:
3853
- name: Checkout
3954
uses: actions/checkout@v6
@@ -62,10 +77,10 @@ jobs:
6277
"$vp_pnpm_bin/pnpm" --version
6378
6479
- name: Capture iOS showcase
65-
run: pnpm screenshots:mobile --platform ios --appearance "${{ inputs.appearance }}"
80+
run: pnpm screenshots:mobile --platform ios --appearance "${{ inputs.appearance }}" --theme "${{ inputs.theme }}"
6681

6782
- name: Validate App Store Connect assets
68-
run: pnpm screenshots:mobile --platform ios --appearance "${{ inputs.appearance }}" --validate-only
83+
run: pnpm screenshots:mobile --platform ios --appearance "${{ inputs.appearance }}" --theme "${{ inputs.theme }}" --validate-only
6984

7085
- name: Upload iOS screenshots
7186
if: always()
@@ -80,7 +95,9 @@ jobs:
8095
name: Android phone, 7-inch tablet, and 10-inch tablet
8196
if: inputs.platform == 'all' || inputs.platform == 'android'
8297
runs-on: blacksmith-16vcpu-ubuntu-2404
83-
timeout-minutes: 60
98+
# Capturing every palette multiplies the device matrix by six, and only the
99+
# one native build is shared between them.
100+
timeout-minutes: ${{ inputs.theme == 'all' && 300 || 60 }}
84101
env:
85102
T3_SHOWCASE_ANDROID_ABI: x86_64
86103
steps:
@@ -137,10 +154,10 @@ jobs:
137154
cores: 8
138155
ram-size: 4096M
139156
disable-animations: false
140-
script: pnpm screenshots:mobile --platform android --appearance "${{ inputs.appearance }}"
157+
script: pnpm screenshots:mobile --platform android --appearance "${{ inputs.appearance }}" --theme "${{ inputs.theme }}"
141158

142159
- name: Validate Google Play assets
143-
run: pnpm screenshots:mobile --platform android --appearance "${{ inputs.appearance }}" --validate-only
160+
run: pnpm screenshots:mobile --platform android --appearance "${{ inputs.appearance }}" --theme "${{ inputs.theme }}" --validate-only
144161

145162
- name: Upload Android screenshots
146163
if: always()

‎.github/workflows/publish-aur.yml‎

Lines changed: 65 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,65 @@
1+
name: Publish AUR package
2+
3+
# See packaging/aur/README.md.
4+
5+
on:
6+
workflow_call:
7+
inputs:
8+
release_tag:
9+
required: true
10+
type: string
11+
pkgrel:
12+
required: false
13+
default: "1"
14+
type: string
15+
secrets:
16+
AUR_SSH_PRIVATE_KEY:
17+
required: true
18+
workflow_dispatch:
19+
inputs:
20+
release_tag:
21+
description: "Release tag to publish"
22+
required: true
23+
type: string
24+
pkgrel:
25+
description: "Arch package release override"
26+
required: false
27+
default: "1"
28+
type: string
29+
30+
permissions:
31+
contents: read
32+
33+
concurrency:
34+
group: publish-aur
35+
cancel-in-progress: false
36+
37+
jobs:
38+
publish:
39+
name: Validate and publish
40+
runs-on: blacksmith-8vcpu-ubuntu-2404
41+
timeout-minutes: 30
42+
container:
43+
image: archlinux:base-devel
44+
45+
steps:
46+
- name: Install Arch packaging tools
47+
run: pacman -Syu --noconfirm --needed git github-cli jq namcap openssh sudo
48+
49+
- name: Checkout packaging sources
50+
uses: actions/checkout@v6
51+
52+
- name: Create unprivileged build user
53+
run: |
54+
useradd --create-home builder
55+
install -Dm0440 /dev/stdin /etc/sudoers.d/builder <<'EOF'
56+
builder ALL=(root) NOPASSWD: /usr/bin/pacman
57+
EOF
58+
59+
- name: Validate and publish package sources
60+
env:
61+
GH_TOKEN: ${{ github.token }}
62+
RELEASE_TAG: ${{ inputs.release_tag }}
63+
PKGREL: ${{ inputs.pkgrel || '1' }}
64+
AUR_SSH_PRIVATE_KEY: ${{ secrets.AUR_SSH_PRIVATE_KEY }}
65+
run: packaging/aur/scripts/release.sh

‎.github/workflows/release.yml‎

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -856,6 +856,16 @@ jobs:
856856
fail_on_unmatched_files: true
857857
token: ${{ github.token }}
858858

859+
publish_aur:
860+
name: Publish AUR package
861+
needs: [preflight, release]
862+
if: ${{ !failure() && !cancelled() && needs.preflight.result == 'success' && needs.release.result == 'success' }}
863+
uses: ./.github/workflows/publish-aur.yml
864+
with:
865+
release_tag: ${{ needs.preflight.outputs.tag }}
866+
secrets:
867+
AUR_SSH_PRIVATE_KEY: ${{ secrets.AUR_SSH_PRIVATE_KEY }}
868+
859869
deploy_web:
860870
name: Deploy hosted web app
861871
needs: [preflight, relay_public_config, release]
Lines changed: 82 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,82 @@
1+
---
2+
title: UI Consistency
3+
model: claude-opus-5
4+
effort: high
5+
input: full_diff
6+
tools:
7+
- browse_code
8+
- git_tools
9+
- github_api_read_only
10+
- modify_pr
11+
include:
12+
- "apps/web/src/**/*.ts"
13+
- "apps/web/src/**/*.tsx"
14+
- "apps/web/src/**/*.css"
15+
conclusion: failure
16+
showToolCalls: true
17+
---
18+
19+
# UI consistency review
20+
21+
Review changed web UI code and directly affected call sites for consistency with the shared component system, Tailwind ownership, and the behavioral constraints below. Apply these rules when a pull request creates, moves, or modifies controls or styling. Do not demand unrelated repository-wide cleanup.
22+
23+
The goal is not to minimize CSS or class counts at any cost. The goal is to put each behavior in the smallest correct owner while preserving interaction, theming, accessibility, layout, and browser behavior.
24+
25+
## Shared controls and variants
26+
27+
- Prefer the core UI primitives in `apps/web/src/components/ui` over native controls or locally reconstructed primitives. In ordinary product UI, a raw `<button>` that recreates `Button`, a raw input that recreates `Input` or `InputGroup`, or a local trigger that recreates `Select`, `Toggle`, or `Menu` is a concrete finding.
28+
- Do not flag raw elements that intentionally implement a semantic row, tab, resize handle, swatch, image target, editor surface, or another interaction whose behavior or geometry differs from the core primitive.
29+
- When multiple call sites repeat the same durable geometry or treatment, prefer a named primitive size or variant. Examples include compact controls, micro icon actions, muted ghost actions, and glass actions. Keep contextual layout, width, and color at the call site.
30+
- Flag large call-site class strings that override a primitive's core height, radius, padding, focus ring, cursor, hit target, or base state colors. Prefer extending the primitive contract when the same pattern is genuinely shared.
31+
- Preserve accessibility and interaction semantics during migrations: focus-visible rings, disabled behavior, loading state, keyboard behavior, pointer cursor, `aria-*`, Base UI or Radix render/close props, and coarse-pointer hit targets.
32+
- Do not require tests for a tiny visual-only class migration. Require focused tests when primitive composition changes behavior, prop forwarding, state transitions, keyboard handling, or width/defaulting logic.
33+
34+
## CSS and Tailwind ownership
35+
36+
- Ordinary one-owner presentation belongs in the owning TS or TSX module as static Tailwind classes or owner-level CSS variables. Examples include local geometry, spacing, typography, backgrounds, borders, simple vendor pseudo-elements, and component-only positioning.
37+
- Keep global CSS when it is genuinely reusable or behaviorally complex: generated markdown or imperative DOM, custom elements and shadow roots, masks, shared or complex pseudo-elements, animations, glass composition, runtime theme variables, safe-area calculations, scrollbar-lane preservation, Electron drag regions, and browser/vendor integration. Simple owner-local pseudo-elements may still belong in the owning module.
38+
- Before calling a selector dead, trace literal, dynamic, generated, imperative, test, custom-element, and shadow-root consumers. Search both the emitted class string and any class-valued field names through their final DOM sink. A helper returning a class is not proof that it is rendered, and a missed downstream property read can make a deletion unsafe.
39+
- Flag duplicate declarations only after comparing cascade layer, selector specificity, inheritance, runtime theme scope, media/variant scope, and the final owning element. Textually identical declarations are not necessarily behaviorally redundant.
40+
- When moving CSS into Tailwind, preserve selector scope and cascade ownership. A utility at the owner is preferable to a fragile global override that depends on stylesheet order.
41+
- Do not request moving complex global behavior into arbitrary Tailwind merely to reduce `index.css`. Do not preserve ordinary one-owner CSS merely because it already exists globally.
42+
43+
## Themes and generated CSS
44+
45+
- Use the project variants for theme-only declarations:
46+
- dark-only declarations use `@variant dark`;
47+
- light-only declarations use `@variant light`;
48+
- raw `.dark` should remain only in the `dark` and `light` custom-variant definitions.
49+
- Preserve custom themes and runtime token bridges. Removing a variable or selector is safe only when all runtime, inspector, generated, and theme-palette consumers are accounted for.
50+
- Inspect emitted production CSS after unusual variants, arbitrary selectors, nested pseudo-elements, or attribute matching. Source syntax that looks valid is insufficient.
51+
- Flag malformed or empty emitted selectors such as empty `:is()` or `:not(:is())`, selector branches that can never match their own class attribute, and transformations that silently drop the intended rule.
52+
- Prefer source-level logic over clever selectors when behavior depends on consumer-provided class strings. Preserve `MenuPopup`'s current defaulting contract: a string `className` containing a `w-*`, `min-w-*`, or `max-w-*` utility after variant prefixes are stripped suppresses `min-w-32`; a string without one and a functional/non-string `className` keep the default. Arbitrary width values count as width utilities, and the consumer class must be merged last so it retains control. Do not replace this with a raw class-attribute substring selector.
53+
- Do not fail solely because a valid emitted selector is verbose or because a source rule uses an intentional custom property.
54+
55+
## Scroll and virtualized lists
56+
57+
- `ScrollArea` owns and masks its Base UI viewport. A virtualized list usually owns a native scrolling element and cannot automatically reuse viewport-specific `ScrollArea` behavior.
58+
- Repeated native or virtualized overflow fades should use the shared virtualized-scroll-fade contract rather than component-named mask selectors.
59+
- Preserve runtime top and bottom overflow state. Do not replace dynamic fades with an always-on static mask.
60+
- Preserve fade geometry and keep the native scrollbar lane opaque so the track and thumb stay visible and usable. A visually similar mask that fades the scrollbar is a regression.
61+
- Verify actual scroll behavior when changing virtualizers, masks, overflow ownership, or scrollbar selectors. Source-level class comparison is not enough.
62+
63+
## Visual and layout preservation
64+
65+
- Preserve responsive geometry, titlebar insets, panel and inline-preview modes, desktop Electron layout, light and dark contrast, clipping, radius, and composable shadows.
66+
- For meaningful visual changes, prefer available real-app evidence using the actual component and state. A mock recreation does not validate the real component. Light and dark evidence is useful when theme-sensitive styles change, but missing or inaccessible evidence alone is not a finding; report only a concrete regression supported by the diff, code, or available artifacts.
67+
- Do not treat a screenshot as proof of keyboard, overflow, scrollbar, responsive, or runtime-theme behavior. Pair visual evidence with source, computed-style, emitted-CSS, or interaction checks as appropriate.
68+
- Be alert to shared primitive color indirection. When a primitive routes icon color through a CSS variable, ensure migrated contextual icons retain their intended tone, including pressed and disabled states.
69+
70+
## Change discipline
71+
72+
- Review the pull request's changed scope and directly affected consumers. Do not turn a focused PR into a demand for unrelated legacy cleanup.
73+
- Prefer the smallest durable contract over a component-specific workaround or a broad abstraction with one consumer.
74+
- Preserve intentional exceptions and comments that explain browser, virtualizer, theme, or Electron constraints.
75+
- If a proposed cleanup cannot prove ownership or semantic equivalence, ask for evidence or leave it unchanged rather than guessing.
76+
- Select verification gates according to the changed behavior: typecheck or focused tests for typing and interaction contracts, production build and emitted-CSS inspection for Tailwind or selector transformations, and real-app evidence for meaningful visual behavior when available. These gates are complementary when applicable, but do not require every gate for tiny visual-only migrations or fail solely because an artifact the configured tools cannot produce is absent.
77+
78+
## Reporting
79+
80+
Report only concrete violations introduced by changed lines or behavior, plus pre-existing behavior that the patch directly makes relevant or worsens. Touching a large file does not make unrelated retained issues reportable. Prefer precise inline comments on the smallest relevant line range. Explain the broken behavior or ownership rule, not merely the preferred syntax, and state the smallest expected fix. A clear consistency or regression risk may fail the check. Do not fail for optional aesthetic preferences, harmless class ordering, or unrelated legacy code.
81+
82+
This check defaults to failure. When there are no findings, stop immediately and make the entire final response exactly `All clear` on one line. Do not add a title, explanation, punctuation, Markdown, JSON, or trailing analysis, and do not continue reasoning after deciding the review is clean.

0 commit comments

Comments
 (0)