55 type ScopedThreadRef ,
66} from "@t3tools/contracts" ;
77import { act , type ReactNode } from "react" ;
8- import { create , type ReactTestRenderer } from "react-test-renderer " ;
9- import { beforeEach , describe , expect , it , vi } from "vite-plus/test" ;
8+ import { createRoot , type Root } from "react-dom/client " ;
9+ import { afterEach , beforeEach , describe , expect , it , vi } from "vite-plus/test" ;
1010
1111import type { RightPanelSurface } from "~/rightPanelStore" ;
1212
@@ -79,7 +79,11 @@ vi.mock("~/rightPanelStore", () => ({
7979} ) ) ;
8080vi . mock ( "~/components/device/DeviceHostUpdates" , ( ) => ( { DeviceHostUpdates : ( ) => null } ) ) ;
8181vi . mock ( "~/components/device/DeviceLoadingView" , ( ) => ( { DeviceLoadingView : ( ) => null } ) ) ;
82- vi . mock ( "~/components/device/DeviceWorkspace" , ( ) => ( { DeviceWorkspace : ( ) => null } ) ) ;
82+ vi . mock ( "~/components/device/DeviceWorkspace" , ( ) => ( {
83+ DeviceWorkspace : ( { onPowerOff } : { onPowerOff : ( ) => void } ) => (
84+ < button onClick = { onPowerOff } > Power off</ button >
85+ ) ,
86+ } ) ) ;
8387vi . mock ( "~/components/preview/PreviewPanelShell" , ( ) => ( {
8488 PreviewPanelShell : ( { children } : { children : ReactNode } ) => children ,
8589} ) ) ;
@@ -118,36 +122,49 @@ const render = (threadRef: ScopedThreadRef, surface = picker) => (
118122 </ PanelHostContext >
119123) ;
120124const mount = async ( threadRef : ScopedThreadRef , surface = picker ) => {
121- const renderer = await act ( async ( ) => create ( render ( threadRef , surface ) ) ) ;
125+ await act ( async ( ) => root . render ( render ( threadRef , surface ) ) ) ;
122126 // Wait for the registered lazy body to load and replace the Suspense fallback.
123127 await act ( async ( ) => {
124128 await import ( "./DeviceSidePanel" ) ;
125129 } ) ;
126- return renderer ;
127130} ;
128131const deferred = ( ) => {
129132 let settle ! : ( result : CommandResult ) => void ;
130133 const promise = new Promise < CommandResult > ( ( resolve ) => ( settle = resolve ) ) ;
131134 return { promise, settle } ;
132135} ;
133- const startPhone = ( renderer : ReactTestRenderer ) =>
136+ const startPhone = ( ) =>
134137 act ( async ( ) => {
135- renderer . root . findByProps ( { " aria-label" : " Start Phone" } ) . props . onClick ( ) ;
138+ container . querySelector < HTMLButtonElement > ( '[ aria-label=" Start Phone"]' ) ! . click ( ) ;
136139 } ) ;
137- const errors = ( renderer : ReactTestRenderer ) => renderer . root . findAllByProps ( { role : "alert" } ) ;
140+ const errors = ( ) => container . querySelectorAll ( '[ role= "alert"]' ) ;
138141const opened = { _tag : "Success" , value : { hostId : "local" , deviceId : "phone" } } as const ;
139142
140143beforeEach ( ( ) => {
141144 vi . clearAllMocks ( ) ;
142145} ) ;
143146
147+ let root : Root ;
148+ let container : HTMLDivElement ;
149+ beforeEach ( ( ) => {
150+ vi . stubGlobal ( "IS_REACT_ACT_ENVIRONMENT" , true ) ;
151+ container = document . createElement ( "div" ) ;
152+ document . body . append ( container ) ;
153+ root = createRoot ( container ) ;
154+ } ) ;
155+ afterEach ( async ( ) => {
156+ await act ( ( ) => root . unmount ( ) ) ;
157+ container . remove ( ) ;
158+ vi . unstubAllGlobals ( ) ;
159+ } ) ;
160+
144161describe ( "registered Device panel" , ( ) => {
145162 it ( "opens a picked device when the pick settles in the same thread" , async ( ) => {
146163 const pick = deferred ( ) ;
147164 mocks . open . mockReturnValue ( pick . promise ) ;
148- const renderer = await mount ( picking ) ;
165+ await mount ( picking ) ;
149166
150- await startPhone ( renderer ) ;
167+ await startPhone ( ) ;
151168 expect ( mocks . open ) . toHaveBeenCalledWith ( {
152169 environmentId : picking . environmentId ,
153170 input : { threadId : picking . threadId , hostId : "local" , deviceId : "phone" , platform : "ios" } ,
@@ -164,21 +181,23 @@ describe("registered Device panel", () => {
164181
165182 it ( "keeps the next thread's picker usable while an earlier pick is pending" , async ( ) => {
166183 mocks . open . mockReturnValue ( deferred ( ) . promise ) ;
167- const renderer = await mount ( picking ) ;
184+ await mount ( picking ) ;
168185
169- await startPhone ( renderer ) ;
170- await act ( async ( ) => renderer . update ( render ( next ) ) ) ;
186+ await startPhone ( ) ;
187+ await act ( async ( ) => root . render ( render ( next ) ) ) ;
171188
172- expect ( renderer . root . findByProps ( { "aria-label" : "Start Phone" } ) . props . disabled ) . toBe ( false ) ;
189+ expect ( container . querySelector < HTMLButtonElement > ( '[aria-label="Start Phone"]' ) ! . disabled ) . toBe (
190+ false ,
191+ ) ;
173192 } ) ;
174193
175194 it ( "opens a pick that settles after a switch in the thread it started in" , async ( ) => {
176195 const pick = deferred ( ) ;
177196 mocks . open . mockReturnValue ( pick . promise ) ;
178- const renderer = await mount ( picking ) ;
197+ await mount ( picking ) ;
179198
180- await startPhone ( renderer ) ;
181- await act ( async ( ) => renderer . update ( render ( next ) ) ) ;
199+ await startPhone ( ) ;
200+ await act ( async ( ) => root . render ( render ( next ) ) ) ;
182201 await act ( async ( ) => pick . settle ( opened ) ) ;
183202
184203 expect ( mocks . openDevice ) . toHaveBeenCalledExactlyOnceWith ( picking , {
@@ -187,58 +206,60 @@ describe("registered Device panel", () => {
187206 platform : "ios" ,
188207 name : "Phone" ,
189208 } ) ;
190- expect ( renderer . root . findByProps ( { "aria-label" : "Start Phone" } ) . props . disabled ) . toBe ( false ) ;
209+ expect ( container . querySelector < HTMLButtonElement > ( '[aria-label="Start Phone"]' ) ! . disabled ) . toBe (
210+ false ,
211+ ) ;
191212 } ) ;
192213
193214 it ( "hides a failed pick that settles after the panel moved, even back again" , async ( ) => {
194215 const pick = deferred ( ) ;
195216 mocks . open . mockReturnValue ( pick . promise ) ;
196- const renderer = await mount ( picking ) ;
217+ await mount ( picking ) ;
197218
198- await startPhone ( renderer ) ;
199- await act ( async ( ) => renderer . update ( render ( next ) ) ) ;
200- await act ( async ( ) => renderer . update ( render ( picking ) ) ) ;
219+ await startPhone ( ) ;
220+ await act ( async ( ) => root . render ( render ( next ) ) ) ;
221+ await act ( async ( ) => root . render ( render ( picking ) ) ) ;
201222 await act ( async ( ) => pick . settle ( { _tag : "Failure" , cause : new Error ( "boom" ) } ) ) ;
202223
203- expect ( errors ( renderer ) ) . toHaveLength ( 0 ) ;
224+ expect ( errors ( ) ) . toHaveLength ( 0 ) ;
204225 expect ( mocks . openDevice ) . not . toHaveBeenCalled ( ) ;
205226 } ) ;
206227
207228 it ( "does not carry an operation error into another thread" , async ( ) => {
208229 mocks . open . mockResolvedValue ( { _tag : "Failure" , cause : new Error ( "boom" ) } ) ;
209- const renderer = await mount ( picking ) ;
230+ await mount ( picking ) ;
210231
211- await startPhone ( renderer ) ;
212- expect ( errors ( renderer ) ) . toHaveLength ( 1 ) ;
213- await act ( async ( ) => renderer . update ( render ( next ) ) ) ;
232+ await startPhone ( ) ;
233+ expect ( errors ( ) ) . toHaveLength ( 1 ) ;
234+ await act ( async ( ) => root . render ( render ( next ) ) ) ;
214235
215- expect ( errors ( renderer ) ) . toHaveLength ( 0 ) ;
236+ expect ( errors ( ) ) . toHaveLength ( 0 ) ;
216237 } ) ;
217238
218239 it ( "closes a powered-off surface in its own thread after the panel moved" , async ( ) => {
219240 const powerOff = deferred ( ) ;
220241 mocks . close . mockReturnValue ( powerOff . promise ) ;
221- const renderer = await mount ( picking , streaming ) ;
242+ await mount ( picking , streaming ) ;
222243
223244 await act ( async ( ) => {
224- renderer . root . findByProps ( { hostLabel : "This Mac" } ) . props . onPowerOff ( ) ;
245+ container . querySelector < HTMLButtonElement > ( "button" ) ! . click ( ) ;
225246 } ) ;
226247 expect ( mocks . close ) . toHaveBeenCalledWith ( {
227248 environmentId : picking . environmentId ,
228249 input : { threadId : picking . threadId , hostId : "local" , deviceId : "phone" , shutdown : true } ,
229250 } ) ;
230- await act ( async ( ) => renderer . update ( render ( next , streaming ) ) ) ;
251+ await act ( async ( ) => root . render ( render ( next , streaming ) ) ) ;
231252 await act ( async ( ) => powerOff . settle ( opened ) ) ;
232253
233254 expect ( mocks . closeSurface ) . toHaveBeenCalledExactlyOnceWith ( picking , streaming . id ) ;
234255 } ) ;
235256
236257 it ( "closes the surface when a power-off settles in the same thread" , async ( ) => {
237258 mocks . close . mockResolvedValue ( opened ) ;
238- const renderer = await mount ( picking , streaming ) ;
259+ await mount ( picking , streaming ) ;
239260
240261 await act ( async ( ) => {
241- renderer . root . findByProps ( { hostLabel : "This Mac" } ) . props . onPowerOff ( ) ;
262+ container . querySelector < HTMLButtonElement > ( "button" ) ! . click ( ) ;
242263 } ) ;
243264
244265 expect ( mocks . closeSurface ) . toHaveBeenCalledExactlyOnceWith ( picking , streaming . id ) ;
0 commit comments