Skip to content

Commit 5b5a0dd

Browse files
fix(server): save a check that finished before boot when no cache exists
Boot seeded the registry with the boot snapshot when the status cache was missing or mismatched, even when that snapshot was already a completed check, so the following boot upsert saw no change and never wrote the cache. Seed only placeholders of instances still awaiting their first check; completed checks go through the boot upsert, which persists them. AI-assisted; verified with the tests and tools listed above. Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent 0bf13ec commit 5b5a0dd

2 files changed

Lines changed: 31 additions & 22 deletions

File tree

‎apps/server/src/provider/ProviderRegistry.test.ts‎

Lines changed: 24 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1362,10 +1362,6 @@ it.layer(
13621362
cacheDir: config.providerStatusCacheDir,
13631363
instanceId: cachedProvider.instanceId,
13641364
});
1365-
yield* writeProviderStatusCache({
1366-
filePath,
1367-
provider: { ...cachedProvider, status: "ready" },
1368-
});
13691365
const instance = {
13701366
instanceId: cachedProvider.instanceId,
13711367
driverKind: cachedProvider.driver,
@@ -1404,22 +1400,31 @@ it.layer(
14041400
},
14051401
);
14061402

1407-
yield* Effect.gen(function* () {
1408-
const registry = yield* ProviderRegistry.ProviderRegistry;
1409-
assert.strictEqual((yield* registry.getProviders)[0]?.status, failedProvider.status);
1410-
assert.strictEqual(
1411-
(yield* readProviderStatusCache(filePath))?.status,
1412-
failedProvider.status,
1413-
);
1414-
}).pipe(
1415-
Effect.provide(
1416-
ProviderRegistry.layer.pipe(
1417-
Layer.provide(layerInstanceRegistry),
1418-
Layer.provide(layerUnusedMutator),
1403+
// First boot has no cache file; the second has a stale ready one.
1404+
for (const hasCache of [false, true]) {
1405+
if (hasCache) {
1406+
yield* writeProviderStatusCache({
1407+
filePath,
1408+
provider: { ...cachedProvider, status: "ready" },
1409+
});
1410+
}
1411+
yield* Effect.gen(function* () {
1412+
const registry = yield* ProviderRegistry.ProviderRegistry;
1413+
assert.strictEqual((yield* registry.getProviders)[0]?.status, failedProvider.status);
1414+
assert.strictEqual(
1415+
(yield* readProviderStatusCache(filePath))?.status,
1416+
failedProvider.status,
1417+
);
1418+
}).pipe(
1419+
Effect.provide(
1420+
ProviderRegistry.layer.pipe(
1421+
Layer.provide(layerInstanceRegistry),
1422+
Layer.provide(layerUnusedMutator),
1423+
),
14191424
),
1420-
),
1421-
Effect.scoped,
1422-
);
1425+
Effect.scoped,
1426+
);
1427+
}
14231428
}).pipe(
14241429
Effect.provide(
14251430
ServerConfig.layerTest(process.cwd(), {

‎apps/server/src/provider/ProviderRegistry.ts‎

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -396,7 +396,7 @@ export const layer = Layer.effect(
396396

397397
const bootProviders = yield* Effect.forEach(
398398
bootSources,
399-
(source) =>
399+
(source, index) =>
400400
Effect.gen(function* () {
401401
const filePath = yield* resolveProviderStatusCachePath({
402402
cacheDir: config.providerStatusCacheDir,
@@ -406,11 +406,15 @@ export const layer = Layer.effect(
406406
if (fallbackProvider === undefined) {
407407
return undefined;
408408
}
409+
// A completed check is seeded by the boot upsert instead, which persists it.
410+
const placeholder = awaitingBootInstances.has(bootInstances[index]!)
411+
? fallbackProvider
412+
: undefined;
409413
return yield* readProviderStatusCache(filePath).pipe(
410414
Effect.provideService(FileSystem.FileSystem, fileSystem),
411415
Effect.flatMap((cachedProvider) => {
412416
if (cachedProvider === undefined) {
413-
return Effect.succeed(fallbackProvider);
417+
return Effect.succeed(placeholder);
414418
}
415419
const correlation = {
416420
cachedProvider,
@@ -423,7 +427,7 @@ export const layer = Layer.effect(
423427
cachedInstanceId: cachedProvider.instanceId ?? null,
424428
driver: source.driverKind,
425429
cachedDriver: cachedProvider.driver ?? null,
426-
}).pipe(Effect.as(fallbackProvider));
430+
}).pipe(Effect.as(placeholder));
427431
}
428432
return Effect.succeed(hydrateCachedProvider(correlation));
429433
}),

0 commit comments

Comments
 (0)