Skip to content

Commit 5b576b1

Browse files
test(web): preview session sync and device tool update tests run in a real browser
Both were written against react-test-renderer, which apps/web no longer depends on, so typecheck and the unit suite failed on main. Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent d9eb2b6 commit 5b576b1

2 files changed

Lines changed: 23 additions & 13 deletions

File tree

apps/web/src/components/preview/previewSessionSync.test.ts renamed to apps/web/src/components/preview/previewSessionSync.browser.test.ts

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ import {
88
import * as Cause from "effect/Cause";
99
import { AsyncResult, Atom } from "effect/reactivity";
1010
import { act, createElement } from "react";
11-
import { create, type ReactTestRenderer } from "react-test-renderer";
11+
import { createRoot, type Root } from "react-dom/client";
1212
import { afterEach, beforeEach, describe, expect, it, vi } from "vite-plus/test";
1313

1414
// Only the transport is substituted. The hook, atom registry and preview
@@ -76,7 +76,8 @@ import { AppAtomRegistryProvider, appAtomRegistry } from "~/rpc/atomRegistry";
7676
import { previewEnvironment } from "~/state/preview";
7777
import { usePreviewSession } from "./usePreviewSession";
7878

79-
let renderer: ReactTestRenderer | null = null;
79+
let root: Root | null = null;
80+
let container: HTMLDivElement | null = null;
8081
let sequence = 0;
8182
let ref: ScopedThreadRef;
8283

@@ -107,8 +108,10 @@ const result = (
107108
});
108109

109110
async function mount() {
111+
container = document.body.appendChild(document.createElement("div"));
112+
root = createRoot(container);
110113
await act(async () => {
111-
renderer = create(createElement(AppAtomRegistryProvider, null, createElement(SessionSync)));
114+
root!.render(createElement(AppAtomRegistryProvider, null, createElement(SessionSync)));
112115
});
113116
}
114117

@@ -122,8 +125,10 @@ beforeEach(() => {
122125
});
123126

124127
afterEach(async () => {
125-
await act(async () => renderer?.unmount());
126-
renderer = null;
128+
await act(async () => root?.unmount());
129+
root = null;
130+
container?.remove();
131+
container = null;
127132
resetPreviewStateForTests();
128133
vi.unstubAllGlobals();
129134
});

apps/web/src/components/settings/DeviceToolUpdate.test.tsx renamed to apps/web/src/components/settings/DeviceToolUpdate.browser.test.tsx

Lines changed: 13 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ import {
77
} from "@t3tools/contracts";
88
import * as Cause from "effect/Cause";
99
import { act, type ReactNode } from "react";
10-
import { create, type ReactTestRenderer } from "react-test-renderer";
10+
import { createRoot, type Root } from "react-dom/client";
1111
import { afterEach, beforeEach, expect, it, vi } from "vite-plus/test";
1212

1313
const { list } = vi.hoisted(() => ({ list: vi.fn() }));
@@ -86,15 +86,17 @@ const deviceState = {
8686
revision: 1,
8787
} satisfies DeviceServiceState;
8888

89-
let renderer: ReactTestRenderer | undefined;
89+
let root: Root | undefined;
90+
let container: HTMLDivElement | undefined;
9091

9192
beforeEach(() => {
9293
vi.stubGlobal("IS_REACT_ACT_ENVIRONMENT", true);
9394
list.mockReset();
9495
});
9596

9697
afterEach(async () => {
97-
await act(() => renderer?.unmount());
98+
await act(() => root?.unmount());
99+
container?.remove();
98100
vi.unstubAllGlobals();
99101
});
100102

@@ -121,8 +123,10 @@ it.each([
121123
"reports $name as the server describes it, not as a network problem",
122124
async ({ error, message }) => {
123125
list.mockResolvedValue({ _tag: "Failure", cause: Cause.fail(error) });
126+
container = document.body.appendChild(document.createElement("div"));
127+
root = createRoot(container);
124128
await act(() => {
125-
renderer = create(
129+
root!.render(
126130
<DeviceIntegrationControls
127131
environmentId={environmentId}
128132
enabled
@@ -131,12 +135,13 @@ it.each([
131135
);
132136
});
133137

134-
const update = renderer!.root.find(
135-
(node) => node.type === "button" && node.props.children === "Update to v0.12.0",
138+
const update = [...container.querySelectorAll("button")].find(
139+
(button) => button.textContent === "Update to v0.12.0",
136140
);
137-
await act(async () => update.props.onClick());
141+
expect(update).toBeDefined();
142+
await act(async () => update!.click());
138143

139144
expect(list).toHaveBeenCalledWith({ environmentId, input: { updateTool: "hub" } });
140-
expect(renderer!.root.find((node) => node.props.role === "alert").props.children).toBe(message);
145+
expect(container.querySelector('[role="alert"]')?.textContent).toBe(message);
141146
},
142147
);

0 commit comments

Comments
 (0)