|
| 1 | +import { assert, describe, it, vi } from "@effect/vitest"; |
| 2 | +import { |
| 3 | + MessageId, |
| 4 | + ProjectId, |
| 5 | + ProviderInstanceId, |
| 6 | + TextGenerationError, |
| 7 | + ThreadId, |
| 8 | + type OrchestrationV2ConversationMessage, |
| 9 | +} from "@t3tools/contracts"; |
| 10 | +import * as DateTime from "effect/DateTime"; |
| 11 | +import * as Effect from "effect/Effect"; |
| 12 | +import * as Layer from "effect/Layer"; |
| 13 | +import * as Option from "effect/Option"; |
| 14 | + |
| 15 | +import * as ServerSettings from "../serverSettings.ts"; |
| 16 | +import * as TextGeneration from "../textGeneration/TextGeneration.ts"; |
| 17 | +import * as NextMessageSuggestionService from "./NextMessageSuggestionService.ts"; |
| 18 | +import * as ProjectStore from "./ProjectStore.ts"; |
| 19 | +import * as ThreadManagement from "./ThreadManagementService.ts"; |
| 20 | + |
| 21 | +const projectId = ProjectId.make("project:next-message"); |
| 22 | +const threadId = ThreadId.make("thread:next-message"); |
| 23 | +const environmentModel = { instanceId: ProviderInstanceId.make("codex"), model: "gpt-5.4-mini" }; |
| 24 | +const projectModel = { instanceId: ProviderInstanceId.make("claudeAgent"), model: "haiku" }; |
| 25 | +const now = DateTime.makeUnsafe("2026-10-24T00:00:00.000Z"); |
| 26 | + |
| 27 | +function message( |
| 28 | + role: "user" | "assistant", |
| 29 | + text: string, |
| 30 | + options: { readonly streaming?: boolean } = {}, |
| 31 | +): OrchestrationV2ConversationMessage { |
| 32 | + return { |
| 33 | + id: MessageId.make(`message:${role}:${text}`), |
| 34 | + threadId, |
| 35 | + runId: null, |
| 36 | + nodeId: null, |
| 37 | + role, |
| 38 | + text, |
| 39 | + attachments: [], |
| 40 | + streaming: options.streaming ?? false, |
| 41 | + createdBy: role === "user" ? "user" : "agent", |
| 42 | + creationSource: "web", |
| 43 | + createdAt: now, |
| 44 | + updatedAt: now, |
| 45 | + }; |
| 46 | +} |
| 47 | + |
| 48 | +const request = message("user", "Fix the build"); |
| 49 | +const reply = message("assistant", "Fixed it. Should I run the full suite?"); |
| 50 | + |
| 51 | +function makeLayer(input: { |
| 52 | + readonly settings?: Parameters<typeof ServerSettings.layerTest>[0]; |
| 53 | + readonly messages: ReadonlyArray<OrchestrationV2ConversationMessage>; |
| 54 | + readonly worktreePath?: string | null; |
| 55 | + readonly generate?: TextGeneration.TextGeneration["Service"]["generateNextMessageSuggestion"]; |
| 56 | +}) { |
| 57 | + const thread = { messages: input.messages }; |
| 58 | + const generateNextMessageSuggestion = vi.fn( |
| 59 | + input.generate ?? (() => Effect.succeed({ suggestion: "Run the full suite" })), |
| 60 | + ); |
| 61 | + const layer = NextMessageSuggestionService.layer.pipe( |
| 62 | + Layer.provide( |
| 63 | + Layer.mergeAll( |
| 64 | + ServerSettings.layerTest(input.settings), |
| 65 | + Layer.mock(ThreadManagement.ThreadManagementService)({ |
| 66 | + getThreadRecords: (requestedThreadId) => |
| 67 | + requestedThreadId === threadId |
| 68 | + ? Effect.succeed({ |
| 69 | + thread: { projectId, worktreePath: input.worktreePath ?? null }, |
| 70 | + messages: thread.messages, |
| 71 | + } as unknown as Effect.Success< |
| 72 | + ReturnType< |
| 73 | + ThreadManagement.ThreadManagementService["Service"]["getThreadRecords"] |
| 74 | + > |
| 75 | + >) |
| 76 | + : Effect.die(`unexpected thread ${requestedThreadId}`), |
| 77 | + }), |
| 78 | + Layer.mock(ProjectStore.ProjectStoreV2)({ |
| 79 | + get: (requestedProjectId) => |
| 80 | + Effect.succeed( |
| 81 | + requestedProjectId === projectId |
| 82 | + ? Option.some({ workspaceRoot: "/repo" } as never) |
| 83 | + : Option.none(), |
| 84 | + ), |
| 85 | + }), |
| 86 | + Layer.mock(TextGeneration.TextGeneration)({ generateNextMessageSuggestion }), |
| 87 | + ), |
| 88 | + ), |
| 89 | + ); |
| 90 | + return { layer, thread, generateNextMessageSuggestion }; |
| 91 | +} |
| 92 | + |
| 93 | +const suggest = (afterMessageId: MessageId) => |
| 94 | + NextMessageSuggestionService.NextMessageSuggestionService.use((service) => |
| 95 | + service.suggest({ threadId, afterMessageId }), |
| 96 | + ); |
| 97 | + |
| 98 | +const enabled = { |
| 99 | + nextMessageSuggestionsEnabled: true, |
| 100 | + textGenerationModelSelection: environmentModel, |
| 101 | +}; |
| 102 | + |
| 103 | +describe("NextMessageSuggestionService", () => { |
| 104 | + it.effect("refuses to run a model while suggestions are off", () => { |
| 105 | + const { layer, generateNextMessageSuggestion } = makeLayer({ messages: [request, reply] }); |
| 106 | + return Effect.gen(function* () { |
| 107 | + const error = yield* suggest(reply.id).pipe(Effect.flip); |
| 108 | + assert.strictEqual(error.reason, "disabled"); |
| 109 | + assert.strictEqual(generateNextMessageSuggestion.mock.calls.length, 0); |
| 110 | + }).pipe(Effect.provide(layer)); |
| 111 | + }); |
| 112 | + |
| 113 | + it.effect("suggests a reply to the agent from the thread with the project's model", () => { |
| 114 | + const { layer, generateNextMessageSuggestion } = makeLayer({ |
| 115 | + settings: { |
| 116 | + ...enabled, |
| 117 | + projectSettingsOverrides: { [projectId]: { textGenerationModelSelection: projectModel } }, |
| 118 | + }, |
| 119 | + worktreePath: "/repo/.worktrees/fix-build", |
| 120 | + messages: [request, reply], |
| 121 | + }); |
| 122 | + return Effect.gen(function* () { |
| 123 | + assert.deepStrictEqual(yield* suggest(reply.id), { suggestion: "Run the full suite" }); |
| 124 | + const [generation] = generateNextMessageSuggestion.mock.calls[0]!; |
| 125 | + assert.strictEqual(generation.cwd, "/repo/.worktrees/fix-build"); |
| 126 | + assert.deepStrictEqual(generation.modelSelection, projectModel); |
| 127 | + assert.include(generation.threadContext, "USER:\nFix the build"); |
| 128 | + assert.include( |
| 129 | + generation.threadContext, |
| 130 | + "ASSISTANT:\nFixed it. Should I run the full suite?", |
| 131 | + ); |
| 132 | + }).pipe(Effect.provide(layer)); |
| 133 | + }); |
| 134 | + |
| 135 | + it.effect("runs in the project root with the environment's model by default", () => { |
| 136 | + const { layer, generateNextMessageSuggestion } = makeLayer({ |
| 137 | + settings: enabled, |
| 138 | + messages: [request, reply], |
| 139 | + }); |
| 140 | + return Effect.gen(function* () { |
| 141 | + yield* suggest(reply.id); |
| 142 | + const [generation] = generateNextMessageSuggestion.mock.calls[0]!; |
| 143 | + assert.strictEqual(generation.cwd, "/repo"); |
| 144 | + assert.strictEqual(generation.modelSelection.instanceId, environmentModel.instanceId); |
| 145 | + assert.strictEqual(generation.modelSelection.model, environmentModel.model); |
| 146 | + }).pipe(Effect.provide(layer)); |
| 147 | + }); |
| 148 | + |
| 149 | + it.effect("suggests nothing after a reply that is not the thread's latest", () => |
| 150 | + Effect.gen(function* () { |
| 151 | + for (const messages of [ |
| 152 | + [request, reply, message("user", "Also update the docs")], |
| 153 | + [request, reply, message("assistant", "Running the suite", { streaming: true })], |
| 154 | + [request], |
| 155 | + ]) { |
| 156 | + const { layer, generateNextMessageSuggestion } = makeLayer({ settings: enabled, messages }); |
| 157 | + const result = yield* suggest(reply.id).pipe(Effect.provide(layer)); |
| 158 | + assert.deepStrictEqual(result, { suggestion: "" }); |
| 159 | + assert.strictEqual(generateNextMessageSuggestion.mock.calls.length, 0); |
| 160 | + } |
| 161 | + }), |
| 162 | + ); |
| 163 | + |
| 164 | + it.effect("asks once the reply settles when an earlier request found it still streaming", () => { |
| 165 | + const { layer, thread, generateNextMessageSuggestion } = makeLayer({ |
| 166 | + settings: enabled, |
| 167 | + messages: [request, { ...reply, streaming: true }], |
| 168 | + }); |
| 169 | + return Effect.gen(function* () { |
| 170 | + assert.deepStrictEqual(yield* suggest(reply.id), { suggestion: "" }); |
| 171 | + thread.messages = [request, reply]; |
| 172 | + assert.deepStrictEqual(yield* suggest(reply.id), { suggestion: "Run the full suite" }); |
| 173 | + assert.strictEqual(generateNextMessageSuggestion.mock.calls.length, 1); |
| 174 | + }).pipe(Effect.provide(layer)); |
| 175 | + }); |
| 176 | + |
| 177 | + it.effect("asks the model once per reply however many clients request it", () => { |
| 178 | + const { layer, thread, generateNextMessageSuggestion } = makeLayer({ |
| 179 | + settings: enabled, |
| 180 | + messages: [request, reply], |
| 181 | + }); |
| 182 | + return Effect.gen(function* () { |
| 183 | + yield* Effect.all([suggest(reply.id), suggest(reply.id)], { concurrency: "unbounded" }); |
| 184 | + yield* suggest(reply.id); |
| 185 | + assert.strictEqual(generateNextMessageSuggestion.mock.calls.length, 1); |
| 186 | + |
| 187 | + const nextReply = message("assistant", "The suite passes."); |
| 188 | + thread.messages = [...thread.messages, message("user", "Yes"), nextReply]; |
| 189 | + yield* suggest(nextReply.id); |
| 190 | + assert.strictEqual(generateNextMessageSuggestion.mock.calls.length, 2); |
| 191 | + }).pipe(Effect.provide(layer)); |
| 192 | + }); |
| 193 | + |
| 194 | + it.effect("reports a provider failure and asks again on the next request", () => { |
| 195 | + const { layer, generateNextMessageSuggestion } = makeLayer({ |
| 196 | + settings: enabled, |
| 197 | + messages: [request, reply], |
| 198 | + generate: () => |
| 199 | + Effect.fail( |
| 200 | + new TextGenerationError({ |
| 201 | + operation: "generateNextMessageSuggestion", |
| 202 | + detail: "Codex exited with code 1.", |
| 203 | + }), |
| 204 | + ), |
| 205 | + }); |
| 206 | + return Effect.gen(function* () { |
| 207 | + const error = yield* suggest(reply.id).pipe(Effect.flip); |
| 208 | + assert.strictEqual(error.reason, "generation-failed"); |
| 209 | + assert.strictEqual(error.threadId, threadId); |
| 210 | + yield* suggest(reply.id).pipe(Effect.flip); |
| 211 | + assert.strictEqual(generateNextMessageSuggestion.mock.calls.length, 2); |
| 212 | + }).pipe(Effect.provide(layer)); |
| 213 | + }); |
| 214 | +}); |
0 commit comments