Skip to content

Commit 57dc788

Browse files
committed
fix(client-runtime): order pending questions by creation time
1 parent 4c5137d commit 57dc788

2 files changed

Lines changed: 14 additions & 0 deletions

File tree

‎packages/client-runtime/src/state/threadRequests.test.ts‎

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -281,6 +281,18 @@ describe("pending question queues", () => {
281281
]);
282282
};
283283

284+
it("orders pending questions by creation time, not projection order", () => {
285+
expect(
286+
queue([
287+
{ id: "newer", createdAt: 2 },
288+
{ id: "older", createdAt: 1 },
289+
]),
290+
).toEqual([
291+
["older", 0, 2],
292+
["newer", 1, 2],
293+
]);
294+
});
295+
284296
it("counts simultaneous single-question requests as one queue", () => {
285297
const ids = ["a", "b", "c", "d", "e"];
286298
expect(queue(ids.map((id, index) => ({ id, createdAt: index })))).toEqual(

‎packages/client-runtime/src/state/threadRequests.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -179,6 +179,8 @@ export function derivePendingThreadRequests(
179179
});
180180
}
181181

182+
// Consumers activate the first entry; queue positions count in creation order.
183+
userInputs.sort((left, right) => left.createdAt.localeCompare(right.createdAt));
182184
return { approvals, userInputs };
183185
}
184186

0 commit comments

Comments
 (0)