Skip to content

Commit 57d3363

Browse files
committed
fix(web): keep fit-width PDF sizing stable during reloads
1 parent 57488dd commit 57d3363

2 files changed

Lines changed: 9 additions & 1 deletion

File tree

‎apps/web/src/components/files/AttachmentFilePreview.browser.test.tsx‎

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2464,11 +2464,19 @@ it("keeps workspace PDF scroll and zoom after reloads and clamps them when the d
24642464
await screen.rerender(preview(urls.original, "five"));
24652465
await vi.waitFor(() => expect(screen.container.textContent).toContain("1 / 3 pages"));
24662466
await screen.getByRole("button", { name: "Fit width", exact: true }).click();
2467+
await screen.getByRole("button", { name: "Next page", exact: true }).click();
2468+
await vi.waitFor(() => expect(screen.container.textContent).toContain("2 / 3 pages"));
2469+
await scrollTo({ top: region().scrollTop + 30 });
2470+
const fitOffset = offset(2);
24672471
await screen.rerender(preview(urls.original, "six"));
24682472
await vi.waitFor(() => {
24692473
expect(screen.container.textContent).toContain("Fit width");
24702474
expect(region().scrollLeft).toBe(0);
2475+
expect(screen.container.textContent).toContain("2 / 3 pages");
2476+
expect(offset(2)).toBeCloseTo(fitOffset, 0);
24712477
});
2478+
await screen.getByRole("button", { name: "Previous page", exact: true }).click();
2479+
await vi.waitFor(() => expect(screen.container.textContent).toContain("1 / 3 pages"));
24722480
await screen.getByRole("button", { name: "Zoom in", exact: true }).click();
24732481
const firstPageZoom = screen.container.textContent!.match(/\d+%/)![0];
24742482
await screen.rerender(preview(urls.original, "seven"));

‎apps/web/src/components/files/PdfViewer.tsx‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -409,7 +409,7 @@ export default function PdfViewer(props: {
409409
role="region"
410410
aria-label={props.title}
411411
tabIndex={0}
412-
className="relative min-h-0 min-w-0 w-full flex-1 overflow-auto bg-muted/40"
412+
className="relative min-h-0 min-w-0 w-full flex-1 overflow-auto scrollbar-gutter-stable bg-muted/40"
413413
onScroll={(event) => {
414414
const top = event.currentTarget.scrollTop;
415415
setScrollTop(top);

0 commit comments

Comments
 (0)