Skip to content

Commit 573d3e2

Browse files
committed
fix(usage): retry a failed Antigravity cache write on the next scan
A failed write restored the dirty flag, but a write was only scheduled when a scan changed the cache, so an unchanged history stayed unsaved. A write is now scheduled whenever the cache is dirty.
1 parent c3cf6d5 commit 573d3e2

2 files changed

Lines changed: 41 additions & 4 deletions

File tree

‎apps/server/src/provider/Drivers/AntigravityUsage.ts‎

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -175,10 +175,9 @@ const make = Effect.gen(function* () {
175175
Effect.provideService(FileSystem.FileSystem, fileSystem),
176176
Effect.provideService(Path.Path, path),
177177
);
178-
if (result.cacheChanged) {
179-
cacheDirty = true;
180-
yield* schedulePersist;
181-
}
178+
// Also after an unchanged scan, so a failed write is retried.
179+
if (result.cacheChanged) cacheDirty = true;
180+
if (cacheDirty) yield* schedulePersist;
182181
const scanned: ProviderUsageScan[] = [];
183182
for (const dir of conversationDirs) {
184183
const exists = yield* fileSystem

‎apps/server/src/usage/UsageService.test.ts‎

Lines changed: 38 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -622,6 +622,44 @@ describe("UsageService", () => {
622622
}).pipe(Effect.scoped),
623623
);
624624

625+
it.live("retries a failed Antigravity cache write on the next scan", () =>
626+
Effect.gen(function* () {
627+
const { settings, home } = yield* setup;
628+
const conversations = NodePath.join(home, "antigravity", "conversations");
629+
yield* Effect.promise(async () => {
630+
await NodeFSP.mkdir(conversations, { recursive: true });
631+
const db = new NodeSqlite.DatabaseSync(NodePath.join(conversations, "session-1.db"));
632+
db.exec("CREATE TABLE gen_metadata (idx INTEGER, data BLOB)");
633+
db.prepare("INSERT INTO gen_metadata VALUES (?, ?)").run(
634+
0,
635+
antigravityGeneration("r-1", 40),
636+
);
637+
db.close();
638+
});
639+
yield* Effect.gen(function* () {
640+
const { stateDir } = yield* ServerConfig.ServerConfig;
641+
const cachePath = NodePath.join(stateDir, "usage-antigravity-cache-v1.json");
642+
// A directory where the cache file goes makes the first write fail.
643+
yield* Effect.promise(() => NodeFSP.mkdir(cachePath, { recursive: true }));
644+
const service = yield* makeWithAntigravity;
645+
yield* service.readSummary(WINDOW);
646+
yield* service.awaitPersisted;
647+
assert.isTrue((yield* Effect.promise(() => NodeFSP.stat(cachePath))).isDirectory());
648+
649+
// The history is unchanged, but the failed write is still owed.
650+
yield* Effect.promise(() => NodeFSP.rm(cachePath, { recursive: true }));
651+
yield* service.readSummary(WINDOW);
652+
yield* service.awaitPersisted;
653+
const saved = JSON.parse(
654+
yield* Effect.promise(() => NodeFSP.readFile(cachePath, "utf8")),
655+
) as { files: Record<string, unknown> };
656+
assert.strictEqual(Object.keys(saved.files).length, 1);
657+
}).pipe(
658+
Effect.provide(layerService({ prefix: "usage-service-antigravity-retry", home, settings })),
659+
);
660+
}).pipe(Effect.scoped),
661+
);
662+
625663
it.live("restores the Cursor account cache after a restart", () =>
626664
Effect.gen(function* () {
627665
const { settings, home } = yield* setup;

0 commit comments

Comments
 (0)