Skip to content

Commit 5594edc

Browse files
Stub Android setters for patched RNS glass-chrome props
The react-native-screens patch adds iOS-only props to the native spec, so Android codegen requires the setters to exist. Ported the no-op overrides from android-dev-pr-3514 (2b34778) to unblock Android EAS builds on this branch. Co-Authored-By: Claude Fable 5 <[email protected]>
1 parent 5a319fd commit 5594edc

2 files changed

Lines changed: 50 additions & 11 deletions

File tree

‎patches/[email protected]‎

Lines changed: 40 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,42 @@
1+
diff --git a/android/src/main/java/com/swmansion/rnscreens/ScreenStackHeaderConfigViewManager.kt b/android/src/main/java/com/swmansion/rnscreens/ScreenStackHeaderConfigViewManager.kt
2+
index 03d8d9f3a5c403c93282d53cbacf1a339e877e85..54d5eabc6c8a408e711a5be97286fdbb8ab1c461 100644
3+
--- a/android/src/main/java/com/swmansion/rnscreens/ScreenStackHeaderConfigViewManager.kt
4+
+++ b/android/src/main/java/com/swmansion/rnscreens/ScreenStackHeaderConfigViewManager.kt
5+
@@ -103,6 +103,34 @@ class ScreenStackHeaderConfigViewManager :
6+
config.setTitle(title)
7+
}
8+
9+
+ // The t3 patch adds these iOS glass-chrome props to the native spec; they have
10+
+ // no Android implementation, but the codegen-generated interface requires the
11+
+ // setters to exist. No-ops keep the Android build compiling.
12+
+ override fun setSubtitle(
13+
+ config: ScreenStackHeaderConfig,
14+
+ subtitle: String?,
15+
+ ) = Unit
16+
+
17+
+ override fun setLargeSubtitle(
18+
+ config: ScreenStackHeaderConfig,
19+
+ largeSubtitle: String?,
20+
+ ) = Unit
21+
+
22+
+ override fun setNavigationItemStyle(
23+
+ config: ScreenStackHeaderConfig,
24+
+ navigationItemStyle: String?,
25+
+ ) = Unit
26+
+
27+
+ override fun setHeaderCenterBarButtonItems(
28+
+ config: ScreenStackHeaderConfig,
29+
+ headerCenterBarButtonItems: ReadableArray?,
30+
+ ) = Unit
31+
+
32+
+ override fun setHeaderToolbarItems(
33+
+ config: ScreenStackHeaderConfig,
34+
+ headerToolbarItems: ReadableArray?,
35+
+ ) = Unit
36+
+
37+
override fun setTitleFontFamily(
38+
config: ScreenStackHeaderConfig,
39+
titleFontFamily: String?,
140
diff --git a/ios/RNSBarButtonItem.h b/ios/RNSBarButtonItem.h
241
index ea5325ea8d17b1ddfa790ff8dab48ce83142d4d3..acd2fd7ceb7162ed300abc4d3c9f0c24f4d63898 100644
342
--- a/ios/RNSBarButtonItem.h
@@ -1067,7 +1106,7 @@ index b7568ecfebd4f4420f2a8d3fec5184d7fc728dd1..41ca1f273f0175929e73105faa463978
10671106
onPressHeaderBarButtonMenuItem?: CT.DirectEventHandler<OnPressHeaderBarButtonMenuItemEvent> | undefined;
10681107
synchronousShadowStateUpdatesEnabled?: CT.WithDefault<boolean, false>;
10691108
diff --git a/lib/typescript/types.d.ts b/lib/typescript/types.d.ts
1070-
index 3b384e03891e38e936f370372a682d73440e7ec2..1e3a966806c8b8b312f75fb367f758efe49dde9d 100644
1109+
index 3b384e03891e38e936f370372a682d73440e7ec2..861ffed850e90f27916c427853b503dbe6ee9840 100644
10711110
--- a/lib/typescript/types.d.ts
10721111
+++ b/lib/typescript/types.d.ts
10731112
@@ -10,6 +10,7 @@ export type SearchBarCommands = {

‎pnpm-lock.yaml‎

Lines changed: 10 additions & 10 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)