@@ -657,6 +657,88 @@ it.layer(layerTest)("ProjectionStoreV2", (it) => {
657657 assert . deepEqual ( recovery ?. restartCancelledBackgroundWork , work ) ;
658658 } ) ,
659659 ) ;
660+ it . effect ( "command reads skip finished leaf nodes of finished runs" , ( ) =>
661+ Effect . gen ( function * ( ) {
662+ const store = yield * ProjectionStore . ProjectionStoreV2 ;
663+ const now = yield * DateTime . now ;
664+ const threadId = yield * addRolledBackRecoveryCandidate ( "settled-leaf-nodes" ) ;
665+ const settledRun = ( yield * store . getThreadProjection ( threadId ) ) . runs [ 0 ] ! ;
666+ const activeRun = {
667+ ...settledRun ,
668+ id : RunId . make ( "run:settled-leaf-nodes:active" ) ,
669+ ordinal : 2 ,
670+ userMessageId : MessageId . make ( "message:settled-leaf-nodes:active" ) ,
671+ rootNodeId : NodeId . make ( "node:settled-leaf-nodes:active-root" ) ,
672+ status : "running" as const ,
673+ completedAt : null ,
674+ } ;
675+ yield * store . apply ( {
676+ id : EventId . make ( "event:settled-leaf-nodes:active-run" ) ,
677+ type : "run.created" ,
678+ threadId,
679+ runId : activeRun . id ,
680+ nodeId : activeRun . rootNodeId ,
681+ driver,
682+ providerInstanceId,
683+ occurredAt : now ,
684+ payload : activeRun ,
685+ } ) ;
686+ const nodes = [
687+ [ "settled-root" , settledRun , "root_turn" , "completed" ] ,
688+ [ "settled-tool" , settledRun , "tool_call" , "completed" ] ,
689+ [ "settled-message" , settledRun , "assistant_message" , "failed" ] ,
690+ [ "settled-reasoning" , settledRun , "reasoning" , "cancelled" ] ,
691+ [ "settled-subagent" , settledRun , "subagent" , "completed" ] ,
692+ [ "settled-run-live-tool" , settledRun , "tool_call" , "running" ] ,
693+ [ "active-run-done-tool" , activeRun , "tool_call" , "completed" ] ,
694+ ] as const ;
695+ for ( const [ name , run , kind , status ] of nodes ) {
696+ const id = NodeId . make ( `node:settled-leaf-nodes:${ name } ` ) ;
697+ yield * store . apply ( {
698+ id : EventId . make ( `event:settled-leaf-nodes:${ name } ` ) ,
699+ type : "node.updated" ,
700+ threadId,
701+ runId : run . id ,
702+ nodeId : id ,
703+ driver,
704+ occurredAt : now ,
705+ payload : {
706+ id,
707+ threadId,
708+ runId : run . id ,
709+ rootNodeId : kind === "root_turn" ? id : run . rootNodeId ! ,
710+ parentNodeId : kind === "root_turn" ? null : run . rootNodeId ,
711+ kind,
712+ status,
713+ countsForRun : kind === "root_turn" ,
714+ providerThreadId : null ,
715+ providerTurnId : null ,
716+ nativeItemRef : null ,
717+ runtimeRequestId : null ,
718+ checkpointScopeId : null ,
719+ startedAt : now ,
720+ completedAt : status === "running" ? null : now ,
721+ } ,
722+ } ) ;
723+ }
724+ const nodeNames = ( records : { readonly nodes : ReadonlyArray < { readonly id : string } > } ) =>
725+ records . nodes
726+ . map ( ( node ) => node . id . replace ( "node:settled-leaf-nodes:" , "" ) )
727+ . filter ( ( name ) => nodes . some ( ( [ candidate ] ) => candidate === name ) )
728+ . toSorted ( ) ;
729+
730+ assert . deepEqual (
731+ nodeNames (
732+ yield * store . getThreadRecords ( threadId , [ "nodes" ] , { omitSettledLeafNodes : true } ) ,
733+ ) ,
734+ [ "active-run-done-tool" , "settled-root" , "settled-run-live-tool" , "settled-subagent" ] ,
735+ ) ;
736+ assert . deepEqual (
737+ nodeNames ( yield * store . getThreadRecords ( threadId , [ "nodes" ] ) ) ,
738+ nodes . map ( ( [ name ] ) => name ) . toSorted ( ) ,
739+ ) ;
740+ } ) ,
741+ ) ;
660742 it . effect ( "limits turn-start history to the requested runs, including an empty selection" , ( ) =>
661743 Effect . gen ( function * ( ) {
662744 const store = yield * ProjectionStore . ProjectionStoreV2 ;
0 commit comments