Skip to content

Commit 5501660

Browse files
test(web): chat markdown, timeline, and diff reveal tests pass the strict compiler rules
Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent e2e9b4d commit 5501660

3 files changed

Lines changed: 41 additions & 21 deletions

File tree

‎apps/web/src/components/ChatMarkdown.test.tsx‎

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1228,13 +1228,13 @@ it.each([
12281228
query: "Hidden needle",
12291229
count: 1,
12301230
},
1231-
{ text: ARTIFACT_TEMPLATE_DIRECTIVE, query: "Hello World", count: 1, useTemplate: true },
1232-
{ text: ARTIFACT_TEMPLATE_DIRECTIVE, query: "Document template", count: 1, useTemplate: true },
1233-
{ text: ARTIFACT_TEMPLATE_DIRECTIVE, query: "World Document", count: 0, useTemplate: true },
1234-
{ text: ARTIFACT_TEMPLATE_DIRECTIVE, query: "Use template", count: 0, useTemplate: true },
1231+
{ text: ARTIFACT_TEMPLATE_DIRECTIVE, query: "Hello World", count: 1, withTemplate: true },
1232+
{ text: ARTIFACT_TEMPLATE_DIRECTIVE, query: "Document template", count: 1, withTemplate: true },
1233+
{ text: ARTIFACT_TEMPLATE_DIRECTIVE, query: "World Document", count: 0, withTemplate: true },
1234+
{ text: ARTIFACT_TEMPLATE_DIRECTIVE, query: "Use template", count: 0, withTemplate: true },
12351235
])(
12361236
"highlights the indexed occurrences of $query in $text",
1237-
async ({ text, query, count, lineBreaks, user, useTemplate }) => {
1237+
async ({ text, query, count, lineBreaks, user, withTemplate }) => {
12381238
const skills = [{ name: "test-t3-app", displayName: "T3 App Testing" }];
12391239
const highlights = new Map<string, Set<Range>>();
12401240
vi.stubGlobal(
@@ -1268,7 +1268,7 @@ it.each([
12681268
skills={skills}
12691269
lineBreaks={lineBreaks ?? false}
12701270
parseRawHtml={!user}
1271-
onUseArtifactTemplate={useTemplate ? () => undefined : undefined}
1271+
onUseArtifactTemplate={withTemplate ? () => undefined : undefined}
12721272
/>
12731273
</MarkdownFindContext>
12741274
</div>

‎apps/web/src/components/chat/MessagesTimeline.test.tsx‎

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,7 @@ const legendListTestState = vi.hoisted(() => ({
9393
}));
9494

9595
vi.mock("@legendapp/list/react", async () => {
96+
const { useLayoutEffect } = await import("react");
9697
const legendListTestId = "legend-list";
9798

9899
const LegendList = (props: {
@@ -130,8 +131,10 @@ vi.mock("@legendapp/list/react", async () => {
130131
onScroll?: () => void;
131132
ref?: Ref<LegendListRef>;
132133
}) => {
133-
legendListTestState.data = props.data;
134-
legendListTestState.onScroll = props.onScroll;
134+
useLayoutEffect(() => {
135+
legendListTestState.data = props.data;
136+
legendListTestState.onScroll = props.onScroll;
137+
});
135138
if (props.anchoredEndSpace) {
136139
props.anchoredEndSpace.onSizeChanged?.(240);
137140
props.anchoredEndSpace.onReady?.({ anchorIndex: props.anchoredEndSpace.anchorIndex });
@@ -227,9 +230,8 @@ function matchMedia() {
227230
}
228231

229232
let MessagesTimeline: typeof import("./MessagesTimeline").MessagesTimeline;
230-
let resolvePreviewAnnotationImage: typeof import("./MessagesTimeline").resolvePreviewAnnotationImage;
231233

232-
const ElementStub = class ElementStub {};
234+
const ElementStub = function ElementStub() {};
233235
function stubDomGlobals() {
234236
const classList = {
235237
add: () => {},
@@ -271,7 +273,7 @@ beforeEach(stubDomGlobals);
271273
// Cold transformation of the full chat dependency graph needs extra time on slower CI workers.
272274
beforeAll(async () => {
273275
Object.defineProperty(window, "matchMedia", { value: matchMedia, configurable: true });
274-
({ MessagesTimeline, resolvePreviewAnnotationImage } = await import("./MessagesTimeline"));
276+
({ MessagesTimeline } = await import("./MessagesTimeline"));
275277
}, 120_000);
276278

277279
const ACTIVE_THREAD_ENVIRONMENT_ID = EnvironmentId.make("environment-local");
@@ -790,16 +792,14 @@ describe("MessagesTimeline", () => {
790792
const { readTimelinePosition } = await import("./timelineScrollAnchoring");
791793
const timeline = stubFollowTimeline("environment-local:manual-departure");
792794
const { props } = timeline;
793-
let navigateManually = () => {};
794795
function ChatProbe() {
795796
const [liveFollowEnabled, setLiveFollowEnabled] = useState(true);
796-
navigateManually = () => setLiveFollowEnabled(false);
797797
return (
798798
<MessagesTimeline
799799
{...props}
800800
timelineEntries={[buildUserTimelineEntry("First prompt")]}
801801
liveFollowEnabled={liveFollowEnabled}
802-
onManualNavigation={navigateManually}
802+
onManualNavigation={() => setLiveFollowEnabled(false)}
803803
/>
804804
);
805805
}
@@ -813,7 +813,7 @@ describe("MessagesTimeline", () => {
813813

814814
timeline.scrollTop = 1300;
815815
await act(() => {
816-
navigateManually();
816+
renderer?.root.findByType(MessagesTimeline).props.onManualNavigation?.();
817817
legendListTestState.onScroll?.();
818818
});
819819
await act(() => renderer?.unmount());
@@ -2233,7 +2233,7 @@ describe("MessagesTimeline", () => {
22332233
activityTestState.expandedRuns = true;
22342234
activityTestState.subagentTooltips = true;
22352235
vi.stubGlobal("HTMLElement", ElementStub);
2236-
window.HTMLElement = ElementStub as typeof HTMLElement;
2236+
window.HTMLElement = ElementStub as unknown as typeof HTMLElement;
22372237
vi.stubGlobal("IS_REACT_ACT_ENVIRONMENT", true);
22382238
vi.stubGlobal("requestAnimationFrame", () => 0);
22392239
vi.stubGlobal("cancelAnimationFrame", () => {});

‎apps/web/src/components/diffs/StyledDiffCodeView.test.tsx‎

Lines changed: 25 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ import {
1313
useEffect,
1414
useImperativeHandle,
1515
useLayoutEffect,
16-
useMemo,
1716
useRef,
1817
useState,
1918
type Ref,
@@ -341,7 +340,8 @@ function RevealViewer({
341340
instance.current = undefined;
342341
};
343342
}, [collapsed]);
344-
const handle = useMemo(
343+
useImperativeHandle(
344+
viewerRef,
345345
() => ({
346346
getInstance: () => instance.current,
347347
scrollTo: (target: CodeViewScrollTarget) => {
@@ -356,7 +356,6 @@ function RevealViewer({
356356
}),
357357
[scope],
358358
);
359-
useImperativeHandle(viewerRef, () => handle, [handle]);
360359
return null;
361360
}
362361

@@ -373,12 +372,33 @@ function RevealViews({
373372
}) {
374373
const [viewer, setViewer] = useState<RevealHandle | null>(null);
375374
const [collapsed, setCollapsed] = useState(true);
376-
const selectedRequest = useMemo(() => ({ selectedFile, requestId }), [requestId, selectedFile]);
375+
// The reveal hook cancels pending clicks by scope identity, so a scope object
376+
// must only be replaced when one of its inputs changes.
377+
const [storedRevealScope, setRevealScope] = useState(() => ({
378+
scope,
379+
selectedRequest: { selectedFile, requestId },
380+
}));
381+
let revealScope = storedRevealScope;
382+
if (
383+
revealScope.scope !== scope ||
384+
revealScope.selectedRequest.selectedFile !== selectedFile ||
385+
revealScope.selectedRequest.requestId !== requestId
386+
) {
387+
revealScope = {
388+
scope,
389+
selectedRequest:
390+
revealScope.selectedRequest.selectedFile === selectedFile &&
391+
revealScope.selectedRequest.requestId === requestId
392+
? revealScope.selectedRequest
393+
: { selectedFile, requestId },
394+
};
395+
setRevealScope(revealScope);
396+
}
397+
const { selectedRequest } = revealScope;
377398
useEffect(() => {
378399
if (!selectedRequest.selectedFile || !viewer?.getInstance()) return;
379400
viewer.scrollTo({ type: "item", id: selectedRequest.selectedFile, align: "start" });
380401
}, [selectedRequest, viewer]);
381-
const revealScope = useMemo(() => ({ scope, selectedRequest }), [scope, selectedRequest]);
382402
const requestReveal = useCodeViewFileReveal(viewer, revealScope);
383403
return (
384404
<>

0 commit comments

Comments
 (0)