Repository navigation
Commit 54c2999
committed
fix(web): J and K step the review guide beside a chat
The chat's type-to-focus handler took j and k before the guide tour's listener saw them, so the keys typed into the composer and the tour did not step.
The reader's last click or focus now decides which side gets the keys. The tour marks itself while it is the tab on screen with more than one stop, and type-to-focus leaves unshifted j and k to it when the last click or focus landed in the right panel.
Fixes #183001 parent bed9239 commit 54c2999
3 files changed
Lines changed: 34 additions & 2 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
763 | 763 | | |
764 | 764 | | |
765 | 765 | | |
| 766 | + | |
| 767 | + | |
| 768 | + | |
| 769 | + | |
| 770 | + | |
| 771 | + | |
| 772 | + | |
| 773 | + | |
| 774 | + | |
| 775 | + | |
| 776 | + | |
| 777 | + | |
| 778 | + | |
766 | 779 | | |
767 | 780 | | |
768 | 781 | | |
| |||
8020 | 8033 | | |
8021 | 8034 | | |
8022 | 8035 | | |
| 8036 | + | |
| 8037 | + | |
| 8038 | + | |
| 8039 | + | |
| 8040 | + | |
| 8041 | + | |
| 8042 | + | |
| 8043 | + | |
| 8044 | + | |
| 8045 | + | |
| 8046 | + | |
| 8047 | + | |
| 8048 | + | |
8023 | 8049 | | |
8024 | 8050 | | |
8025 | 8051 | | |
| |||
8044 | 8070 | | |
8045 | 8071 | | |
8046 | 8072 | | |
| 8073 | + | |
8047 | 8074 | | |
8048 | 8075 | | |
8049 | 8076 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
2945 | 2945 | | |
2946 | 2946 | | |
2947 | 2947 | | |
2948 | | - | |
| 2948 | + | |
2949 | 2949 | | |
2950 | 2950 | | |
2951 | 2951 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
117 | 117 | | |
118 | 118 | | |
119 | 119 | | |
120 | | - | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
| 125 | + | |
121 | 126 | | |
122 | 127 | | |
123 | 128 | | |
| |||
0 commit comments