Repository navigation
Commit 544145f
committed
docs(mobile): correct the sidebar divider rationale
The added comment (and the PR body line it mirrors) claimed the sidebar
keeps drawing a hairline under every row, so omitting `showTrailingDivider`
preserved a look. Wrong: the trailing-hairline branch in ThreadListV2Row's
card layout and ThreadListV2PendingRow renders only outside `sidebarPane`
(sidebar cards carry tonal containers; slim rows have no hairline branch at
all), so in this pane the prop is inert and omitting it is a pixel-for-pixel
no-op. The disposition is unchanged — the stamp rides the shared items for
Home's boundary suppression and the sidebar leaves it unused, costing only
the rare divider-only equality invalidation that re-renders identically —
but the reason now matches the code.1 parent d873fae commit 544145f
1 file changed
Lines changed: 8 additions & 8 deletions
File tree
- apps/mobile/src/features/threads
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
910 | 910 | | |
911 | 911 | | |
912 | 912 | | |
913 | | - | |
914 | | - | |
915 | | - | |
916 | | - | |
917 | | - | |
918 | | - | |
919 | | - | |
920 | | - | |
| 913 | + | |
| 914 | + | |
| 915 | + | |
| 916 | + | |
| 917 | + | |
| 918 | + | |
| 919 | + | |
| 920 | + | |
921 | 921 | | |
922 | 922 | | |
923 | 923 | | |
| |||
0 commit comments