Skip to content

Commit 544145f

Browse files
docs(mobile): correct the sidebar divider rationale
The added comment (and the PR body line it mirrors) claimed the sidebar keeps drawing a hairline under every row, so omitting `showTrailingDivider` preserved a look. Wrong: the trailing-hairline branch in ThreadListV2Row's card layout and ThreadListV2PendingRow renders only outside `sidebarPane` (sidebar cards carry tonal containers; slim rows have no hairline branch at all), so in this pane the prop is inert and omitting it is a pixel-for-pixel no-op. The disposition is unchanged — the stamp rides the shared items for Home's boundary suppression and the sidebar leaves it unused, costing only the rare divider-only equality invalidation that re-renders identically — but the reason now matches the code.
1 parent d873fae commit 544145f

1 file changed

Lines changed: 8 additions & 8 deletions

File tree

‎apps/mobile/src/features/threads/ThreadNavigationSidebar.tsx‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -910,14 +910,14 @@ function ThreadNavigationSidebarPane(
910910
case "v2-thread": {
911911
const thread = item.item.thread;
912912
const scopeKey = scopedProjectKey(thread.environmentId, thread.projectId);
913-
// Intentional difference from Home: the sidebar never passed
914-
// `showTrailingDivider` even before this list was recycled, so its
915-
// hairline draws under every row. Home consumes the per-item divider
916-
// stamp to suppress dividers at section boundaries; changing the
917-
// sidebar's long-standing look is out of scope here. The stamp still
918-
// rides on the shared items (Home needs it), which costs this pane
919-
// the occasional divider-only invalidation that re-renders
920-
// identically.
913+
// Intentional difference from Home: the sidebar never passes
914+
// `showTrailingDivider` because its rows render no Home-style row
915+
// hairline at all — card rows carry tonal containers in this pane
916+
// (the hairline branch is !sidebarPane-only) and slim rows have no
917+
// hairline branch. The stamp still rides the shared list items
918+
// because Home's boundary suppression consumes it; the sidebar's
919+
// only cost is the occasional divider-only equality invalidation,
920+
// which re-renders identically.
921921
return (
922922
<ThreadListV2Row
923923
onNewThreadOnBranch={props.onNewThreadOnBranch}

0 commit comments

Comments
 (0)