Skip to content

Commit 5427762

Browse files
committed
fix(web): drop keybinding counts and style the toolbar actions as outline buttons
1 parent a2c84ee commit 5427762

1 file changed

Lines changed: 30 additions & 45 deletions

File tree

‎apps/web/src/components/settings/KeybindingsSettings.tsx‎

Lines changed: 30 additions & 45 deletions
Original file line numberDiff line numberDiff line change
@@ -118,7 +118,7 @@ function KeybindingsSearchInput({
118118
inputRef: RefObject<HTMLInputElement | null>;
119119
}) {
120120
return (
121-
<InputGroup className="w-full sm:w-64">
121+
<InputGroup className="min-w-0 basis-full **:[input]:h-9 sm:basis-0 sm:flex-1 sm:**:[input]:h-8">
122122
<InputGroupAddon>
123123
<SearchIcon aria-hidden className="size-3.5" />
124124
</InputGroupAddon>
@@ -1265,14 +1265,7 @@ interface KeybindingsGroupsProps extends KeybindingRowActions {
12651265
function KeybindingsGroups(props: KeybindingsGroupsProps) {
12661266
const { groups, anchorIds, savingCommand, ...rowActions } = props;
12671267
return groups.map((group) => (
1268-
<SettingsSection
1269-
key={group.id}
1270-
id={`keybindings-${group.id}`}
1271-
title={group.title}
1272-
headerAction={
1273-
<span className="text-[11px] text-muted-foreground tabular-nums">{group.rows.length}</span>
1274-
}
1275-
>
1268+
<SettingsSection key={group.id} id={`keybindings-${group.id}`} title={group.title}>
12761269
{group.rows.map((row) => (
12771270
<KeybindingSettingsRow
12781271
key={row.id}
@@ -1493,44 +1486,36 @@ export function KeybindingsSettingsPanel() {
14931486
<SettingsPageContainer>
14941487
<SettingsSection
14951488
{...searchableSetting("keybindings")}
1496-
headerAction={
1497-
<span className="flex items-center gap-1 text-[11px] text-muted-foreground tabular-nums">
1498-
{rows.length} {rows.length === 1 ? "binding" : "bindings"}
1499-
{!isElectron ? <BrowserKeybindingNotice /> : null}
1500-
</span>
1501-
}
1489+
headerAction={!isElectron ? <BrowserKeybindingNotice /> : null}
15021490
>
1503-
<div className="flex min-w-0 flex-col gap-2 px-3 py-3 sm:flex-row sm:items-center sm:px-4">
1491+
<div className="flex flex-wrap items-center gap-2 px-3 py-3 sm:px-4">
15041492
<KeybindingsSearchInput query={query} onChange={setQuery} inputRef={searchInputRef} />
1505-
<div className="ml-auto flex shrink-0 items-center gap-1.5">
1506-
<Button
1507-
type="button"
1508-
size="xs"
1509-
variant="ghost-muted"
1510-
disabled={isAddingBinding}
1511-
onClick={() => setIsAddingBinding(true)}
1512-
>
1513-
<PlusIcon />
1514-
Add keybinding
1515-
</Button>
1516-
<Tooltip>
1517-
<TooltipTrigger
1518-
render={
1519-
<Button
1520-
type="button"
1521-
size="icon-xs"
1522-
variant="ghost-muted"
1523-
disabled={!keybindingsConfigPath}
1524-
onClick={openKeybindingsFile}
1525-
aria-label="Open keybindings.json"
1526-
>
1527-
<FileJsonIcon />
1528-
</Button>
1529-
}
1530-
/>
1531-
<TooltipPopup side="top">Open keybindings.json</TooltipPopup>
1532-
</Tooltip>
1533-
</div>
1493+
<Button
1494+
type="button"
1495+
variant="outline"
1496+
disabled={isAddingBinding}
1497+
onClick={() => setIsAddingBinding(true)}
1498+
>
1499+
<PlusIcon aria-hidden className="size-4" />
1500+
Add keybinding
1501+
</Button>
1502+
<Tooltip>
1503+
<TooltipTrigger
1504+
render={
1505+
<Button
1506+
type="button"
1507+
variant="outline"
1508+
size="icon"
1509+
disabled={!keybindingsConfigPath}
1510+
onClick={openKeybindingsFile}
1511+
aria-label="Open keybindings.json"
1512+
>
1513+
<FileJsonIcon aria-hidden className="size-4" />
1514+
</Button>
1515+
}
1516+
/>
1517+
<TooltipPopup side="top">Open keybindings.json</TooltipPopup>
1518+
</Tooltip>
15341519
</div>
15351520
</SettingsSection>
15361521

0 commit comments

Comments
 (0)