Skip to content

Commit 53cf71e

Browse files
committed
fix(settings): localize the reset control strings
The reset button built its aria-label from a hard-coded English template and defaulted its tooltip to English, so a translated row title (zh-Hans) rendered mixed-language controls like 'Reset 界面字体 to default'. Both strings now come from the message catalog; English output is byte-identical to the old templates. Powered by GLM-5.3-Flash (bigmodel) via ZCode.
1 parent fe04368 commit 53cf71e

2 files changed

Lines changed: 9 additions & 3 deletions

File tree

‎apps/web/src/components/settings/settingsLayout.tsx‎

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ import {
1212
PRIMARY_SETTINGS_UNAVAILABLE_MESSAGE,
1313
usePrimarySettingsAvailable,
1414
} from "../../hooks/useSettings";
15+
import { useT } from "../../hooks/useI18n";
1516
import { cn } from "../../lib/utils";
1617
import { WorkspacePageContainer, type WorkspacePageWidth } from "../WorkspacePageContainer";
1718
import { Button } from "../ui/button";
@@ -513,7 +514,7 @@ export function SettingsRow({
513514

514515
export function SettingResetButton({
515516
label,
516-
tooltip = "Reset to default",
517+
tooltip,
517518
disabled = false,
518519
onClick,
519520
}: {
@@ -522,14 +523,15 @@ export function SettingResetButton({
522523
disabled?: boolean;
523524
onClick: () => void;
524525
}) {
526+
const t = useT();
525527
return (
526528
<Tooltip>
527529
<TooltipTrigger
528530
render={
529531
<Button
530532
size="icon-micro"
531533
variant="ghost-muted"
532-
aria-label={`Reset ${label} to default`}
534+
aria-label={t("settings.layout.resetToDefault", { label })}
533535
disabled={disabled}
534536
onClick={(event) => {
535537
event.stopPropagation();
@@ -540,7 +542,7 @@ export function SettingResetButton({
540542
</Button>
541543
}
542544
/>
543-
<TooltipPopup side="top">{tooltip}</TooltipPopup>
545+
<TooltipPopup side="top">{tooltip ?? t("settings.layout.resetToDefaultShort")}</TooltipPopup>
544546
</Tooltip>
545547
);
546548
}

‎packages/client-runtime/src/i18n/messagesSettingsNav.ts‎

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,8 @@ export const enMessages = {
3939
"settings.nav.breadcrumb.a11y": "Settings breadcrumb",
4040
"settings.nav.breadcrumb.openSourceLicenses": "Open source licenses",
4141
"settings.commandPalette.sectionDescription": "Settings · {section}",
42+
"settings.layout.resetToDefault": "Reset {label} to default",
43+
"settings.layout.resetToDefaultShort": "Reset to default",
4244
} as const;
4345

4446
export const zhHansMessages: Partial<Record<keyof typeof enMessages, string>> = {
@@ -77,4 +79,6 @@ export const zhHansMessages: Partial<Record<keyof typeof enMessages, string>> =
7779
"settings.nav.breadcrumb.a11y": "设置面包屑导航",
7880
"settings.nav.breadcrumb.openSourceLicenses": "开源许可",
7981
"settings.commandPalette.sectionDescription": "设置 · {section}",
82+
"settings.layout.resetToDefault": "重置{label}为默认",
83+
"settings.layout.resetToDefaultShort": "恢复默认",
8084
};

0 commit comments

Comments
 (0)