Skip to content

Commit 5337205

Browse files
committed
test(web): fix release browser test failures
1 parent ca140c4 commit 5337205

3 files changed

Lines changed: 13 additions & 3 deletions

File tree

‎apps/web/src/components/chat/ComposerBannerStack.browser.test.tsx‎

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,10 @@ it("keeps only the usage limit attached while an active goal waits in the collap
8484
"Usage limit reached",
8585
);
8686

87-
await page.getByRole("button", { name: "Show other notices" }).click();
87+
const peek = page.getByRole("button", { name: "Show other notices" });
88+
// Hover opens the stack and hides the peek before a pointer click can finish.
89+
await act(() => peek.element().focus());
90+
await userEvent.keyboard("{Enter}");
8891
await expect.element(goal).toBeVisible();
8992
await expect.element(limit).toBeVisible();
9093
await expect.poll(visibleBanners).toHaveLength(2);
@@ -93,6 +96,11 @@ it("keeps only the usage limit attached while an active goal waits in the collap
9396
await expect.element(goal).not.toBeVisible();
9497
await expect.element(limit).toBeVisible();
9598
expect(visibleBanners()).toHaveLength(1);
99+
100+
await userEvent.hover(peek);
101+
await expect.element(goal).toBeVisible();
102+
await expect.element(limit).toBeVisible();
103+
await expect.poll(visibleBanners).toHaveLength(2);
96104
});
97105

98106
it("reveals the full running command only while its title is clipped", async () => {

‎apps/web/src/components/diffs/StyledDiffCodeView.browser.test.tsx‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,8 @@ describe("code-view worker lifecycle", () => {
200200
};
201201
}
202202

203-
it("starts on demand, keeps quick reopens warm, and expires the last closed pool", async () => {
203+
// Two cold starts can each use Pierre's 10-second initialization budget.
204+
it("starts workers on demand and expires idle pools", { timeout: 30_000 }, async () => {
204205
setup();
205206
await using workers = await workerEnvironment();
206207
const view = await workers.render(renderViews(0));

‎apps/web/src/components/pullRequest/PullRequestDetailPanel.browser.test.tsx‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -398,14 +398,15 @@ describe.each([
398398
);
399399
});
400400

401+
// The first Code-tab action starts real diff workers as well as driving the panel.
401402
it.each([
402403
"Resolve conflicts",
403404
"Ask a question",
404405
"Explain this PR",
405406
"Fix findings in this thread",
406407
"Fix check",
407408
"Add to agent",
408-
])("%s writes to the correct composer", async (action) => {
409+
])("%s writes to the correct composer", { timeout: 30_000 }, async (action) => {
409410
setup();
410411
// Cover both a host without inline comments and an account that cannot write them.
411412
currentDetail =

0 commit comments

Comments
 (0)