@@ -22,7 +22,6 @@ import {
2222import React , {
2323 type FormEvent ,
2424 type KeyboardEvent ,
25- useEffect ,
2625 useLayoutEffect ,
2726 useRef ,
2827 useState ,
@@ -189,21 +188,24 @@ export function ProjectScriptEditorDialog({
189188 [ request ] ,
190189 ) ;
191190
192- useEffect ( ( ) => {
193- if ( ! request ) return ;
194- setName ( request . initial . name ) ;
195- setCommand ( request . initial . command ) ;
196- setIcon ( request . initial . icon ) ;
197- setIconPickerOpen ( false ) ;
198- setRunOnWorktreeCreate ( request . initial . runOnWorktreeCreate ) ;
199- setWaitForSetup ( request . initial . waitForSetup ) ;
200- setRunOnSettle ( request . initial . runOnSettle ) ;
201- setKeybinding ( request . initial . keybinding ?? "" ) ;
202- setPreviewUrl ( request . initial . previewUrl ?? "" ) ;
203- setAutoOpenPreview ( request . initial . autoOpenPreview ) ;
204- setValidationError ( request . error ?? null ) ;
205- setSavingRequest ( null ) ;
206- } , [ request , setIconPickerOpen ] ) ;
191+ const [ formRequest , setFormRequest ] = useState < ProjectScriptEditorRequest | null > ( null ) ;
192+ if ( request !== formRequest ) {
193+ setFormRequest ( request ) ;
194+ if ( request ) {
195+ setName ( request . initial . name ) ;
196+ setCommand ( request . initial . command ) ;
197+ setIcon ( request . initial . icon ) ;
198+ setIconPickerOpen ( false ) ;
199+ setRunOnWorktreeCreate ( request . initial . runOnWorktreeCreate ) ;
200+ setWaitForSetup ( request . initial . waitForSetup ) ;
201+ setRunOnSettle ( request . initial . runOnSettle ) ;
202+ setKeybinding ( request . initial . keybinding ?? "" ) ;
203+ setPreviewUrl ( request . initial . previewUrl ?? "" ) ;
204+ setAutoOpenPreview ( request . initial . autoOpenPreview ) ;
205+ setValidationError ( request . error ?? null ) ;
206+ setSavingRequest ( null ) ;
207+ }
208+ }
207209
208210 const close = ( ) => {
209211 pendingSubmissionRef . current = null ;
0 commit comments