Skip to content

Commit 521eeb4

Browse files
fix(server): recovery no longer scans completed turn items for unfinished work
getRuntimeRecoveryProjection's provider-thread read looks up unfinished turn items without a type filter, so the type-filtered recovery index could not serve it and SQLite scanned the thread's whole item history. Add a status-only partial index on thread_id in a new migration so existing and fresh databases both get it. Fixes #21578 Co-Authored-By: Claude Opus 5.5 <[email protected]>
1 parent b802dda commit 521eeb4

3 files changed

Lines changed: 18 additions & 0 deletions

File tree

‎apps/server/src/persistence/Migrations.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,7 @@ import Migration0064 from "./Migrations/064_CanonicalizeThreadPullRequestLinks.t
7070
import Migration0065 from "./Migrations/065_CodexUsageNativeTurnIndex.ts";
7171
import Migration0066 from "./Migrations/066_RepairClientSettlementTimestamps.ts";
7272
import Migration0067 from "./Migrations/067_WebhookDedupe.ts";
73+
import Migration0068 from "./Migrations/068_UnfinishedTurnItemsIndex.ts";
7374

7475
const migrationEntries = [
7576
[1, "OrchestrationEvents", Migration0001],
@@ -140,6 +141,7 @@ const migrationEntries = [
140141
[65, "CodexUsageNativeTurnIndex", Migration0065],
141142
[66, "RepairClientSettlementTimestamps", Migration0066],
142143
[67, "WebhookDedupe", Migration0067],
144+
[68, "UnfinishedTurnItemsIndex", Migration0068],
143145
] as const;
144146

145147
export const migrationManifest = migrationEntries.map(([id, name]) => [id, name] as const);
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
import * as Effect from "effect/Effect";
2+
import * as SqlClient from "effect/sql/SqlClient";
3+
4+
export default Effect.gen(function* () {
5+
const sql = yield* SqlClient.SqlClient;
6+
7+
// Recovery's provider-thread read looks up unfinished items of any type, which
8+
// the type-filtered recovery index cannot serve.
9+
yield* sql`
10+
CREATE INDEX orchestration_v2_projection_turn_items_unfinished_idx
11+
ON orchestration_v2_projection_turn_items(thread_id)
12+
WHERE status IN ('pending', 'running', 'waiting')
13+
`;
14+
});

‎apps/server/src/persistence/reconcileV2PreviewMigration.test.ts‎

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -47,6 +47,7 @@ describe("V2 preview upgrade", () => {
4747
[65, "CodexUsageNativeTurnIndex"],
4848
[66, "RepairClientSettlementTimestamps"],
4949
[67, "WebhookDedupe"],
50+
[68, "UnfinishedTurnItemsIndex"],
5051
]);
5152
assert.deepStrictEqual(yield* runMigrations(), []);
5253
assert.deepStrictEqual(yield* sql`SELECT * FROM orchestration_v2_legacy_imports`, imports);
@@ -137,6 +138,7 @@ describe("V2 preview upgrade", () => {
137138
[65, "CodexUsageNativeTurnIndex"],
138139
[66, "RepairClientSettlementTimestamps"],
139140
[67, "WebhookDedupe"],
141+
[68, "UnfinishedTurnItemsIndex"],
140142
]);
141143
}).pipe(Effect.provide(NodeSqliteClient.layer({ filename: ":memory:" }))),
142144
);

0 commit comments

Comments
 (0)