Repository navigation
Commit 51ea2b1
committed
fix: prevent user-input activities from leaking into pending approvals projection
Activities with a requestId in their payload (e.g. user-input.requested,
user-input.resolved) were incorrectly creating rows in the
projection_pending_approvals table. The fall-through default branch in
applyPendingApprovalsProjection only checked for approval.resolved and
provider.approval.respond.failed before unconditionally upserting a
"pending" row for any remaining activity carrying a requestId.
This caused threads with answered user-input prompts to permanently
display "Pending Approval" in the sidebar, since user-input.resolved
never clears the erroneous pending row — only approval.resolved does.
Add a kind guard (approval.requested) before the pending-row creation
path, consistent with the backfill migration 024 which already filters
by kind = 'approval.requested'.1 parent 5e1dd56 commit 51ea2b1
1 file changed
Lines changed: 8 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1284 | 1284 | | |
1285 | 1285 | | |
1286 | 1286 | | |
| 1287 | + | |
| 1288 | + | |
| 1289 | + | |
| 1290 | + | |
| 1291 | + | |
| 1292 | + | |
| 1293 | + | |
| 1294 | + | |
1287 | 1295 | | |
1288 | 1296 | | |
1289 | 1297 | | |
| |||
0 commit comments