@@ -2448,9 +2448,7 @@ describe("PreviewManager", () => {
24482448 const framesBeforePictureInPictureOnlyTick = pictureInPictureSend . mock . calls . length ;
24492449 yield * TestClock . adjust ( 100 ) ;
24502450 expect ( capturePage ) . toHaveBeenCalledTimes ( 3 ) ;
2451- expect ( pictureInPictureSend . mock . calls . length ) . toBeGreaterThan (
2452- framesBeforePictureInPictureOnlyTick ,
2453- ) ;
2451+ expect ( pictureInPictureSend . mock . calls . length ) . toBe ( framesBeforePictureInPictureOnlyTick ) ;
24542452 expect ( recordingFrames ) . toHaveLength ( 1 ) ;
24552453
24562454 setBackgroundThrottling . mockImplementationOnce ( ( ) => {
@@ -2467,6 +2465,51 @@ describe("PreviewManager", () => {
24672465 ) ,
24682466 ) ;
24692467
2468+ effectIt . effect ( "delivers recording frames only when pixels change" , ( ) =>
2469+ withManager ( ( manager ) =>
2470+ Effect . gen ( function * ( ) {
2471+ const unchanged = Buffer . from ( "unchanged-preview-frame" ) ;
2472+ const changed = Buffer . from ( "changed-preview-frame" ) ;
2473+ let captureIndex = 0 ;
2474+ const capturePage = vi . fn ( async ( ) => {
2475+ const jpeg = captureIndex < 2 ? unchanged : changed ;
2476+ captureIndex += 1 ;
2477+ return {
2478+ toJPEG : ( ) => jpeg ,
2479+ getSize : ( ) => ( { width : 1280 , height : 720 } ) ,
2480+ } ;
2481+ } ) ;
2482+ fromId . mockReturnValue ( makeTestPreviewWebContents ( capturePage ) ) ;
2483+ const frames : DesktopPreviewRecordingFrame [ ] = [ ] ;
2484+
2485+ yield * manager . subscribeRecordingFrames ( ( frame ) =>
2486+ Effect . sync ( ( ) => {
2487+ frames . push ( frame ) ;
2488+ } ) ,
2489+ ) ;
2490+ yield * manager . createTab ( "tab_unchanged_frame" ) ;
2491+ yield * manager . registerWebview ( "tab_unchanged_frame" , 42 ) ;
2492+ yield * manager . startRecording ( "tab_unchanged_frame" ) ;
2493+
2494+ expect ( frames . map ( ( frame ) => frame . data ) ) . toEqual ( [ unchanged . toString ( "base64" ) ] ) ;
2495+
2496+ yield * TestClock . adjust ( 100 ) ;
2497+
2498+ expect ( capturePage ) . toHaveBeenCalledTimes ( 2 ) ;
2499+ expect ( frames . map ( ( frame ) => frame . data ) ) . toEqual ( [ unchanged . toString ( "base64" ) ] ) ;
2500+
2501+ yield * TestClock . adjust ( 100 ) ;
2502+
2503+ expect ( capturePage ) . toHaveBeenCalledTimes ( 3 ) ;
2504+ expect ( frames . map ( ( frame ) => frame . data ) ) . toEqual ( [
2505+ unchanged . toString ( "base64" ) ,
2506+ changed . toString ( "base64" ) ,
2507+ ] ) ;
2508+ yield * manager . stopRecording ( "tab_unchanged_frame" ) ;
2509+ } ) ,
2510+ ) ,
2511+ ) ;
2512+
24702513 effectIt . effect ( "retries a cold hidden-tab capture without dropping recording" , ( ) =>
24712514 withManager ( ( manager ) =>
24722515 Effect . gen ( function * ( ) {
0 commit comments