Skip to content

Commit 517ca45

Browse files
committed
fix(opencode): show Unknown when reasoning is unavailable
1 parent 3665646 commit 517ca45

4 files changed

Lines changed: 9 additions & 11 deletions

File tree

‎apps/web/src/components/chat/TraitsPicker.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -237,7 +237,7 @@ describe("buildUnavailableModelOptionDescriptors", () => {
237237
});
238238
});
239239

240-
it("shows Default only with a matching provider report", () => {
240+
it("shows Unknown until a matching provider report provides Default", () => {
241241
const selection = {
242242
instanceId: ProviderInstanceId.make("opencode"),
243243
model: "ling",
@@ -259,7 +259,7 @@ it("shows Default only with a matching provider report", () => {
259259
ultrathinkPromptControlled: false,
260260
modelSelection: selection,
261261
};
262-
expect(buildTraitsTriggerDisplay(input).label).toBe("");
262+
expect(buildTraitsTriggerDisplay(input).label).toBe("Unknown");
263263
expect(
264264
buildTraitsTriggerDisplay({
265265
...input,

‎packages/client-runtime/src/state/threadExecution.test.ts‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -581,7 +581,7 @@ describe("provider-reported model selection", () => {
581581
capabilities: {
582582
optionDescriptors: [
583583
{
584-
id: "reasoningEffort",
584+
id: "variant",
585585
label: "Reasoning",
586586
type: "select" as const,
587587
options: [{ id: "high", label: "High" }],
@@ -590,7 +590,8 @@ describe("provider-reported model selection", () => {
590590
},
591591
},
592592
];
593-
expect(formatModelSelectionEffort(selected, models, reported)).toBe("Default");
594-
expect(formatModelSelectionEffort(selected, models)).toBeNull();
593+
const variantReport = { ...selected, options: [{ id: "variant", value: "default" }] };
594+
expect(formatModelSelectionEffort(selected, models, variantReport)).toBe("Default");
595+
expect(formatModelSelectionEffort(selected, models)).toBe("Unknown");
595596
});
596597
});

‎packages/shared/src/model.test.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -334,14 +334,14 @@ describe("provider-reported option display", () => {
334334
).toBe("None");
335335
expect(descriptor.options.map((option) => option.id)).toEqual(["none", "thinking"]);
336336
expect(buildProviderOptionSelectionsFromDescriptors([descriptor])).toBeUndefined();
337-
expect(getProviderOptionCurrentLabel(descriptor, selection)).toBeUndefined();
337+
expect(getProviderOptionCurrentLabel(descriptor, selection)).toBe("Unknown");
338338
});
339339

340340
it.each([
341341
{ ...selection, model: "other" },
342342
{ ...selection, instanceId: ProviderInstanceId.make("other") },
343343
{ ...selection, options: [{ id: "variant", value: "none" }] },
344344
])("ignores reports after changing the model, instance, or option: %j", (selected) => {
345-
expect(getProviderOptionCurrentLabel(descriptor, selected, reported)).toBeUndefined();
345+
expect(getProviderOptionCurrentLabel(descriptor, selected, reported)).toBe("Unknown");
346346
});
347347
});

‎packages/shared/src/model.ts‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -246,12 +246,9 @@ export function getProviderOptionCurrentLabel(
246246
: undefined;
247247
}
248248
const currentValue = getProviderOptionCurrentValue(descriptor, selection, reportedSelection);
249-
if (typeof currentValue !== "string") {
250-
return undefined;
251-
}
252249
return (
253250
descriptor.options.find((option) => option.id === currentValue)?.label ??
254-
(currentValue === "default" ? "Default" : undefined)
251+
(currentValue === "default" ? "Default" : descriptor.id === "variant" ? "Unknown" : undefined)
255252
);
256253
}
257254

0 commit comments

Comments
 (0)