Skip to content

Commit 513f708

Browse files
maria-rckssaphid
andcommitted
fix(pi): publish approval cards before actionable requests
Co-authored-by: Alex Southwell <[email protected]>
1 parent f762ae0 commit 513f708

2 files changed

Lines changed: 27 additions & 5 deletions

File tree

‎packages/provider-pi/src/server/adapter.test.ts‎

Lines changed: 25 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3236,9 +3236,31 @@ describe("PiAdapterV2", () => {
32363236
title: "Run project extensions?",
32373237
message: "This project has .pi/extensions.",
32383238
});
3239-
const pending = yield* takeEvent(
3240-
(event) =>
3241-
event.type === "runtime_request.updated" && event.runtimeRequest.status === "pending",
3239+
const artifacts: ProviderAdapter.ProviderAdapterV2Event[] = [];
3240+
const pending = yield* takeEvent((event) => {
3241+
artifacts.push(event);
3242+
return (
3243+
event.type === "runtime_request.updated" && event.runtimeRequest.status === "pending"
3244+
);
3245+
});
3246+
if (pending.type !== "runtime_request.updated") return;
3247+
assert.isTrue(
3248+
artifacts.some(
3249+
(event) =>
3250+
event.type === "node.updated" &&
3251+
event.node.id === pending.runtimeRequest.nodeId &&
3252+
event.node.status === "waiting",
3253+
),
3254+
"the node must exist before an immediately answerable request",
3255+
);
3256+
assert.isTrue(
3257+
artifacts.some(
3258+
(event) =>
3259+
event.type === "turn_item.updated" &&
3260+
event.turnItem.nodeId === pending.runtimeRequest.nodeId &&
3261+
event.turnItem.status === "waiting",
3262+
),
3263+
"the card must exist before an immediately answerable request",
32423264
);
32433265
const requestId =
32443266
pending.type === "runtime_request.updated" ? pending.runtimeRequest.id : undefined;

‎packages/provider-pi/src/server/adapter.ts‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1434,14 +1434,14 @@ export const makePiAdapterV2 = Effect.fn("makePiAdapterV2")(function* (
14341434
turnItem,
14351435
};
14361436
pendingPrompts.set(String(requestId), pending);
1437+
yield* emit({ type: "node.updated", driver: PI_PROVIDER, node });
1438+
yield* emit({ type: "turn_item.updated", driver: PI_PROVIDER, turnItem });
14371439
yield* emit({
14381440
type: "runtime_request.updated",
14391441
driver: PI_PROVIDER,
14401442
threadId,
14411443
runtimeRequest,
14421444
});
1443-
yield* emit({ type: "node.updated", driver: PI_PROVIDER, node });
1444-
yield* emit({ type: "turn_item.updated", driver: PI_PROVIDER, turnItem });
14451445
if (expiresAt !== null) {
14461446
const now = yield* DateTime.now;
14471447
pending.expirationFiber = yield* Effect.sleep(

0 commit comments

Comments
 (0)