Skip to content

Commit 4fef307

Browse files
fix(mobile): keep the Duo's Home and pull request headers fixed (#24295)
Co-authored-by: Claude Opus 5.5 <[email protected]>
1 parent 6c21798 commit 4fef307

1 file changed

Lines changed: 8 additions & 2 deletions

File tree

‎apps/mobile/src/Stack.tsx‎

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ const HEADER_SCROLL_EDGE_EFFECTS = nativeHeaderScrollEdgeEffects(Platform.OS, Pl
148148

149149
type AppScreenOptions = NativeStackNavigationOptions & {
150150
readonly unstable_navigationItemStyle?: "editor";
151-
readonly unstable_headerMinimizationBehavior?: "onScrollUp";
151+
readonly unstable_headerMinimizationBehavior?: "onScrollUp" | "never";
152152
};
153153

154154
const GLASS_HEADER_OPTIONS: AppScreenOptions = {
@@ -178,6 +178,10 @@ const THREAD_HEADER_OPTIONS: AppScreenOptions = {
178178
unstable_headerMinimizationBehavior: "onScrollUp",
179179
};
180180

181+
// The Duo minimizes headers on scroll down by default. Home and the pull request lists
182+
// stutter against it on hardware (not reproducible in the simulator), so they keep theirs.
183+
const FIXED_DUO_HEADER: AppScreenOptions = { unstable_headerMinimizationBehavior: "never" };
184+
181185
const SOLID_HEADER_OPTIONS: AppScreenOptions = {
182186
headerBackButtonDisplayMode: "minimal",
183187
headerBackTitle: "",
@@ -649,6 +653,7 @@ const RootStackConfig = createWorkspaceStackNavigator({
649653
linking: "",
650654
options: {
651655
...GLASS_HEADER_OPTIONS,
656+
...FIXED_DUO_HEADER,
652657
contentStyle: { backgroundColor: "transparent" },
653658
headerBackVisible: false,
654659
...getCompactBrandHeaderOptions(),
@@ -660,7 +665,7 @@ const RootStackConfig = createWorkspaceStackNavigator({
660665
path: "pull-requests/:environmentId/:projectId/:repository/:number",
661666
parse: { number: Number },
662667
},
663-
options: DETAIL_HEADER_OPTIONS,
668+
options: { ...DETAIL_HEADER_OPTIONS, ...FIXED_DUO_HEADER },
664669
}),
665670
PullRequestGuideStop: createNativeStackScreen({
666671
screen: PullRequestGuideStopScreen,
@@ -684,6 +689,7 @@ const RootStackConfig = createWorkspaceStackNavigator({
684689
screen: PullRequestReviewersScreen,
685690
options: {
686691
...DETAIL_HEADER_OPTIONS,
692+
...FIXED_DUO_HEADER,
687693
...HORIZONTAL_FORM_SHEET_OPTIONS,
688694
sheetAllowedDetents: formSheetDetents(0.75),
689695
sheetGrabberVisible: true,

0 commit comments

Comments
 (0)