Repository navigation
Commit 4fd02c0
refactor(mobile): stop writing the resolved project filter back from an effect
Home and the split-view sidebar resolve a legacy per-environment scratch
project filter key to the shared scratch key in render, then also wrote
that resolved key back to the list options (and mobile preferences) from
a useEffect. Every reader already uses the resolved key, so the write-back
only caused an extra render and a preferences write after a legacy key
resolved.
Delete both write-back effects. The stored key now changes only when the
user picks a filter. One edge case changes: an unmigrated legacy key keeps
resolving on each render, so if every matching scratch project disappears
and an unrelated one appears later, it is no longer auto-selected.
Effects: HomeRouteScreen.tsx 1 -> 0, ThreadNavigationSidebar.tsx 1 -> 0.
Co-Authored-By: Claude Opus 5.5 <[email protected]>1 parent dc84b09 commit 4fd02c0
2 files changed
Lines changed: 15 additions & 19 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
6 | 6 | | |
7 | 7 | | |
8 | 8 | | |
9 | | - | |
| 9 | + | |
10 | 10 | | |
11 | 11 | | |
12 | 12 | | |
| |||
137 | 137 | | |
138 | 138 | | |
139 | 139 | | |
140 | | - | |
141 | | - | |
142 | | - | |
143 | | - | |
144 | | - | |
145 | | - | |
146 | | - | |
147 | | - | |
148 | | - | |
149 | | - | |
| 140 | + | |
| 141 | + | |
| 142 | + | |
| 143 | + | |
| 144 | + | |
| 145 | + | |
| 146 | + | |
| 147 | + | |
| 148 | + | |
| 149 | + | |
150 | 150 | | |
151 | 151 | | |
152 | 152 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| |||
198 | 198 | | |
199 | 199 | | |
200 | 200 | | |
201 | | - | |
202 | | - | |
| 201 | + | |
| 202 | + | |
| 203 | + | |
203 | 204 | | |
204 | 205 | | |
205 | 206 | | |
206 | | - | |
207 | | - | |
208 | | - | |
209 | | - | |
210 | | - | |
211 | 207 | | |
212 | 208 | | |
213 | 209 | | |
| |||
0 commit comments